* [PATCH] spi: ep93xx: update kerneldoc comments for ep93xx_spi
@ 2024-09-12 13:21 Arnd Bergmann
2024-09-12 13:45 ` Alexander Sverdlin
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-09-12 13:21 UTC (permalink / raw)
To: Mark Brown, Alexander Sverdlin, Linus Walleij, Nikita Shubin,
Arnd Bergmann
Cc: kernel test robot, Vinod Koul, linux-spi, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Two fields got removed but are still documented:
drivers/spi/spi-ep93xx.c:98: warning: Excess struct member 'dma_rx_data' description in 'ep93xx_spi'
drivers/spi/spi-ep93xx.c:98: warning: Excess struct member 'dma_tx_data' description in 'ep93xx_spi'
Fixes: 3cfe73256905 ("spi: ep93xx: add DT support for Cirrus EP93xx")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I've added this fixup in the ep93xx/dt-conversion branch
drivers/spi/spi-ep93xx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index ffbe0d522bce..dc6bdc74643d 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -76,8 +76,6 @@
* frame decreases this level and sending one frame increases it.
* @dma_rx: RX DMA channel
* @dma_tx: TX DMA channel
- * @dma_rx_data: RX parameters passed to the DMA engine
- * @dma_tx_data: TX parameters passed to the DMA engine
* @rx_sgt: sg table for RX transfers
* @tx_sgt: sg table for TX transfers
* @zeropage: dummy page used as RX buffer when only TX buffer is passed in by
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] spi: ep93xx: update kerneldoc comments for ep93xx_spi
2024-09-12 13:21 [PATCH] spi: ep93xx: update kerneldoc comments for ep93xx_spi Arnd Bergmann
@ 2024-09-12 13:45 ` Alexander Sverdlin
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Sverdlin @ 2024-09-12 13:45 UTC (permalink / raw)
To: Arnd Bergmann, Mark Brown, Linus Walleij, Nikita Shubin,
Arnd Bergmann
Cc: kernel test robot, Vinod Koul, linux-spi, linux-kernel
On Thu, 2024-09-12 at 13:21 +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Two fields got removed but are still documented:
>
> drivers/spi/spi-ep93xx.c:98: warning: Excess struct member 'dma_rx_data' description in 'ep93xx_spi'
> drivers/spi/spi-ep93xx.c:98: warning: Excess struct member 'dma_tx_data' description in 'ep93xx_spi'
>
> Fixes: 3cfe73256905 ("spi: ep93xx: add DT support for Cirrus EP93xx")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> I've added this fixup in the ep93xx/dt-conversion branch
>
> drivers/spi/spi-ep93xx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
> index ffbe0d522bce..dc6bdc74643d 100644
> --- a/drivers/spi/spi-ep93xx.c
> +++ b/drivers/spi/spi-ep93xx.c
> @@ -76,8 +76,6 @@
> * frame decreases this level and sending one frame increases it.
> * @dma_rx: RX DMA channel
> * @dma_tx: TX DMA channel
> - * @dma_rx_data: RX parameters passed to the DMA engine
> - * @dma_tx_data: TX parameters passed to the DMA engine
> * @rx_sgt: sg table for RX transfers
> * @tx_sgt: sg table for TX transfers
> * @zeropage: dummy page used as RX buffer when only TX buffer is passed in by
--
Alexander Sverdlin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-12 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 13:21 [PATCH] spi: ep93xx: update kerneldoc comments for ep93xx_spi Arnd Bergmann
2024-09-12 13:45 ` Alexander Sverdlin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox