[PATCH] spi: axi-spi-engine: fix missing bitfield include

[PATCH] spi: axi-spi-engine: fix missing bitfield include

[David Lechner]

Fix missing linux/bitfield.h include needed for FIELD_GET macro.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502031224.wvHipe06-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202502031250.64gElGDs-lkp@intel.com/
Signed-off-by: David Lechner <dlechner@baylibre.com>
---

Hi Mark,

I know you prefer patches like this to fix something in a patch that has
already been applied, but it doesn't look like you actually picked up the
offending commit[1] yet in your main tree, so I don't have a commit hash
for a proper Fixes: tag.

Do you want a fix like this or should I send a v8 with the fix squashed?

[1]: https://lore.kernel.org/linux-spi/20250113-dlech-mainline-spi-engine-offload-2-v7-7-e0860c81caae@baylibre.com/
---
 drivers/spi/spi-axi-spi-engine.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
index dd6077d3ff7b..da9840957778 100644
--- a/drivers/spi/spi-axi-spi-engine.c
+++ b/drivers/spi/spi-axi-spi-engine.c
@@ -6,6 +6,7 @@
  *  Author: Lars-Peter Clausen <lars@metafoo.de>
  */
 
+#include <linux/bitfield.h>
 #include <linux/bitops.h>
 #include <linux/clk.h>
 #include <linux/completion.h>
-- 
2.43.0

Re: [PATCH] spi: axi-spi-engine: fix missing bitfield include

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

On Thu, Feb 06, 2025 at 03:55:13PM -0600, David Lechner wrote:
> Fix missing linux/bitfield.h include needed for FIELD_GET macro.

This doesn't apply against current code, please check and resend.

> I know you prefer patches like this to fix something in a patch that has
> already been applied, but it doesn't look like you actually picked up the
> offending commit[1] yet in your main tree, so I don't have a commit hash
> for a proper Fixes: tag.

> Do you want a fix like this or should I send a v8 with the fix squashed?

> [1]: https://lore.kernel.org/linux-spi/20250113-dlech-mainline-spi-engine-offload-2-v7-7-e0860c81caae@baylibre.com/

I haven't applied that because of all the build issues that the bots
reported, you need to send a new version that build cleanly.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]