[PATCH v1 1/1] spi: oc-tiny: Remove unused of_gpio.h

[PATCH v1 1/1] spi: oc-tiny: Remove unused of_gpio.h

[Andy Shevchenko]

of_gpio.h is deprecated and subject to remove.
The driver doesn't use it, simply remove the unused header.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/spi/spi-oc-tiny.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-oc-tiny.c b/drivers/spi/spi-oc-tiny.c
index 6ea38f5e7d64..7d8c5cd680d1 100644
--- a/drivers/spi/spi-oc-tiny.c
+++ b/drivers/spi/spi-oc-tiny.c
@@ -184,8 +184,6 @@ static irqreturn_t tiny_spi_irq(int irq, void *dev)
 }
 
 #ifdef CONFIG_OF
-#include <linux/of_gpio.h>
-
 static int tiny_spi_of_probe(struct platform_device *pdev)
 {
 	struct tiny_spi *hw = platform_get_drvdata(pdev);
-- 
2.43.0.rc1.1.gbec44491f096

Re: [PATCH v1 1/1] spi: oc-tiny: Remove unused of_gpio.h

[Andy Shevchenko]

On Wed, Feb 28, 2024 at 09:37:31PM +0200, Andy Shevchenko wrote:
> of_gpio.h is deprecated and subject to remove.
> The driver doesn't use it, simply remove the unused header.

Hmm... did it fall through cracks or anything should I do?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] spi: oc-tiny: Remove unused of_gpio.h

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

On Mon, Mar 04, 2024 at 04:42:55PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 28, 2024 at 09:37:31PM +0200, Andy Shevchenko wrote:
> > of_gpio.h is deprecated and subject to remove.
> > The driver doesn't use it, simply remove the unused header.

> Hmm... did it fall through cracks or anything should I do?

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1 1/1] spi: oc-tiny: Remove unused of_gpio.h

[Andy Shevchenko]

On Mon, Mar 04, 2024 at 05:10:22PM +0000, Mark Brown wrote:
> On Mon, Mar 04, 2024 at 04:42:55PM +0200, Andy Shevchenko wrote:
> > On Wed, Feb 28, 2024 at 09:37:31PM +0200, Andy Shevchenko wrote:
> > > of_gpio.h is deprecated and subject to remove.
> > > The driver doesn't use it, simply remove the unused header.
> 
> > Hmm... did it fall through cracks or anything should I do?
> 
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so 
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.
> 
> Sending content free pings adds to the mail volume (if they are seen at
> all) which is often the problem and since they can't be reviewed
> directly if something has gone wrong you'll have to resend the patches
> anyway, so sending again is generally a better approach though there are
> some other maintainers who like them - if in doubt look at how patches
> for the subsystem are normally handled.

Right, but it looks like this is quite simple one that simply got unnoticed
or so...

-- 
With Best Regards,
Andy Shevchenko