From: Tommaso Merciai <tomm.merciai@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linuxfancy@googlegroups.com,
"Forest Bond" <forest@alittletooquiet.net>,
"Karolina Drobnik" <karolinadrobnik@gmail.com>,
"Aldas Taraškevičius" <aldas60@gmail.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vt6655: drop off byRxMode var in device.h
Date: Thu, 23 Dec 2021 22:52:03 +0100 [thread overview]
Message-ID: <20211223215203.GB7322@tom-desktop> (raw)
In-Reply-To: <YcF1baxVvP3j8Q/8@kroah.com>
On Tue, Dec 21, 2021 at 07:34:21AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 20, 2021 at 09:25:20PM +0100, Tommaso Merciai wrote:
> > Drop off unused variable byRxMode in device.h, this fix following
> > checkpatch.pl check:
> > CHECK: Avoid CamelCase: <byRxMode>
> > 131: FILE: drivers/staging/vt6655/device.h:131:
> > unsigned char byRxMode
>
> No need to line-wrap this.
>
> But this "problem" is not the real thing you are fixing. The real thing
> is the issue that this variable is not needed at all. Just say that, no
> need to justify it with a checkpatch warning, right?
Hi Greg,
Thanks for review. I'll fix commit body and resend in v3.
thanks,
tommaso
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2021-12-23 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 20:25 [PATCH v2] staging: vt6655: drop off byRxMode var in device.h Tommaso Merciai
2021-12-21 6:34 ` Greg Kroah-Hartman
2021-12-23 21:52 ` Tommaso Merciai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223215203.GB7322@tom-desktop \
--to=tomm.merciai@gmail.com \
--cc=aldas60@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxfancy@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox