* [PATCH v2] staging: vt6655: drop off byRxMode var in device.h
@ 2021-12-20 20:25 Tommaso Merciai
2021-12-21 6:34 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Tommaso Merciai @ 2021-12-20 20:25 UTC (permalink / raw)
Cc: tomm.merciai, linuxfancy, Forest Bond, Greg Kroah-Hartman,
Karolina Drobnik, Aldas Taraškevičius, Dan Carpenter,
linux-staging, linux-kernel
Drop off unused variable byRxMode in device.h, this fix following
checkpatch.pl check:
CHECK: Avoid CamelCase: <byRxMode>
131: FILE: drivers/staging/vt6655/device.h:131:
unsigned char byRxMode
Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
---
Changes since v1:
- Remove trailing whitespace in changelog as suggested by gregkh
drivers/staging/vt6655/device.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 4706bde1ec1d..84b1dcf80e47 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -128,8 +128,6 @@ struct vnt_private {
u32 memaddr;
u32 ioaddr;
- unsigned char byRxMode;
-
spinlock_t lock;
volatile int iTDUsed[TYPE_MAXTD];
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: vt6655: drop off byRxMode var in device.h
2021-12-20 20:25 [PATCH v2] staging: vt6655: drop off byRxMode var in device.h Tommaso Merciai
@ 2021-12-21 6:34 ` Greg Kroah-Hartman
2021-12-23 21:52 ` Tommaso Merciai
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2021-12-21 6:34 UTC (permalink / raw)
To: Tommaso Merciai
Cc: linuxfancy, Forest Bond, Karolina Drobnik,
Aldas Taraškevičius, Dan Carpenter, linux-staging,
linux-kernel
On Mon, Dec 20, 2021 at 09:25:20PM +0100, Tommaso Merciai wrote:
> Drop off unused variable byRxMode in device.h, this fix following
> checkpatch.pl check:
> CHECK: Avoid CamelCase: <byRxMode>
> 131: FILE: drivers/staging/vt6655/device.h:131:
> unsigned char byRxMode
No need to line-wrap this.
But this "problem" is not the real thing you are fixing. The real thing
is the issue that this variable is not needed at all. Just say that, no
need to justify it with a checkpatch warning, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: vt6655: drop off byRxMode var in device.h
2021-12-21 6:34 ` Greg Kroah-Hartman
@ 2021-12-23 21:52 ` Tommaso Merciai
0 siblings, 0 replies; 3+ messages in thread
From: Tommaso Merciai @ 2021-12-23 21:52 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linuxfancy, Forest Bond, Karolina Drobnik,
Aldas Taraškevičius, Dan Carpenter, linux-staging,
linux-kernel
On Tue, Dec 21, 2021 at 07:34:21AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 20, 2021 at 09:25:20PM +0100, Tommaso Merciai wrote:
> > Drop off unused variable byRxMode in device.h, this fix following
> > checkpatch.pl check:
> > CHECK: Avoid CamelCase: <byRxMode>
> > 131: FILE: drivers/staging/vt6655/device.h:131:
> > unsigned char byRxMode
>
> No need to line-wrap this.
>
> But this "problem" is not the real thing you are fixing. The real thing
> is the issue that this variable is not needed at all. Just say that, no
> need to justify it with a checkpatch warning, right?
Hi Greg,
Thanks for review. I'll fix commit body and resend in v3.
thanks,
tommaso
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-23 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-20 20:25 [PATCH v2] staging: vt6655: drop off byRxMode var in device.h Tommaso Merciai
2021-12-21 6:34 ` Greg Kroah-Hartman
2021-12-23 21:52 ` Tommaso Merciai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox