* [PATCH v2] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('
@ 2022-04-13 10:11 Aliya Rahmani
2022-04-13 10:26 ` Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Aliya Rahmani @ 2022-04-13 10:11 UTC (permalink / raw)
To: tomm.merciai; +Cc: gregkh, linux-staging, outreachy, Aliya Rahmani
Remove indentation to fix the checkpatch error that lines should not
end with a '('.
Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>
---
v1->v2: Add Indentation and remove the gap between static and void.
---
drivers/staging/vt6655/rxtx.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 53506e242a96..01dc83b2f4bc 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -567,19 +567,16 @@ s_uFillDataHead(
return buf->duration;
}
-static
-void
-s_vFillRTSHead(
- struct vnt_private *pDevice,
- unsigned char byPktType,
- void *pvRTS,
- unsigned int cbFrameLength,
- bool bNeedAck,
- bool bDisCRC,
- struct ieee80211_hdr *hdr,
- unsigned short wCurrentRate,
- unsigned char byFBOption
-)
+static void
+s_vFillRTSHead(struct vnt_private *pDevice,
+ unsigned char byPktType,
+ void *pvRTS,
+ unsigned int cbFrameLength,
+ bool bNeedAck,
+ bool bDisCRC,
+ struct ieee80211_hdr *hdr,
+ unsigned short wCurrentRate,
+ unsigned char byFBOption)
{
unsigned int uRTSFrameLen = 20;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '('
2022-04-13 10:11 [PATCH v2] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '(' Aliya Rahmani
@ 2022-04-13 10:26 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2022-04-13 10:26 UTC (permalink / raw)
To: Aliya Rahmani; +Cc: tomm.merciai, gregkh, linux-staging, outreachy
On Wed, 13 Apr 2022, Aliya Rahmani wrote:
> Remove indentation to fix the checkpatch error that lines should not
> end with a '('.
This comment doesn't completely describe what was done.
julia
>
> Signed-off-by: Aliya Rahmani <aliyarahmani786@gmail.com>
> ---
>
> v1->v2: Add Indentation and remove the gap between static and void.
>
> ---
> drivers/staging/vt6655/rxtx.c | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 53506e242a96..01dc83b2f4bc 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -567,19 +567,16 @@ s_uFillDataHead(
> return buf->duration;
> }
>
> -static
> -void
> -s_vFillRTSHead(
> - struct vnt_private *pDevice,
> - unsigned char byPktType,
> - void *pvRTS,
> - unsigned int cbFrameLength,
> - bool bNeedAck,
> - bool bDisCRC,
> - struct ieee80211_hdr *hdr,
> - unsigned short wCurrentRate,
> - unsigned char byFBOption
> -)
> +static void
> +s_vFillRTSHead(struct vnt_private *pDevice,
> + unsigned char byPktType,
> + void *pvRTS,
> + unsigned int cbFrameLength,
> + bool bNeedAck,
> + bool bDisCRC,
> + struct ieee80211_hdr *hdr,
> + unsigned short wCurrentRate,
> + unsigned char byFBOption)
> {
> unsigned int uRTSFrameLen = 20;
>
> --
> 2.25.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-13 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-13 10:11 [PATCH v2] staging: vt6655f: rxtx: code style - Fix Lines should not end with a '(' Aliya Rahmani
2022-04-13 10:26 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox