From: "Juan José Arboleda" <soyjuanarbol@gmail.com>
To: gregkh@linuxfoundation.org
Cc: greybus-dev@lists.linaro.org, johan@kernel.org,
linux-staging@lists.linux.dev, pure.logic@nexus-software.ie,
soyjuanarbol@gmail.com, trivial@kernel.org
Subject: [PATCH v2] staging: greybus: break multi statement macro into multiple lines
Date: Wed, 17 Jul 2024 22:32:07 -0500 [thread overview]
Message-ID: <20240718033207.333591-1-soyjuanarbol@gmail.com> (raw)
In-Reply-To: <2024071723-nurture-magical-7817@gregkh>
The macro `gb_loopback_stats_attrs` in the Greybus loopback driver
contains multiple statements, which should be enclosed in a do-while
loop to ensure proper execution and adhere to coding standards.
The latter is not possible as the macro expansion will create invalid C
syntax. Theres is not such thing like inner function definition inside a
global scope do-while in C.
This patch nukes the `gb_loopback_stats_attrs` macro to enclose,
addressing the style error flagged by checkpatch.pl.
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
---
Notes:
This new version uses a bit different approach so the commit message
will be a bit different as well.
P.S: Thanks for being that patience and apologies for that false
positive of building the non-included driver. Now it is tested-built.
drivers/staging/greybus/loopback.c | 29 +++++++++++++++++++----------
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 4313d3bbc23a..88d86b084f28 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -162,11 +162,6 @@ static ssize_t name##_avg_show(struct device *dev, \
} \
static DEVICE_ATTR_RO(name##_avg)
-#define gb_loopback_stats_attrs(field) \
- gb_loopback_ro_stats_attr(field, min, u); \
- gb_loopback_ro_stats_attr(field, max, u); \
- gb_loopback_ro_avg_attr(field)
-
#define gb_loopback_attr(field, type) \
static ssize_t field##_show(struct device *dev, \
struct device_attribute *attr, \
@@ -268,15 +263,29 @@ static void gb_loopback_check_attr(struct gb_loopback *gb)
}
/* Time to send and receive one message */
-gb_loopback_stats_attrs(latency);
+gb_loopback_ro_stats_attr(latency, min, u);
+gb_loopback_ro_stats_attr(latency, max, u);
+gb_loopback_ro_avg_attr(latency);
+
/* Number of requests sent per second on this cport */
-gb_loopback_stats_attrs(requests_per_second);
+gb_loopback_ro_stats_attr(requests_per_second, min, u);
+gb_loopback_ro_stats_attr(requests_per_second, max, u);
+gb_loopback_ro_avg_attr(requests_per_second);
+
/* Quantity of data sent and received on this cport */
-gb_loopback_stats_attrs(throughput);
+gb_loopback_ro_stats_attr(throughput, min, u);
+gb_loopback_ro_stats_attr(throughput, max, u);
+gb_loopback_ro_avg_attr(throughput);
+
/* Latency across the UniPro link from APBridge's perspective */
-gb_loopback_stats_attrs(apbridge_unipro_latency);
+gb_loopback_ro_stats_attr(apbridge_unipro_latency, min, u);
+gb_loopback_ro_stats_attr(apbridge_unipro_latency, max, u);
+gb_loopback_ro_avg_attr(apbridge_unipro_latency);
+
/* Firmware induced overhead in the GPBridge */
-gb_loopback_stats_attrs(gbphy_firmware_latency);
+gb_loopback_ro_stats_attr(gbphy_firmware_latency, min, u);
+gb_loopback_ro_stats_attr(gbphy_firmware_latency, max, u);
+gb_loopback_ro_avg_attr(gbphy_firmware_latency);
/* Number of errors encountered during loop */
gb_loopback_ro_attr(error);
--
2.45.2
next prev parent reply other threads:[~2024-07-18 3:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 6:58 [PATCH] staging: greybus: Enclose multi-statement macro in do-while loop Juan José Arboleda
2024-07-17 7:50 ` Greg KH
2024-07-17 8:28 ` Juan José Arboleda
2024-07-17 8:45 ` Greg KH
2024-07-18 3:32 ` Juan José Arboleda [this message]
2024-07-18 4:35 ` [PATCH v2] staging: greybus: break multi statement macro into multiple lines Greg KH
2024-07-18 4:47 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718033207.333591-1-soyjuanarbol@gmail.com \
--to=soyjuanarbol@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox