From: "Juan José Arboleda" <soyjuanarbol@gmail.com>
To: gregkh@linuxfoundation.org, pure.logic@nexus-software.ie,
johan@kernel.org
Cc: linux-staging@lists.linux.dev, trivial@kernel.org,
greybus-dev@lists.linaro.org
Subject: [PATCH] staging: greybus: Enclose multi-statement macro in do-while loop
Date: Wed, 17 Jul 2024 01:58:34 -0500 [thread overview]
Message-ID: <ZpdrmuzGgYDJ-Bb0@fedora> (raw)
The macro `gb_loopback_stats_attrs` in the Greybus loopback driver
contains multiple statements, which should be enclosed in a do-while
loop to ensure proper execution and adhere to coding standards.
This patch modifies the `gb_loopback_stats_attrs` macro to enclose
its statements in a do-while loop, addressing the style error flagged
by checkpatch.pl.
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
---
drivers/staging/greybus/loopback.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 4313d3bbc23a..a97de86c67a5 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -163,9 +163,11 @@ static ssize_t name##_avg_show(struct device *dev, \
static DEVICE_ATTR_RO(name##_avg)
#define gb_loopback_stats_attrs(field) \
- gb_loopback_ro_stats_attr(field, min, u); \
- gb_loopback_ro_stats_attr(field, max, u); \
- gb_loopback_ro_avg_attr(field)
+ do { \
+ gb_loopback_ro_stats_attr(field, min, u); \
+ gb_loopback_ro_stats_attr(field, max, u); \
+ gb_loopback_ro_avg_attr(field); \
+ } while (0)
#define gb_loopback_attr(field, type) \
static ssize_t field##_show(struct device *dev, \
--
2.45.2
next reply other threads:[~2024-07-17 6:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 6:58 Juan José Arboleda [this message]
2024-07-17 7:50 ` [PATCH] staging: greybus: Enclose multi-statement macro in do-while loop Greg KH
2024-07-17 8:28 ` Juan José Arboleda
2024-07-17 8:45 ` Greg KH
2024-07-18 3:32 ` [PATCH v2] staging: greybus: break multi statement macro into multiple lines Juan José Arboleda
2024-07-18 4:35 ` Greg KH
2024-07-18 4:47 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpdrmuzGgYDJ-Bb0@fedora \
--to=soyjuanarbol@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox