Linux kernel staging patches
 help / color / mirror / Atom feed
* [PATCH] media: atomisp: move trailing statement to next line.
@ 2024-07-30  8:42 Sakirnth Nagarasa
  2024-09-02 10:10 ` Hans de Goede
  0 siblings, 1 reply; 2+ messages in thread
From: Sakirnth Nagarasa @ 2024-07-30  8:42 UTC (permalink / raw)
  To: hdegoede, mchehab, sakari.ailus, gregkh, linux-media,
	linux-staging, linux-kernel
  Cc: ~lkcamp/patches, helen.koike

Fix checkpath error "ERROR: trailing statements should be on next line"
in ia_css_fpn.host.c:46.

Signed-off-by: Sakirnth Nagarasa <sakirnth@gmail.com>

---

Hello, this is my first patch to the kernel.
---
 .../atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
index 57b5e11e1..8ccfa99c6 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
@@ -43,7 +43,8 @@ ia_css_fpn_dump(
     const struct sh_css_isp_fpn_params *fpn,
     unsigned int level)
 {
-	if (!fpn) return;
+	if (!fpn)
+		return;
 	ia_css_debug_dtrace(level, "Fixed Pattern Noise Reduction:\n");
 	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
 			    "fpn_shift", fpn->shift);
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] media: atomisp: move trailing statement to next line.
  2024-07-30  8:42 [PATCH] media: atomisp: move trailing statement to next line Sakirnth Nagarasa
@ 2024-09-02 10:10 ` Hans de Goede
  0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2024-09-02 10:10 UTC (permalink / raw)
  To: Sakirnth Nagarasa, mchehab, sakari.ailus, gregkh, linux-media,
	linux-staging, linux-kernel
  Cc: ~lkcamp/patches, helen.koike

Hi,

On 7/30/24 10:42 AM, Sakirnth Nagarasa wrote:
> Fix checkpath error "ERROR: trailing statements should be on next line"
> in ia_css_fpn.host.c:46.
> 
> Signed-off-by: Sakirnth Nagarasa <sakirnth@gmail.com>


Thank you for your patch(es).

I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)

Regards,

Hans




> ---
> 
> Hello, this is my first patch to the kernel.
> ---
>  .../atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c      | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
> index 57b5e11e1..8ccfa99c6 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
> @@ -43,7 +43,8 @@ ia_css_fpn_dump(
>      const struct sh_css_isp_fpn_params *fpn,
>      unsigned int level)
>  {
> -	if (!fpn) return;
> +	if (!fpn)
> +		return;
>  	ia_css_debug_dtrace(level, "Fixed Pattern Noise Reduction:\n");
>  	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
>  			    "fpn_shift", fpn->shift);


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-02 10:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-30  8:42 [PATCH] media: atomisp: move trailing statement to next line Sakirnth Nagarasa
2024-09-02 10:10 ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox