* [PATCH] staging: atomisp: bnr: fix trailing statement
@ 2024-07-30 12:38 Kartik Kulkarni
2024-07-30 15:43 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Kartik Kulkarni @ 2024-07-30 12:38 UTC (permalink / raw)
To: hdegoede, mchehab, akari.ailus, gregkh, linux-media,
linux-staging, linux-kernel
Cc: ~lkcamp/patches, helen.koike, kartik.koolks
Fix checkpatch error trailing statements should be on next line in
ia_css_bnr.host.c:48.
---
Newbie to contributing to kernel code
---
Signed-off-by: Kartik Kulkarni <kartik.koolks@gmail.com>
---
.../atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
index 457a004e1..b75cfd309 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
@@ -45,7 +45,8 @@ ia_css_bnr_dump(
const struct sh_css_isp_bnr_params *bnr,
unsigned int level)
{
- if (!bnr) return;
+ if (!bnr)
+ return;
ia_css_debug_dtrace(level, "Bayer Noise Reduction:\n");
ia_css_debug_dtrace(level, "\t%-32s = %d\n",
"bnr_gain_all", bnr->gain_all);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: atomisp: bnr: fix trailing statement
2024-07-30 12:38 [PATCH] staging: atomisp: bnr: fix trailing statement Kartik Kulkarni
@ 2024-07-30 15:43 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-07-30 15:43 UTC (permalink / raw)
To: Kartik Kulkarni
Cc: hdegoede, mchehab, akari.ailus, gregkh, linux-media,
linux-staging, linux-kernel, ~lkcamp/patches, helen.koike
On Tue, Jul 30, 2024 at 12:38:42PM +0000, Kartik Kulkarni wrote:
> Fix checkpatch error trailing statements should be on next line in
> ia_css_bnr.host.c:48.
> ---
> Newbie to contributing to kernel code
> ---
>
> Signed-off-by: Kartik Kulkarni <kartik.koolks@gmail.com>
This signed off by line needs to go above the --- line.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-30 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-30 12:38 [PATCH] staging: atomisp: bnr: fix trailing statement Kartik Kulkarni
2024-07-30 15:43 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox