* [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325
@ 2024-08-28 1:18 Nilo Alexandre
2024-08-28 18:53 ` Philipp Hortmann
2024-08-29 9:52 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Nilo Alexandre @ 2024-08-28 1:18 UTC (permalink / raw)
To: gregkh, linux-staging, linux-kernel, ~lkcamp/patches
Remove linebreak to improve readability
CHECK: Alignment should match open parenthesis
Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
---
v4: Remove linebreak to improve readability
v3: Fix typo in commit message.
v2: Using tabs instead of spaces.
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index b25e83743956d..a80efe6c7c209 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -321,8 +321,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
if (priv->epromtype == EEPROM_93C46) {
if (!priv->autoload_fail_flag) {
- usValue = rtl92e_eeprom_read(dev,
- EEPROM_TxPwDiff_CrystalCap >> 1);
+ usValue = rtl92e_eeprom_read(dev, EEPROM_TxPwDiff_CrystalCap >> 1);
priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
priv->eeprom_crystal_cap = (usValue & 0xf000)
>> 12;
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325
2024-08-28 1:18 [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325 Nilo Alexandre
@ 2024-08-28 18:53 ` Philipp Hortmann
2024-08-29 9:52 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Hortmann @ 2024-08-28 18:53 UTC (permalink / raw)
To: Nilo Alexandre, gregkh, linux-staging, linux-kernel,
~lkcamp/patches
On 8/28/24 03:18, Nilo Alexandre wrote:
> Remove linebreak to improve readability
>
Hi Nilo,
please end the above sentences with a ".".
> CHECK: Alignment should match open parenthesis
Why do we need the above line?
Thanks for your support.
Bye Philipp
>
> Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
> ---
> v4: Remove linebreak to improve readability
> v3: Fix typo in commit message.
> v2: Using tabs instead of spaces.
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index b25e83743956d..a80efe6c7c209 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -321,8 +321,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
>
> if (priv->epromtype == EEPROM_93C46) {
> if (!priv->autoload_fail_flag) {
> - usValue = rtl92e_eeprom_read(dev,
> - EEPROM_TxPwDiff_CrystalCap >> 1);
> + usValue = rtl92e_eeprom_read(dev, EEPROM_TxPwDiff_CrystalCap >> 1);
> priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
> priv->eeprom_crystal_cap = (usValue & 0xf000)
> >> 12;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325
2024-08-28 1:18 [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325 Nilo Alexandre
2024-08-28 18:53 ` Philipp Hortmann
@ 2024-08-29 9:52 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2024-08-29 9:52 UTC (permalink / raw)
To: Nilo Alexandre; +Cc: linux-staging, linux-kernel, ~lkcamp/patches
On Tue, Aug 27, 2024 at 10:18:42PM -0300, Nilo Alexandre wrote:
> Remove linebreak to improve readability
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
What is the "325" in the subject line for?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-29 9:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-28 1:18 [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325 Nilo Alexandre
2024-08-28 18:53 ` Philipp Hortmann
2024-08-29 9:52 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox