Linux kernel staging patches
 help / color / mirror / Atom feed
From: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com
Cc: ~lkcamp/patches@lists.sr.ht, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] staging: rtl8723bs: change remaining printk to proper api and remove commented code
Date: Mon, 14 Oct 2024 22:47:36 -0300	[thread overview]
Message-ID: <20241015014738.41685-1-rodrigo.gobbi.7@gmail.com> (raw)

I noticed that recently some debug sources were removed at [1],
but some commented code were left inside some files, which I think 
was used at development stage. 

[1] https://lore.kernel.org/all/ab3d501e2ef0bb3980d8d271fb667ce20ed8dca5.1725826273.git.philipp.g.hortmann@gmail.com/

The change to pr_debug over hal/hal_com.c, function rtw_dump_raw_rssi_info(),
doesn't impact the user since is reported as 'debug only' on
the original caller: _linked_info_dump()

I don't have the hw, just loaded the module inside qemu after those changes.
Also, I'm suggesting in the series to remove the commented statements rather 
than changing them to pr_xxx() but I would like to ask an opinion about this.
Tks and regards.

Rodrigo Gobbi (2):
  staging: rtl8723bs: change remaining printk to proper api
  staging: rtl8723bs: remove unused debug statements

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c   |  6 +++---
 drivers/staging/rtl8723bs/hal/hal_com.c         |  8 ++++----
 drivers/staging/rtl8723bs/hal/odm.c             |  4 ----
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c   | 12 ++++++------
 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c   | 12 +-----------
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c  | 17 ++---------------
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c    |  2 +-
 7 files changed, 17 insertions(+), 44 deletions(-)

-- 
2.34.1


             reply	other threads:[~2024-10-15  1:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15  1:47 Rodrigo Gobbi [this message]
2024-10-15  1:47 ` [PATCH 1/2] staging: rtl8723bs: change remaining printk to proper api Rodrigo Gobbi
2024-10-15  9:42   ` Dan Carpenter
2024-10-15 21:38     ` Rodrigo Gobbi
2024-10-16  8:00       ` Greg KH
2024-10-15  1:47 ` [PATCH 2/2] staging: rtl8723bs: remove unused debug statements Rodrigo Gobbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241015014738.41685-1-rodrigo.gobbi.7@gmail.com \
    --to=rodrigo.gobbi.7@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox