From: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
To: dan.carpenter@linaro.org
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, philipp.g.hortmann@gmail.com,
rodrigo.gobbi.7@gmail.com, ~lkcamp/patches@lists.sr.ht
Subject: [PATCH 1/2] staging: rtl8723bs: change remaining printk to proper api
Date: Tue, 15 Oct 2024 18:38:22 -0300 [thread overview]
Message-ID: <20241015213822.8070-1-rodrigo.gobbi.7@gmail.com> (raw)
In-Reply-To: <d20087fc-586e-4a52-99e6-6a09b33ed00e@stanley.mountain>
> No, this isn't right. You'd need to use a mix of dev_dbg() and pr_cont().
> Basically in drivers it should always be dev_ printks except for pr_cont().
Tks, Dan, for the answer and suggestion. In this case, rather the dev_xxx(),
do you think we can go with netdev_dbg() since this is a network driver and around
the rtw_mlme_ext.c is already being used? (actually, I don't see a direct reference for struct device).
If yes, I would mix the netdev_dbg() and pr_cont().
About [2], it is acceptable to remove the statements like I'm proposing?
Tks and regards.
[2] https://lore.kernel.org/linux-staging/20241015014738.41685-1-rodrigo.gobbi.7@gmail.com/T/#m85d88af4dd8158a8e62ccb6c7257478b7de46d95
next prev parent reply other threads:[~2024-10-15 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 1:47 [PATCH 0/2] staging: rtl8723bs: change remaining printk to proper api and remove commented code Rodrigo Gobbi
2024-10-15 1:47 ` [PATCH 1/2] staging: rtl8723bs: change remaining printk to proper api Rodrigo Gobbi
2024-10-15 9:42 ` Dan Carpenter
2024-10-15 21:38 ` Rodrigo Gobbi [this message]
2024-10-16 8:00 ` Greg KH
2024-10-15 1:47 ` [PATCH 2/2] staging: rtl8723bs: remove unused debug statements Rodrigo Gobbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015213822.8070-1-rodrigo.gobbi.7@gmail.com \
--to=rodrigo.gobbi.7@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox