Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Cc: dan.carpenter@linaro.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev, philipp.g.hortmann@gmail.com,
	~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH 1/2] staging: rtl8723bs: change remaining printk to proper api
Date: Wed, 16 Oct 2024 10:00:22 +0200	[thread overview]
Message-ID: <2024101608-daycare-exterior-31fd@gregkh> (raw)
In-Reply-To: <20241015213822.8070-1-rodrigo.gobbi.7@gmail.com>

On Tue, Oct 15, 2024 at 06:38:22PM -0300, Rodrigo Gobbi wrote:
> > No, this isn't right.  You'd need to use a mix of dev_dbg() and pr_cont().
> > Basically in drivers it should always be dev_ printks except for pr_cont().
> 
> Tks, Dan, for the answer and suggestion. In this case, rather the dev_xxx(),
> do you think we can go with netdev_dbg() since this is a network driver and around
> the rtw_mlme_ext.c is already being used? (actually, I don't see a direct reference for struct device).
> If yes, I would mix the netdev_dbg() and pr_cont().

Please use netdev_dbg() for a networking driver.

thanks,

greg k-h

  reply	other threads:[~2024-10-16  8:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15  1:47 [PATCH 0/2] staging: rtl8723bs: change remaining printk to proper api and remove commented code Rodrigo Gobbi
2024-10-15  1:47 ` [PATCH 1/2] staging: rtl8723bs: change remaining printk to proper api Rodrigo Gobbi
2024-10-15  9:42   ` Dan Carpenter
2024-10-15 21:38     ` Rodrigo Gobbi
2024-10-16  8:00       ` Greg KH [this message]
2024-10-15  1:47 ` [PATCH 2/2] staging: rtl8723bs: remove unused debug statements Rodrigo Gobbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024101608-daycare-exterior-31fd@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    --cc=rodrigo.gobbi.7@gmail.com \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox