[PATCH] staging: gpib: Convert // comments to kernel-style block comments

[PATCH] staging: gpib: Convert // comments to kernel-style block comments

[Sandeep Salwan]

This patch replaces several // single-line comments with multiline
block comments in agilent_82350b.c. According to kernel coding style
guidelines, we should prefer /* ... */ over // comments, especially
for multi-line or verbose text. This is purely code cleanup only.

Signed-off-by: Sandeep Salwan <salwansandeep5@gmail.com>
---
 drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
index 53006d0cc79c..3cd01613d067 100644
--- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
+++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
@@ -31,8 +31,10 @@ int agilent_82350b_accel_read(gpib_board_t *board, uint8_t *buffer, size_t lengt
 	int i, num_fifo_bytes;
 	//hardware doesn't support checking for end-of-string character when using fifo
 	if (tms_priv->eos_flags & REOS) {
-		//pr_info("ag-rd: using tms9914 read for REOS %x EOS %x\n",tms_priv->eos_flags,
-		// tms_priv->eos);
+		/*
+		 * pr_info("ag-rd: using tms9914 read for REOS %x EOS %x\n",tms_priv->eos_flags,
+		 * tms_priv->eos);
+		 */
 		return tms9914_read(board, tms_priv, buffer, length, end, bytes_read);
 	}
 
-- 
2.47.1

Re: [PATCH] staging: gpib: Convert // comments to kernel-style block comments

[Greg KH]

On Tue, Jan 07, 2025 at 07:27:57PM -0500, Sandeep Salwan wrote:
> This patch replaces several // single-line comments with multiline
> block comments in agilent_82350b.c. According to kernel coding style
> guidelines, we should prefer /* ... */ over // comments, especially
> for multi-line or verbose text. This is purely code cleanup only.
> 
> Signed-off-by: Sandeep Salwan <salwansandeep5@gmail.com>
> ---
>  drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> index 53006d0cc79c..3cd01613d067 100644
> --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> @@ -31,8 +31,10 @@ int agilent_82350b_accel_read(gpib_board_t *board, uint8_t *buffer, size_t lengt
>  	int i, num_fifo_bytes;
>  	//hardware doesn't support checking for end-of-string character when using fifo
>  	if (tms_priv->eos_flags & REOS) {
> -		//pr_info("ag-rd: using tms9914 read for REOS %x EOS %x\n",tms_priv->eos_flags,
> -		// tms_priv->eos);
> +		/*
> +		 * pr_info("ag-rd: using tms9914 read for REOS %x EOS %x\n",tms_priv->eos_flags,
> +		 * tms_priv->eos);
> +		 */

That's not really a valid comment, right?  Why not just delete the line
entirely?

thanks,

greg k-h