* [PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata()
@ 2025-03-05 23:49 Saalim Quadri
2025-03-06 0:06 ` Saalim Quadri
2025-03-08 14:48 ` Jonathan Cameron
0 siblings, 2 replies; 3+ messages in thread
From: Saalim Quadri @ 2025-03-05 23:49 UTC (permalink / raw)
To: jic23
Cc: lars, Michael.Hennerich, gregkh, linux-iio, linux-kernel,
linux-staging, Saalim Quadri
By making use of devm_iio_device_register(), we no longer have a driver
remove callback.
Since this was the last user of spi_get_drvdata(),
we can drop the call to spi_set_drvdata().
Signed-off-by: Saalim Quadri <danascape@gmail.com>
---
drivers/staging/iio/accel/adis16203.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
index c1c73308800c..3faf3c61046a 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -267,8 +267,6 @@ static int adis16203_probe(struct spi_device *spi)
if (!indio_dev)
return -ENOMEM;
st = iio_priv(indio_dev);
- /* this is only used for removal purposes */
- spi_set_drvdata(spi, indio_dev);
indio_dev->name = spi->dev.driver->name;
indio_dev->channels = adis16203_channels;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata()
2025-03-05 23:49 [PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata() Saalim Quadri
@ 2025-03-06 0:06 ` Saalim Quadri
2025-03-08 14:48 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Saalim Quadri @ 2025-03-06 0:06 UTC (permalink / raw)
To: danascape
Cc: Michael.Hennerich, gregkh, jic23, lars, linux-iio, linux-kernel,
linux-staging
Sorry, I forgot to add a V2 description
V1 -> V2: Update commit message description
Sincerely,
Saalim Quadri
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata()
2025-03-05 23:49 [PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata() Saalim Quadri
2025-03-06 0:06 ` Saalim Quadri
@ 2025-03-08 14:48 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2025-03-08 14:48 UTC (permalink / raw)
To: Saalim Quadri
Cc: lars, Michael.Hennerich, gregkh, linux-iio, linux-kernel,
linux-staging
On Thu, 6 Mar 2025 05:19:49 +0530
Saalim Quadri <danascape@gmail.com> wrote:
> By making use of devm_iio_device_register(), we no longer have a driver
> remove callback.
> Since this was the last user of spi_get_drvdata(),
> we can drop the call to spi_set_drvdata().
>
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
As per other discussion. Dropping this one as
better to merge support into the adis16201 driver.
> ---
> drivers/staging/iio/accel/adis16203.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index c1c73308800c..3faf3c61046a 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -267,8 +267,6 @@ static int adis16203_probe(struct spi_device *spi)
> if (!indio_dev)
> return -ENOMEM;
> st = iio_priv(indio_dev);
> - /* this is only used for removal purposes */
> - spi_set_drvdata(spi, indio_dev);
>
> indio_dev->name = spi->dev.driver->name;
> indio_dev->channels = adis16203_channels;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-08 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-05 23:49 [PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata() Saalim Quadri
2025-03-06 0:06 ` Saalim Quadri
2025-03-08 14:48 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox