From: Michael Rubin <matchstick@neverthere.org>
To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Rubin <matchstick@neverthere.org>
Subject: [PATCH v3 00/18] staging: gpib: Removing typedef of gpib_interface_t
Date: Thu, 17 Apr 2025 00:32:28 +0000 [thread overview]
Message-ID: <20250417003246.84445-1-matchstick@neverthere.org> (raw)
Using Linux code style for struct gpib_interface.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
* Patch 1: "struct gpib_interface"
Having the word "_struct" in the name of the struct doesn't add any
information so rename "struct gpib_interface_struct" to
"struct gpib_interface".
* Patch 2 - Patch 17: Replacing gpib_interface_t with "struct gpib_interface"
* Patch 18: Removing typedef for gpib_interface_t.
v3 fixes a build issue in v2 "staging: gpib: gpibP: struct gpib_interface"
Michael Rubin (18):
staging: gpib: struct typing for gpib_interface
staging: gpib: agilent_82350b: gpib_interface
staging: gpib: agilent_82357a: gpib_interface
staging: gpib: cb7210: struct gpib_interface
staging: gpib: cec: struct gpib_interface
staging: gpib: common: struct gpib_interface
staging: gpib: fluke: struct gpib_interface
staging: gpib: fmh: struct gpib_interface
staging: gpib: gpio: struct gpib_interface
staging: gpib: hp_82335: struct gpib_interface
staging: gpib: hp2341: struct gpib_interface
staging: gpib: gpibP: struct gpib_interface
staging: gpib: ines: struct gpib_interface
staging: gpib: lpvo_usb: struct gpib_interface
staging: gpib: ni_usb: struct gpib_interface
staging: gpib: pc2: struct gpib_interface
staging: gpib: tnt4882: struct gpib_interface
staging: gpib: Removing typedef gpib_interface_t
.../gpib/agilent_82350b/agilent_82350b.c | 4 ++--
.../gpib/agilent_82357a/agilent_82357a.c | 2 +-
drivers/staging/gpib/cb7210/cb7210.c | 18 +++++++-------
drivers/staging/gpib/cec/cec_gpib.c | 2 +-
drivers/staging/gpib/common/gpib_os.c | 4 ++--
drivers/staging/gpib/eastwood/fluke_gpib.c | 6 ++---
drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 8 +++----
drivers/staging/gpib/gpio/gpib_bitbang.c | 2 +-
drivers/staging/gpib/hp_82335/hp82335.c | 2 +-
drivers/staging/gpib/hp_82341/hp_82341.c | 4 ++--
drivers/staging/gpib/include/gpibP.h | 4 ++--
drivers/staging/gpib/include/gpib_types.h | 9 ++++---
drivers/staging/gpib/ines/ines_gpib.c | 14 +++++------
.../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +-
drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 2 +-
drivers/staging/gpib/pc2/pc2_gpib.c | 8 +++----
drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 24 +++++++++----------
17 files changed, 57 insertions(+), 58 deletions(-)
--
2.43.0
next reply other threads:[~2025-04-17 0:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 0:32 Michael Rubin [this message]
2025-04-17 0:32 ` [PATCH v3 01/18] staging: gpib: struct typing for gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 02/18] staging: gpib: agilent_82350b: gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 03/18] staging: gpib: agilent_82357a: gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 04/18] staging: gpib: cb7210: struct gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 05/18] staging: gpib: cec: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 06/18] staging: gpib: common: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 07/18] staging: gpib: fluke: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 08/18] staging: gpib: fmh: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 09/18] staging: gpib: gpio: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 10/18] staging: gpib: hp_82335: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 11/18] staging: gpib: hp2341: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 12/18] staging: gpib: gpibP: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 13/18] staging: gpib: ines: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 14/18] staging: gpib: lpvo_usb: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 15/18] staging: gpib: ni_usb: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 16/18] staging: gpib: pc2: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 17/18] staging: gpib: tnt4882: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 18/18] staging: gpib: Removing typedef gpib_interface_t Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417003246.84445-1-matchstick@neverthere.org \
--to=matchstick@neverthere.org \
--cc=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox