From: Michael Rubin <matchstick@neverthere.org>
To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Rubin <matchstick@neverthere.org>
Subject: [PATCH v3 18/18] staging: gpib: Removing typedef gpib_interface_t
Date: Thu, 17 Apr 2025 00:32:46 +0000 [thread overview]
Message-ID: <20250417003246.84445-19-matchstick@neverthere.org> (raw)
In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org>
Removing gpib_interface_t to adhere to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
drivers/staging/gpib/include/gpib_types.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gpib/include/gpib_types.h
index 712987ca139f..0dbe45894884 100644
--- a/drivers/staging/gpib/include/gpib_types.h
+++ b/drivers/staging/gpib/include/gpib_types.h
@@ -8,7 +8,7 @@
#define _GPIB_TYPES_H
#ifdef __KERNEL__
-/* gpib_interface_t defines the interface
+/* gpib_interface defines the interface
* between the board-specific details dealt with in the drivers
* and generic interface provided by gpib-common.
* This really should be in a different header file.
@@ -22,7 +22,6 @@
#include <linux/timer.h>
#include <linux/interrupt.h>
-typedef struct gpib_interface gpib_interface_t;
struct gpib_board;
/* config parameters that are only used by driver attach functions */
@@ -212,7 +211,7 @@ static inline void init_gpib_pseudo_irq(struct gpib_pseudo_irq *pseudo_irq)
/* list so we can make a linked list of drivers */
struct gpib_interface_list {
struct list_head list;
- gpib_interface_t *interface;
+ struct gpib_interface *interface;
struct module *module;
};
@@ -222,7 +221,7 @@ struct gpib_interface_list {
*/
struct gpib_board {
/* functions used by this board */
- gpib_interface_t *interface;
+ struct gpib_interface *interface;
/* Pointer to module whose use count we should increment when
* interface is in use
*/
--
2.43.0
prev parent reply other threads:[~2025-04-17 0:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 0:32 [PATCH v3 00/18] staging: gpib: Removing typedef of gpib_interface_t Michael Rubin
2025-04-17 0:32 ` [PATCH v3 01/18] staging: gpib: struct typing for gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 02/18] staging: gpib: agilent_82350b: gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 03/18] staging: gpib: agilent_82357a: gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 04/18] staging: gpib: cb7210: struct gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 05/18] staging: gpib: cec: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 06/18] staging: gpib: common: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 07/18] staging: gpib: fluke: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 08/18] staging: gpib: fmh: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 09/18] staging: gpib: gpio: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 10/18] staging: gpib: hp_82335: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 11/18] staging: gpib: hp2341: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 12/18] staging: gpib: gpibP: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 13/18] staging: gpib: ines: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 14/18] staging: gpib: lpvo_usb: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 15/18] staging: gpib: ni_usb: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 16/18] staging: gpib: pc2: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 17/18] staging: gpib: tnt4882: " Michael Rubin
2025-04-17 0:32 ` Michael Rubin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417003246.84445-19-matchstick@neverthere.org \
--to=matchstick@neverthere.org \
--cc=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox