From: Michael Rubin <matchstick@neverthere.org>
To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Rubin <matchstick@neverthere.org>
Subject: [PATCH v3 04/18] staging: gpib: cb7210: struct gpib_interface
Date: Thu, 17 Apr 2025 00:32:32 +0000 [thread overview]
Message-ID: <20250417003246.84445-5-matchstick@neverthere.org> (raw)
In-Reply-To: <20250417003246.84445-1-matchstick@neverthere.org>
Using Linux code style for struct gpib_interface.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
---
drivers/staging/gpib/cb7210/cb7210.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c
index 9e26fea43fb9..08a50d1428ab 100644
--- a/drivers/staging/gpib/cb7210/cb7210.c
+++ b/drivers/staging/gpib/cb7210/cb7210.c
@@ -686,7 +686,7 @@ static void cb7210_return_to_local(struct gpib_board *board)
write_byte(nec_priv, AUX_RTL, AUXMR);
}
-static gpib_interface_t cb_pci_unaccel_interface = {
+static struct gpib_interface cb_pci_unaccel_interface = {
.name = "cbi_pci_unaccel",
.attach = cb_pci_attach,
.detach = cb_pci_detach,
@@ -714,7 +714,7 @@ static gpib_interface_t cb_pci_unaccel_interface = {
.return_to_local = cb7210_return_to_local,
};
-static gpib_interface_t cb_pci_accel_interface = {
+static struct gpib_interface cb_pci_accel_interface = {
.name = "cbi_pci_accel",
.attach = cb_pci_attach,
.detach = cb_pci_detach,
@@ -742,7 +742,7 @@ static gpib_interface_t cb_pci_accel_interface = {
.return_to_local = cb7210_return_to_local,
};
-static gpib_interface_t cb_pci_interface = {
+static struct gpib_interface cb_pci_interface = {
.name = "cbi_pci",
.attach = cb_pci_attach,
.detach = cb_pci_detach,
@@ -769,7 +769,7 @@ static gpib_interface_t cb_pci_interface = {
.return_to_local = cb7210_return_to_local,
};
-static gpib_interface_t cb_isa_unaccel_interface = {
+static struct gpib_interface cb_isa_unaccel_interface = {
.name = "cbi_isa_unaccel",
.attach = cb_isa_attach,
.detach = cb_isa_detach,
@@ -797,7 +797,7 @@ static gpib_interface_t cb_isa_unaccel_interface = {
.return_to_local = cb7210_return_to_local,
};
-static gpib_interface_t cb_isa_interface = {
+static struct gpib_interface cb_isa_interface = {
.name = "cbi_isa",
.attach = cb_isa_attach,
.detach = cb_isa_detach,
@@ -824,7 +824,7 @@ static gpib_interface_t cb_isa_interface = {
.return_to_local = cb7210_return_to_local,
};
-static gpib_interface_t cb_isa_accel_interface = {
+static struct gpib_interface cb_isa_accel_interface = {
.name = "cbi_isa_accel",
.attach = cb_isa_attach,
.detach = cb_isa_detach,
@@ -1334,7 +1334,7 @@ static void cb_pcmcia_cleanup_module(void)
pcmcia_unregister_driver(&cb_gpib_cs_driver);
}
-static gpib_interface_t cb_pcmcia_unaccel_interface = {
+static struct gpib_interface cb_pcmcia_unaccel_interface = {
.name = "cbi_pcmcia_unaccel",
.attach = cb_pcmcia_attach,
.detach = cb_pcmcia_detach,
@@ -1362,7 +1362,7 @@ static gpib_interface_t cb_pcmcia_unaccel_interface = {
.return_to_local = cb7210_return_to_local,
};
-static gpib_interface_t cb_pcmcia_interface = {
+static struct gpib_interface cb_pcmcia_interface = {
.name = "cbi_pcmcia",
.attach = cb_pcmcia_attach,
.detach = cb_pcmcia_detach,
@@ -1390,7 +1390,7 @@ static gpib_interface_t cb_pcmcia_interface = {
.return_to_local = cb7210_return_to_local,
};
-static gpib_interface_t cb_pcmcia_accel_interface = {
+static struct gpib_interface cb_pcmcia_accel_interface = {
.name = "cbi_pcmcia_accel",
.attach = cb_pcmcia_attach,
.detach = cb_pcmcia_detach,
--
2.43.0
next prev parent reply other threads:[~2025-04-17 0:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 0:32 [PATCH v3 00/18] staging: gpib: Removing typedef of gpib_interface_t Michael Rubin
2025-04-17 0:32 ` [PATCH v3 01/18] staging: gpib: struct typing for gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 02/18] staging: gpib: agilent_82350b: gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 03/18] staging: gpib: agilent_82357a: gpib_interface Michael Rubin
2025-04-17 0:32 ` Michael Rubin [this message]
2025-04-17 0:32 ` [PATCH v3 05/18] staging: gpib: cec: struct gpib_interface Michael Rubin
2025-04-17 0:32 ` [PATCH v3 06/18] staging: gpib: common: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 07/18] staging: gpib: fluke: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 08/18] staging: gpib: fmh: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 09/18] staging: gpib: gpio: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 10/18] staging: gpib: hp_82335: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 11/18] staging: gpib: hp2341: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 12/18] staging: gpib: gpibP: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 13/18] staging: gpib: ines: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 14/18] staging: gpib: lpvo_usb: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 15/18] staging: gpib: ni_usb: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 16/18] staging: gpib: pc2: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 17/18] staging: gpib: tnt4882: " Michael Rubin
2025-04-17 0:32 ` [PATCH v3 18/18] staging: gpib: Removing typedef gpib_interface_t Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417003246.84445-5-matchstick@neverthere.org \
--to=matchstick@neverthere.org \
--cc=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox