From: Greg KH <gregkh@linuxfoundation.org>
To: Mohammad Amin Hosseini <moahmmad.hosseinii@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, jic23@kernel.org, lars@metafoo.de,
Michael.Hennerich@analog.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org
Subject: Re: [PATCH v2] staging: iio: adc: ad7816: add mutex to serialize SPI/GPIO operations
Date: Mon, 1 Sep 2025 09:10:21 +0200 [thread overview]
Message-ID: <2025090147-tapeless-pursuant-3234@gregkh> (raw)
In-Reply-To: <20250901065445.8787-1-moahmmad.hosseinii@gmail.com>
On Mon, Sep 01, 2025 at 10:24:45AM +0330, Mohammad Amin Hosseini wrote:
> From: mohammad amin hosseini <moahmmad.hosseinii@gmail.com>
>
> The ad7816 driver was accessing SPI and GPIO lines without
> synchronization, which could lead to race conditions when accessed
> concurrently from multiple contexts. This might result in corrupted
> readings or inconsistent GPIO states.
>
> Introduce an io_lock mutex in the driver structure to serialize:
> - SPI transactions in ad7816_spi_read() and ad7816_spi_write()
> - GPIO pin toggling sequences
> - Updates to device state via sysfs store functions (mode, channel, oti)
>
> The mutex ensures proper mutual exclusion and prevents race
> conditions under concurrent access.
>
> Changes in v2:
> - Fixed mismatch between From: and Signed-off-by lines
>
> Signed-off-by: mohammad amin hosseini <moahmmad.hosseinii@gmail.com>
I think your old "From:" line was correct, as capital letters are
proper, right?
Also, the "v2" information goes below the --- line.
thanks,
greg k-h
next prev parent reply other threads:[~2025-09-01 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 6:54 [PATCH v2] staging: iio: adc: ad7816: add mutex to serialize SPI/GPIO operations Mohammad Amin Hosseini
2025-09-01 7:10 ` Greg KH [this message]
2025-09-01 10:23 ` Dan Carpenter
2025-09-01 12:40 ` Andy Shevchenko
2025-09-01 12:57 ` Dan Carpenter
2025-09-01 13:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025090147-tapeless-pursuant-3234@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=moahmmad.hosseinii@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox