From: Dan Carpenter <dan.carpenter@linaro.org>
To: Mohammad Amin Hosseini <moahmmad.hosseinii@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org
Subject: Re: [PATCH v2] staging: iio: adc: ad7816: add mutex to serialize SPI/GPIO operations
Date: Mon, 1 Sep 2025 16:08:22 +0300 [thread overview]
Message-ID: <aLWaxoBLEVWlfzN7@stanley.mountain> (raw)
In-Reply-To: <20250901065445.8787-1-moahmmad.hosseinii@gmail.com>
On Mon, Sep 01, 2025 at 10:24:45AM +0330, Mohammad Amin Hosseini wrote:
> @@ -200,7 +204,9 @@ static ssize_t ad7816_store_channel(struct device *dev,
> return -EINVAL;
> }
>
> + mutex_lock(&chip->io_lock);
> chip->channel_id = data;
> + mutex_unlock(&chip->io_lock);
>
> return len;
> }
Unrelated, but what is the point of setting chip->channel_id to
AD7816_CS_MASK? The only time where that is used is in
ad7816_spi_read() when we do:
ret = spi_write(spi_dev, &chip->channel_id, sizeof(chip->channel_id));
So it's something in the hardware spec, I guess, but it isn't
documented.
regards,
dan carpenter
prev parent reply other threads:[~2025-09-01 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 6:54 [PATCH v2] staging: iio: adc: ad7816: add mutex to serialize SPI/GPIO operations Mohammad Amin Hosseini
2025-09-01 7:10 ` Greg KH
2025-09-01 10:23 ` Dan Carpenter
2025-09-01 12:40 ` Andy Shevchenko
2025-09-01 12:57 ` Dan Carpenter
2025-09-01 13:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLWaxoBLEVWlfzN7@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=moahmmad.hosseinii@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox