[PATCH 2/4] staging: greybus: audio: avoid macro with side effects

[Zhan Xusheng <zhanxusheng1024@gmail.com>]

The gbaudio_dapm_for_each_direction() macro modifies its argument and
evaluates it multiple times, which can lead to subtle bugs if used with
expressions that have side effects.

Replace the macro with an explicit for-loop to improve readability and
avoid potential side effects.

No functional changes.

Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
 drivers/staging/greybus/audio_helper.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/greybus/audio_helper.c b/drivers/staging/greybus/audio_helper.c
index b4873c6d6bed..6264cafe9675 100644
--- a/drivers/staging/greybus/audio_helper.c
+++ b/drivers/staging/greybus/audio_helper.c
@@ -8,10 +8,6 @@
 #include <sound/soc-dapm.h>
 #include "audio_helper.h"
 
-#define gbaudio_dapm_for_each_direction(dir) \
-	for ((dir) = SND_SOC_DAPM_DIR_IN; (dir) <= SND_SOC_DAPM_DIR_OUT; \
-		(dir)++)
-
 static void gbaudio_dapm_link_dai_widget(struct snd_soc_dapm_widget *dai_w,
 					 struct snd_soc_card *card)
 {
@@ -98,7 +94,7 @@ static void gbaudio_dapm_free_widget(struct snd_soc_dapm_widget *w)
 	 * While removing the path, remove reference to it from both
 	 * source and sink widgets so that path is removed only once.
 	 */
-	gbaudio_dapm_for_each_direction(dir) {
+	for (dir = SND_SOC_DAPM_DIR_IN; dir <= SND_SOC_DAPM_DIR_OUT; dir++) {
 		snd_soc_dapm_widget_for_each_path_safe(w, dir, p, next_p)
 			gbaudio_dapm_free_path(p);
 	}
-- 
2.43.0