Re: [PATCH 1/4] staging: greybus: spilib: fix function parameter indentation

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Dec 19, 2025 at 02:34:12PM +0800, Zhan Xusheng wrote:
> Fix checkpatch.pl warning:
> "Alignment should match open parenthesis"
> by aligning wrapped function parameters with
> the opening parenthesis.
> 
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
> ---
>  drivers/staging/greybus/spilib.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c
> index 24e9c909fa02..416ca27a25ce 100644
> --- a/drivers/staging/greybus/spilib.c
> +++ b/drivers/staging/greybus/spilib.c
> @@ -159,8 +159,10 @@ static struct spi_transfer *get_next_xfer(struct spi_transfer *xfer,
>  }
>  
>  /* Routines to transfer data */
> -static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi,
> -		struct gb_connection *connection, struct spi_message *msg)
> +static struct gb_operation *
> +gb_spi_operation_create(struct gb_spilib *spi,
> +			struct gb_connection *connection,
> +			struct spi_message *msg)

This is where things get messy :(

The original is still best, as you can see the function name, and the
return type, on the same line, which many search tools really want to
show you when searching code.

So the existing code is fine, no need to worry about this warning here.

thanks,

greg k-h