From: Greg KH <greg@kroah.com>
To: Zhan Xusheng <zhanxusheng1024@gmail.com>
Cc: linux-staging@lists.linux.dev, Zhan Xusheng <zhanxusheng@xiaomi.com>
Subject: Re: [PATCH 2/4] staging: greybus: audio: avoid macro with side effects
Date: Mon, 22 Dec 2025 09:46:04 +0100 [thread overview]
Message-ID: <2025122213-charger-stark-8289@gregkh> (raw)
In-Reply-To: <20251219063415.46818-3-zhanxusheng@xiaomi.com>
On Fri, Dec 19, 2025 at 02:34:13PM +0800, Zhan Xusheng wrote:
> The gbaudio_dapm_for_each_direction() macro modifies its argument and
> evaluates it multiple times, which can lead to subtle bugs if used with
> expressions that have side effects.
But the one user does no such thing, so it's fine.
I'd just leave this as-is for now, thanks.
greg k-h
next prev parent reply other threads:[~2025-12-22 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 6:34 [PATCH 0/4] greybus: staging fixes and cleanups Zhan Xusheng
2025-12-19 6:34 ` [PATCH 1/4] staging: greybus: spilib: fix function parameter indentation Zhan Xusheng
2025-12-22 8:45 ` Greg KH
2025-12-19 6:34 ` [PATCH 2/4] staging: greybus: audio: avoid macro with side effects Zhan Xusheng
2025-12-22 8:46 ` Greg KH [this message]
2025-12-19 6:34 ` [PATCH 3/4] staging: greybus: gb-camera: use BIT() macro and fix formatting Zhan Xusheng
2025-12-22 8:46 ` Greg KH
2025-12-19 6:34 ` [PATCH 4/4] staging: greybus: greybus_firmware: fix long macro lines Zhan Xusheng
2025-12-22 8:47 ` Greg KH
2025-12-22 15:40 ` [PATCH 1/4] staging: greybus: gb-camera: use BIT() macro and fix formatting Zhan Xusheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025122213-charger-stark-8289@gregkh \
--to=greg@kroah.com \
--cc=linux-staging@lists.linux.dev \
--cc=zhanxusheng1024@gmail.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox