* [PATCH] staging: atomisp: gc2235: prefer usleep_range over msleep
@ 2026-03-18 21:27 Abhai Kollara
2026-03-19 20:42 ` [PATCH v2] staging: media: " Abhai Kollara
2026-04-18 20:18 ` [PATCH v3] staging: media: atomisp: gc2235: prefer fsleep " Abhai Kollara
0 siblings, 2 replies; 5+ messages in thread
From: Abhai Kollara @ 2026-03-18 21:27 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab
Cc: Sakari Ailus, Greg Kroah-Hartman, linux-media, linux-staging,
linux-kernel, Abhai Kollara
Signed-off-by: Abhai Kollara <abhai@protonmail.com>
---
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
index d3414312e1de..db5e007efc56 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd)
goto fail_power;
}
- msleep(5);
+ usleep_range(5000, 6000);
return 0;
fail_clk:
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] staging: media: atomisp: gc2235: prefer usleep_range over msleep
2026-03-18 21:27 [PATCH] staging: atomisp: gc2235: prefer usleep_range over msleep Abhai Kollara
@ 2026-03-19 20:42 ` Abhai Kollara
2026-04-16 9:44 ` Sakari Ailus
2026-04-18 20:18 ` [PATCH v3] staging: media: atomisp: gc2235: prefer fsleep " Abhai Kollara
1 sibling, 1 reply; 5+ messages in thread
From: Abhai Kollara @ 2026-03-19 20:42 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab
Cc: Sakari Ailus, Greg Kroah-Hartman, linux-media, linux-staging,
linux-kernel, Abhai Kollara
The gc2235 driver uses msleep(5) during power-up. msleep() is often
imprecise for durations under 20ms. Replace it with usleep_range()
to provide better precision.
Signed-off-by: Abhai Kollara <abhai@protonmail.com>
---
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
index d3414312e1de..db5e007efc56 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd)
goto fail_power;
}
- msleep(5);
+ usleep_range(5000, 6000);
return 0;
fail_clk:
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: media: atomisp: gc2235: prefer usleep_range over msleep
2026-03-19 20:42 ` [PATCH v2] staging: media: " Abhai Kollara
@ 2026-04-16 9:44 ` Sakari Ailus
0 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2026-04-16 9:44 UTC (permalink / raw)
To: Abhai Kollara
Cc: Hans de Goede, Mauro Carvalho Chehab, Sakari Ailus,
Greg Kroah-Hartman, linux-media, linux-staging, linux-kernel
On Thu, Mar 19, 2026 at 08:42:47PM +0000, Abhai Kollara wrote:
> The gc2235 driver uses msleep(5) during power-up. msleep() is often
> imprecise for durations under 20ms. Replace it with usleep_range()
> to provide better precision.
>
> Signed-off-by: Abhai Kollara <abhai@protonmail.com>
> ---
> drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> index d3414312e1de..db5e007efc56 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> @@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd)
> goto fail_power;
> }
>
> - msleep(5);
> + usleep_range(5000, 6000);
I'd rather use fsleep() here.
> return 0;
>
> fail_clk:
--
Sakari Ailus
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3] staging: media: atomisp: gc2235: prefer fsleep over msleep
2026-03-18 21:27 [PATCH] staging: atomisp: gc2235: prefer usleep_range over msleep Abhai Kollara
2026-03-19 20:42 ` [PATCH v2] staging: media: " Abhai Kollara
@ 2026-04-18 20:18 ` Abhai Kollara
2026-04-18 22:08 ` Sakari Ailus
1 sibling, 1 reply; 5+ messages in thread
From: Abhai Kollara @ 2026-04-18 20:18 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab
Cc: Sakari Ailus, Greg Kroah-Hartman, linux-media, linux-staging,
linux-kernel, Abhai Kollara
The gc2235 driver uses msleep(5) during power-up. msleep() is often
imprecise for durations under 20ms. Replace it with fsleep()
to provide better precision.
Signed-off-by: Abhai Kollara <abhai@protonmail.com>
---
v3:
- Use fsleep() instead of usleep_range() per Sakari Ailus's feedback.
v2:
- Replaced msleep() with usleep_range() (Superseded).
v1:
- Initial version.
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
index d3414312e1de..7999c8595a68 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd)
goto fail_power;
}
- msleep(5);
+ fsleep(5000);
return 0;
fail_clk:
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] staging: media: atomisp: gc2235: prefer fsleep over msleep
2026-04-18 20:18 ` [PATCH v3] staging: media: atomisp: gc2235: prefer fsleep " Abhai Kollara
@ 2026-04-18 22:08 ` Sakari Ailus
0 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2026-04-18 22:08 UTC (permalink / raw)
To: Abhai Kollara
Cc: Hans de Goede, Mauro Carvalho Chehab, Greg Kroah-Hartman,
linux-media, linux-staging, linux-kernel
Hi Abhai,
On Sat, Apr 18, 2026 at 08:18:01PM +0000, Abhai Kollara wrote:
> The gc2235 driver uses msleep(5) during power-up. msleep() is often
> imprecise for durations under 20ms. Replace it with fsleep()
> to provide better precision.
>
> Signed-off-by: Abhai Kollara <abhai@protonmail.com>
> ---
> v3:
> - Use fsleep() instead of usleep_range() per Sakari Ailus's feedback.
The commit 968d8904c2f86996b0615a08ee4048bccac56758 apparently already does
this in my atomisp branch.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-18 22:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-18 21:27 [PATCH] staging: atomisp: gc2235: prefer usleep_range over msleep Abhai Kollara
2026-03-19 20:42 ` [PATCH v2] staging: media: " Abhai Kollara
2026-04-16 9:44 ` Sakari Ailus
2026-04-18 20:18 ` [PATCH v3] staging: media: atomisp: gc2235: prefer fsleep " Abhai Kollara
2026-04-18 22:08 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox