[PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

[PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

[Hari Haran]

[-- Attachment #1.1: Type: text/plain, Size: 1064 bytes --]

From e49981e80ea3535189a2ff2a5b6c0185ccac5acb Mon Sep 17 00:00:00 2001
From: Haribytecode <osdevhari@gmail.com>
Date: Fri, 17 Apr 2026 22:57:13 +0530
Subject: [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

Fix checkpatch alignment warning to match kernel coding style.

Signed-off-by: Haribytecode <osdevhari@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c
b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 7b18be8912e6..d77a2f3603ae 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -2483,8 +2483,8 @@ struct xmit_buf
*dequeue_pending_xmitbuf_under_survey(struct xmit_priv *pxmitpri
  type = GetFrameSubType(pxmitbuf->pbuf + TXDESC_OFFSET);

  if ((type == WIFI_PROBEREQ) ||
- (type == WIFI_DATA_NULL) ||
- (type == WIFI_QOS_DATA_NULL)) {
+    (type == WIFI_DATA_NULL) ||
+    (type == WIFI_QOS_DATA_NULL)) {
  list_del_init(&pxmitbuf->list);
  break;
  }
-- 
2.53.0

[-- Attachment #1.2: Type: text/html, Size: 1319 bytes --]

[-- Attachment #2: 0001-staging-rtl8723bs-fix-alignment-issue-in-rtw_xmit.c.patch --]
[-- Type: text/x-patch, Size: 1090 bytes --]

From e49981e80ea3535189a2ff2a5b6c0185ccac5acb Mon Sep 17 00:00:00 2001
From: Haribytecode <osdevhari@gmail.com>
Date: Fri, 17 Apr 2026 22:57:13 +0530
Subject: [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

Fix checkpatch alignment warning to match kernel coding style.

Signed-off-by: Haribytecode <osdevhari@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 7b18be8912e6..d77a2f3603ae 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -2483,8 +2483,8 @@ struct xmit_buf *dequeue_pending_xmitbuf_under_survey(struct xmit_priv *pxmitpri
 			type = GetFrameSubType(pxmitbuf->pbuf + TXDESC_OFFSET);
 
 			if ((type == WIFI_PROBEREQ) ||
-				(type == WIFI_DATA_NULL) ||
-				(type == WIFI_QOS_DATA_NULL)) {
+			    (type == WIFI_DATA_NULL) ||
+			    (type == WIFI_QOS_DATA_NULL)) {
 				list_del_init(&pxmitbuf->list);
 				break;
 			}
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

[Luka Gejak]

Hi Osdevhari,
Let's start from the top of the email. Firstly attachments are not 
allowed, only plaintext. Secondly Signed-off-by tag must use your real
name(Firstname Lastname <email>. Thirdly, you should setup git 
send-email and use it to send patches. One more thing why did you 
resend same email twice?
Best regards,
Luka Gejak

Re: [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

[Greg KH]

On Sat, Apr 18, 2026 at 08:57:08AM +0200, Luka Gejak wrote:
> Hi Osdevhari,
> Let's start from the top of the email. Firstly attachments are not 
> allowed, only plaintext. Secondly Signed-off-by tag must use your real
> name(Firstname Lastname <email>. Thirdly, you should setup git 
> send-email and use it to send patches. One more thing why did you 
> resend same email twice?
> Best regards,
> Luka Gejak

Luka, please do not review patches like this, it is not the correct way.
Please do so, by not using AI results, and doing so in the in-line
fashion, like the style of what we do.

And there is no requirement to use git send-email.

Your email here alone has no context at all, making it impossible to
properly quote or respond to.  Please don't do that.

thanks,

greg k-h

Re: [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

[Luka Gejak]

On April 18, 2026 9:11:40 AM GMT+02:00, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Sat, Apr 18, 2026 at 08:57:08AM +0200, Luka Gejak wrote:
>> Hi Osdevhari,
>> Let's start from the top of the email. Firstly attachments are not 
>> allowed, only plaintext. Secondly Signed-off-by tag must use your real
>> name(Firstname Lastname <email>. Thirdly, you should setup git 
>> send-email and use it to send patches. One more thing why did you 
>> resend same email twice?
>> Best regards,
>> Luka Gejak
>
>Luka, please do not review patches like this, it is not the correct way.
>Please do so, by not using AI results, and doing so in the in-line
>fashion, like the style of what we do.
>
>And there is no requirement to use git send-email.
>
>Your email here alone has no context at all, making it impossible to
>properly quote or respond to.  Please don't do that.
>
>thanks,
>
>greg k-h

Hi Greg,
First of all it is not an ai response, and I didn't see need for 
quotes because I didn't actually talk about code but if prefer quotes 
at all times just let me know. And I suggested git send-email because 
it is easier for sending patches without worrying about plaintext or 
attachments. Also do you know how to get quotas from mailing list to 
my phone without manually copy pasting and adding >, since I am not by
my laptop right now and I don't know about something like lei for 
mobile. Also to clarify I used such tone becouse he is a begginer if 
that is what made you think this is ai review.
Best regards,
Luka Gejak

Re: [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

[Greg KH]

On Sat, Apr 18, 2026 at 09:29:40AM +0200, Luka Gejak wrote:
> On April 18, 2026 9:11:40 AM GMT+02:00, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Sat, Apr 18, 2026 at 08:57:08AM +0200, Luka Gejak wrote:
> >> Hi Osdevhari,
> >> Let's start from the top of the email. Firstly attachments are not 
> >> allowed, only plaintext. Secondly Signed-off-by tag must use your real
> >> name(Firstname Lastname <email>. Thirdly, you should setup git 
> >> send-email and use it to send patches. One more thing why did you 
> >> resend same email twice?
> >> Best regards,
> >> Luka Gejak
> >
> >Luka, please do not review patches like this, it is not the correct way.
> >Please do so, by not using AI results, and doing so in the in-line
> >fashion, like the style of what we do.
> >
> >And there is no requirement to use git send-email.
> >
> >Your email here alone has no context at all, making it impossible to
> >properly quote or respond to.  Please don't do that.
> >
> >thanks,
> >
> >greg k-h
> 
> Hi Greg,
> First of all it is not an ai response, and I didn't see need for 
> quotes because I didn't actually talk about code but if prefer quotes 
> at all times just let me know. And I suggested git send-email because 
> it is easier for sending patches without worrying about plaintext or 
> attachments. Also do you know how to get quotas from mailing list to 
> my phone without manually copy pasting and adding >, since I am not by
> my laptop right now and I don't know about something like lei for 
> mobile. Also to clarify I used such tone becouse he is a begginer if 
> that is what made you think this is ai review.

Please do not us a phone email client that can not properly handle email
quoting for reviewing new developer's patch submissions.  There is no
rush here, nor need to confuse them with a style that is not the normal
way of development we use at all.

In short, if you are going to do reviews, do them properly, in the
correct style, otherwise it just causes confusion.

And yes, the "tone" sounds like AI, please don't do that.

thanks,

greg k-h

Re: [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

[Luka Gejak]

On April 18, 2026 9:37:32 AM GMT+02:00, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Sat, Apr 18, 2026 at 09:29:40AM +0200, Luka Gejak wrote:
>> On April 18, 2026 9:11:40 AM GMT+02:00, Greg KH <gregkh@linuxfoundation.org> wrote:
>> >On Sat, Apr 18, 2026 at 08:57:08AM +0200, Luka Gejak wrote:
>> >> Hi Osdevhari,
>> >> Let's start from the top of the email. Firstly attachments are not 
>> >> allowed, only plaintext. Secondly Signed-off-by tag must use your real
>> >> name(Firstname Lastname <email>. Thirdly, you should setup git 
>> >> send-email and use it to send patches. One more thing why did you 
>> >> resend same email twice?
>> >> Best regards,
>> >> Luka Gejak
>> >
>> >Luka, please do not review patches like this, it is not the correct way.
>> >Please do so, by not using AI results, and doing so in the in-line
>> >fashion, like the style of what we do.
>> >
>> >And there is no requirement to use git send-email.
>> >
>> >Your email here alone has no context at all, making it impossible to
>> >properly quote or respond to.  Please don't do that.
>> >
>> >thanks,
>> >
>> >greg k-h
>> 
>> Hi Greg,
>> First of all it is not an ai response, and I didn't see need for 
>> quotes because I didn't actually talk about code but if prefer quotes 
>> at all times just let me know. And I suggested git send-email because 
>> it is easier for sending patches without worrying about plaintext or 
>> attachments. Also do you know how to get quotas from mailing list to 
>> my phone without manually copy pasting and adding >, since I am not by
>> my laptop right now and I don't know about something like lei for 
>> mobile. Also to clarify I used such tone becouse he is a begginer if 
>> that is what made you think this is ai review.
>
>Please do not us a phone email client that can not properly handle email
>quoting for reviewing new developer's patch submissions.  There is no
>rush here, nor need to confuse them with a style that is not the normal
>way of development we use at all.
>
It can do proper quoting but it takes a lot of time to copy it. If I 
was cced I would have no problem using quotes on my phone either. I 
use an app called acode in which I write emails(because of formating 
and line length) and then send it.
>
>And yes, the "tone" sounds like AI, please don't do that.
>
I understand and I won't do that anymore. I thought since he was a 
begginer it would be better use such tone instead of being bold for 
example as he would probably take it in differently.
Best regards,
Luka Gejak
>thanks,
>
>greg k-h

Re: [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

[Greg KH]

On Sat, Apr 18, 2026 at 09:44:20AM +0200, Luka Gejak wrote:
> On April 18, 2026 9:37:32 AM GMT+02:00, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Sat, Apr 18, 2026 at 09:29:40AM +0200, Luka Gejak wrote:
> >> On April 18, 2026 9:11:40 AM GMT+02:00, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> >On Sat, Apr 18, 2026 at 08:57:08AM +0200, Luka Gejak wrote:
> >> >> Hi Osdevhari,
> >> >> Let's start from the top of the email. Firstly attachments are not 
> >> >> allowed, only plaintext. Secondly Signed-off-by tag must use your real
> >> >> name(Firstname Lastname <email>. Thirdly, you should setup git 
> >> >> send-email and use it to send patches. One more thing why did you 
> >> >> resend same email twice?
> >> >> Best regards,
> >> >> Luka Gejak
> >> >
> >> >Luka, please do not review patches like this, it is not the correct way.
> >> >Please do so, by not using AI results, and doing so in the in-line
> >> >fashion, like the style of what we do.
> >> >
> >> >And there is no requirement to use git send-email.
> >> >
> >> >Your email here alone has no context at all, making it impossible to
> >> >properly quote or respond to.  Please don't do that.
> >> >
> >> >thanks,
> >> >
> >> >greg k-h
> >> 
> >> Hi Greg,
> >> First of all it is not an ai response, and I didn't see need for 
> >> quotes because I didn't actually talk about code but if prefer quotes 
> >> at all times just let me know. And I suggested git send-email because 
> >> it is easier for sending patches without worrying about plaintext or 
> >> attachments. Also do you know how to get quotas from mailing list to 
> >> my phone without manually copy pasting and adding >, since I am not by
> >> my laptop right now and I don't know about something like lei for 
> >> mobile. Also to clarify I used such tone becouse he is a begginer if 
> >> that is what made you think this is ai review.
> >
> >Please do not us a phone email client that can not properly handle email
> >quoting for reviewing new developer's patch submissions.  There is no
> >rush here, nor need to confuse them with a style that is not the normal
> >way of development we use at all.
> >
> It can do proper quoting but it takes a lot of time to copy it. If I 
> was cced I would have no problem using quotes on my phone either. I 
> use an app called acode in which I write emails(because of formating 
> and line length) and then send it.

Again, don't do things that are not helpful for submitters, there is no
need to do this without the correct tools.  Please slow down, these
reviews do not have to be fast as there is no deadline here at all.

> >And yes, the "tone" sounds like AI, please don't do that.
> >
> I understand and I won't do that anymore. I thought since he was a 
> begginer it would be better use such tone instead of being bold for 
> example as he would probably take it in differently.

No one likes being pandered to as current AI tools do :)

thanks,

greg k-h