Re: [PATCH 11/11] staging: rtl8723bs: rename DisableInterrupt8723BSdio() to snake_case

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Apr 19, 2026 at 10:19:37AM +0300, Nikolay Kulikov wrote:
> Rename function DisableInterrupt8723BSdio() to
> rtw_sdio_disable_interrupt() and format its description to comply with
> Linux kernel coding style.
> Declare this function without 'extern' prototype in the .h file to fix
> checkpatch.pl warning.
> 
> Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/sdio_ops.c     | 17 +++++++----------
>  drivers/staging/rtl8723bs/include/sdio_ops.h |  2 +-
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c  |  2 +-
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c |  4 ++--
>  4 files changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index 0d8d0935e4a2..a7713acccce9 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -742,16 +742,13 @@ void rtw_sdio_enable_interrupt(struct adapter *adapter)
>  	rtw_write8(adapter, REG_C2HEVT_CLEAR, C2H_EVT_HOST_CLOSE);
>  }
>  
> -/*  */
> -/*	Description: */
> -/*		Disable SDIO Host IMR configuration to mask unnecessary interrupt service. */
> -/*  */
> -/*	Assumption: */
> -/*		Using SDIO Local register ONLY for configuration. */
> -/*  */
> -/*	Created by Roger, 2011.02.11. */
> -/*  */
> -void DisableInterrupt8723BSdio(struct adapter *adapter)
> +/*
> + * Disable SDIO Host IMR configuration to mask unnecessary interrupt service.
> + *
> + * Assumption:
> + *	Using SDIO Local register ONLY for configuration.
> + */
> +void rtw_sdio_disable_interrupt(struct adapter *adapter)
>  {
>  	__le32 himr;
>  
> diff --git a/drivers/staging/rtl8723bs/include/sdio_ops.h b/drivers/staging/rtl8723bs/include/sdio_ops.h
> index 7bb4b2047cc1..13f13076bc16 100644
> --- a/drivers/staging/rtl8723bs/include/sdio_ops.h
> +++ b/drivers/staging/rtl8723bs/include/sdio_ops.h
> @@ -28,7 +28,7 @@ extern u8 CheckIPSStatus(struct adapter *padapter);
>  extern void InitInterrupt8723BSdio(struct adapter *padapter);
>  extern void InitSysInterrupt8723BSdio(struct adapter *padapter);
>  void rtw_sdio_enable_interrupt(struct adapter *padapter);
> -extern void DisableInterrupt8723BSdio(struct adapter *padapter);
> +void rtw_sdio_disable_interrupt(struct adapter *padapter);
>  extern u8 HalQueryTxBufferStatus8723BSdio(struct adapter *padapter);
>  extern void HalQueryTxOQTBufferStatus8723BSdio(struct adapter *padapter);
>  #endif /*  !__SDIO_OPS_H__ */
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index f9995e02485e..b240b8285995 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -1140,7 +1140,7 @@ static int rtw_resume_process_normal(struct adapter *padapter)
>  		if (ret)
>  			goto exit;
>  	}
> -	DisableInterrupt8723BSdio(padapter);
> +	rtw_sdio_disable_interrupt(padapter);
>  	/* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) != _SUCCESS) */
>  	if ((padapter->intf_alloc_irq) && (padapter->intf_alloc_irq(adapter_to_dvobj(padapter)) != _SUCCESS)) {
>  		ret = -1;
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index f6fa51f952e0..d6e3a74f2edd 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -212,7 +212,7 @@ static void sd_intf_stop(struct adapter *padapter)
>  	if (!padapter)
>  		return;
>  
> -	DisableInterrupt8723BSdio(padapter);
> +	rtw_sdio_disable_interrupt(padapter);
>  }
>  
>  
> @@ -281,7 +281,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct
>  	/*  set mac addr */
>  	rtw_macaddr_cfg(&psdio->func->dev, padapter->eeprompriv.mac_addr);
>  
> -	DisableInterrupt8723BSdio(padapter);
> +	rtw_sdio_disable_interrupt(padapter);
>  
>  	status = _SUCCESS;
>  
> -- 
> 2.53.0
> 
> 

This one did not apply as well.  Can you rebase those 2 patches on my
staging-next branch when it shows up on kernel.org tomorrow, and resend
them?

thanks,

greg k-h