public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c
@ 2026-04-26  6:41 Lettice up
  2026-04-26  7:03 ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Lettice up @ 2026-04-26  6:41 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel

From: Lettice <minecraftwemmne@gmail.com>

Date: Sun, 26 Apr 2026 00:49:40 -0400

Subject: [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c


Fix a checkpatch.pl warning where a line exceeds 100 columns

by breaking the long memcpy() call into two lines.


Signed-off-by: Lettice <minecraftwemmne@gmail.com>

---

 drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)


diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c
b/drivers/staging/rtl8723bs/core/rtw_cmd.c

index c1185c25ed36..50662d44a4b6 100644

--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c

+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c

@@ -557,7 +557,8 @@ u8 rtw_sitesurvey_cmd(struct adapter  *padapter,
struct ndis_802_11_ssid *ssid,



                for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) {

                        if (ssid[i].ssid_length) {

-                               memcpy(&psurveyPara->ssid[i],
&ssid[i], sizeof(struct ndis_802_11_ssid));

+                               memcpy(&psurveyPara->ssid[i], &ssid[i],

+                                      sizeof(struct ndis_802_11_ssid));

                                psurveyPara->ssid_num++;

                        }

                }

--

2.53.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c
  2026-04-26  6:41 Lettice up
@ 2026-04-26  7:03 ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-04-26  7:03 UTC (permalink / raw)
  To: Lettice up; +Cc: linux-staging, linux-kernel

On Sun, Apr 26, 2026 at 02:41:38PM +0800, Lettice up wrote:
> From: Lettice <minecraftwemmne@gmail.com>
> 
> Date: Sun, 26 Apr 2026 00:49:40 -0400
> 
> Subject: [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c
> 
> 
> Fix a checkpatch.pl warning where a line exceeds 100 columns
> 
> by breaking the long memcpy() call into two lines.
> 
> 
> Signed-off-by: Lettice <minecraftwemmne@gmail.com>
> 
> ---
> 
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ++-
> 
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> 
> index c1185c25ed36..50662d44a4b6 100644
> 
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> 
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> 
> @@ -557,7 +557,8 @@ u8 rtw_sitesurvey_cmd(struct adapter  *padapter,
> struct ndis_802_11_ssid *ssid,
> 
> 
> 
>                 for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) {
> 
>                         if (ssid[i].ssid_length) {
> 
> -                               memcpy(&psurveyPara->ssid[i],
> &ssid[i], sizeof(struct ndis_802_11_ssid));
> 
> +                               memcpy(&psurveyPara->ssid[i], &ssid[i],
> 
> +                                      sizeof(struct ndis_802_11_ssid));
> 
>                                 psurveyPara->ssid_num++;
> 
>                         }
> 
>                 }
> 
> --
> 
> 2.53.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c
@ 2026-04-26 10:20 Lettice up
  2026-04-26 19:40 ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Lettice up @ 2026-04-26 10:20 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

嗨,Greg,

这个补丁修复了 rtw_cmd.c 文件中关于行长度的 checkpatch.pl 警告。我把它作为附件发送,以避免我的邮件客户端出现格式问题。

谢谢,Lettice Jimmy

[-- Attachment #2: 0001-staging-rtl8723bs-fix-line-length-in-rtw_cmd.c.patch --]
[-- Type: application/octet-stream, Size: 1148 bytes --]

From df6f28e1bc657342e483b15e5b72343929129bb0 Mon Sep 17 00:00:00 2001
From: Lettice Jimmy <minecraftwemmne@gmail.com>
Date: Sun, 26 Apr 2026 06:12:22 -0400
Subject: [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c

Fix a checkpatch.pl warning where a line exceeds 100 columns
by breaking the long memcpy() call into two lines.

Signed-off-by: Lettice Jimmy <minecraftwemmne@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index c1185c25ed36..50662d44a4b6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -557,7 +557,8 @@ u8 rtw_sitesurvey_cmd(struct adapter  *padapter, struct ndis_802_11_ssid *ssid,
 
 		for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) {
 			if (ssid[i].ssid_length) {
-				memcpy(&psurveyPara->ssid[i], &ssid[i], sizeof(struct ndis_802_11_ssid));
+				memcpy(&psurveyPara->ssid[i], &ssid[i],
+				       sizeof(struct ndis_802_11_ssid));
 				psurveyPara->ssid_num++;
 			}
 		}
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c
  2026-04-26 10:20 [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c Lettice up
@ 2026-04-26 19:40 ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-04-26 19:40 UTC (permalink / raw)
  To: Lettice up; +Cc: linux-staging, linux-kernel

On Sun, Apr 26, 2026 at 06:20:26PM +0800, Lettice up wrote:
> 嗨,Greg,
> 
> 这个补丁修复了 rtw_cmd.c 文件中关于行长度的 checkpatch.pl 警告。我把它作为附件发送,以避免我的邮件客户端出现格式问题。
> 
> 谢谢,Lettice Jimmy


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-27  3:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-26 10:20 [PATCH] staging: rtl8723bs: fix line length in rtw_cmd.c Lettice up
2026-04-26 19:40 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2026-04-26  6:41 Lettice up
2026-04-26  7:03 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox