* [PATCH] staging: media: ia_css_isp_states: fix typo in ia_css_isp_states.c
@ 2026-04-29 18:01 Maha Maryam Javaid
2026-04-29 18:29 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Maha Maryam Javaid @ 2026-04-29 18:01 UTC (permalink / raw)
To: andy, hansg, mchehab
Cc: sakari.ailus, gregkh, linux-media, linux-staging, linux-kernel,
Maha Maryam Javaid
Fix spelling mistake: commmit -> commit
Signed-off-by: Maha Maryam Javaid <mahamaryamjavaid@gmail.com>
---
drivers/staging/media/atomisp/pci/ia_css_isp_states.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_states.c b/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
index af1765040464..cb3c2af91c51 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
@@ -3,7 +3,7 @@
* Support for Intel Camera Imaging ISP subsystem.
* Copyright (c) 2015, Intel Corporation.
*/
-/* Generated code: do not edit or commmit. */
+/* Generated code: do not edit or commit. */
#include "ia_css_pipeline.h"
#include "ia_css_isp_states.h"
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: ia_css_isp_states: fix typo in ia_css_isp_states.c
2026-04-29 18:01 [PATCH] staging: media: ia_css_isp_states: fix typo in ia_css_isp_states.c Maha Maryam Javaid
@ 2026-04-29 18:29 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-04-29 18:29 UTC (permalink / raw)
To: Maha Maryam Javaid
Cc: andy, hansg, mchehab, sakari.ailus, gregkh, linux-media,
linux-staging, linux-kernel
On Wed, Apr 29, 2026 at 02:01:48PM -0400, Maha Maryam Javaid wrote:
> Fix spelling mistake: commmit -> commit
NAK.
This has a few problems:
- wrong Subject
- not doing that across the whole driver
- repeating the work that has been already done and reviewed
- the previous work seems in a stale state, needs the review being addressed
(but I haven't checked that for sure)
Instead of doing this, start from reviewing others' patches and learn from
other reviews before doing your contributions.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-29 18:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-29 18:01 [PATCH] staging: media: ia_css_isp_states: fix typo in ia_css_isp_states.c Maha Maryam Javaid
2026-04-29 18:29 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox