From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 09/10] staging: rtl8723bs: remove struct hal_version from include/HalVerDef.h
Date: Sun, 3 May 2026 00:55:48 +0300 [thread overview]
Message-ID: <20260502220056.59815-10-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260502220056.59815-1-nikolayof23@gmail.com>
Remove the empty 'struct hal_version' as all its fields were removed
earlier and it is no longer needed.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +------
drivers/staging/rtl8723bs/include/HalVerDef.h | 5 -----
drivers/staging/rtl8723bs/include/hal_data.h | 1 -
3 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 0c422deed545..1512b6b43722 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -825,10 +825,9 @@ void Hal_ReadEFuse(
hal_ReadEFuse_BT(padapter, _offset, _size_byte, pbuf);
}
-static struct hal_version ReadChipVersion8723B(struct adapter *padapter)
+static void ReadChipVersion8723B(struct adapter *padapter)
{
u32 value32;
- struct hal_version ChipVersion;
struct hal_com_data *pHalData;
/* YJ, TODO, move read chip type here */
@@ -847,10 +846,6 @@ static struct hal_version ReadChipVersion8723B(struct adapter *padapter)
pHalData->MultiFunc |= ((value32 & BT_FUNC_EN) ? RT_MULTI_FUNC_BT : 0);
pHalData->MultiFunc |= ((value32 & GPS_FUNC_EN) ? RT_MULTI_FUNC_GPS : 0);
pHalData->PolarityCtl = ((value32 & WL_HWPDN_SL) ? RT_POLARITY_HIGH_ACT : RT_POLARITY_LOW_ACT);
-
- pHalData->VersionID = ChipVersion;
-
- return ChipVersion;
}
void rtl8723b_read_chip_version(struct adapter *padapter)
diff --git a/drivers/staging/rtl8723bs/include/HalVerDef.h b/drivers/staging/rtl8723bs/include/HalVerDef.h
index ed6925872d56..9b607543133f 100644
--- a/drivers/staging/rtl8723bs/include/HalVerDef.h
+++ b/drivers/staging/rtl8723bs/include/HalVerDef.h
@@ -41,10 +41,5 @@ enum hal_vendor_e { /* tag_HAL_Manufacturer_Version_Definition */
CHIP_VENDOR_SMIC = 2,
};
-struct hal_version { /* tag_HAL_VERSION */
-};
-
-/* hal_version VersionID; */
-
#endif
diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
index 20b14e665d99..876b3666aa1c 100644
--- a/drivers/staging/rtl8723bs/include/hal_data.h
+++ b/drivers/staging/rtl8723bs/include/hal_data.h
@@ -162,7 +162,6 @@ struct dm_priv {
struct hal_com_data {
- struct hal_version VersionID;
enum rt_multi_func MultiFunc; /* For multi-function consideration. */
enum rt_polarity_ctl PolarityCtl; /* For Wifi PDn Polarity control. */
enum rt_regulator_mode RegulatorMode; /* switching regulator or LDO */
--
2.54.0
next prev parent reply other threads:[~2026-05-02 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 21:55 [PATCH 00/10] staging: rtl8723bs: remove struct hal_version Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 01/10] staging: rtl8723bs: rename ChipType of struct hal_version to snake_case Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 02/10] staging: rtl8723bs: replace type and rename the chip_type field Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 03/10] staging: rtl8723bs: remove unused macros from include/HalVerDef.h Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 04/10] staging: rtl8723bs: remove unused ICType from struct hal_version Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 05/10] staging: rtl8723bs: remove unused VendorType " Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 06/10] staging: rtl8723bs: remove unused CUTVersion " Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 07/10] staging: rtl8723bs: remove unused ROMVer " Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 08/10] staging: rtl8723bs: move normal_chip field to struct hal_com_data Nikolay Kulikov
2026-05-02 21:55 ` Nikolay Kulikov [this message]
2026-05-02 21:55 ` [PATCH 10/10] staging: rtl8723bs: remove include/HalVerDef.h file Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260502220056.59815-10-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox