From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 07/10] staging: rtl8723bs: remove unused ROMVer from struct hal_version
Date: Sun, 3 May 2026 00:55:46 +0300 [thread overview]
Message-ID: <20260502220056.59815-8-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260502220056.59815-1-nikolayof23@gmail.com>
'ROMVer' field of 'sturct hal_version' never used anywhere in the
driver, so remove it to eliminate unused code.
Remove the related call to rtw_read32(), the result of which is only
used for 'ROMVer' and is no longer needed.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 ---
drivers/staging/rtl8723bs/include/HalVerDef.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 29b120e192fb..0818034563b1 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -840,9 +840,6 @@ static struct hal_version ReadChipVersion8723B(struct adapter *padapter)
/* For regulator mode. by tynli. 2011.01.14 */
pHalData->RegulatorMode = ((value32 & SPS_SEL) ? RT_LDO_REGULATOR : RT_SWITCHING_REGULATOR);
- value32 = rtw_read32(padapter, REG_GPIO_OUTSTS);
- ChipVersion.ROMVer = ((value32 & RF_RL_ID) >> 20); /* ROM code version. */
-
/* For multi-function consideration. Added by Roger, 2010.10.06. */
pHalData->MultiFunc = RT_MULTI_FUNC_NONE;
value32 = rtw_read32(padapter, REG_MULTI_FUNC_CTRL);
diff --git a/drivers/staging/rtl8723bs/include/HalVerDef.h b/drivers/staging/rtl8723bs/include/HalVerDef.h
index 249acd83c89f..90ef37b1ddae 100644
--- a/drivers/staging/rtl8723bs/include/HalVerDef.h
+++ b/drivers/staging/rtl8723bs/include/HalVerDef.h
@@ -43,7 +43,6 @@ enum hal_vendor_e { /* tag_HAL_Manufacturer_Version_Definition */
struct hal_version { /* tag_HAL_VERSION */
bool chip_normal; /* true - normal chip, false - test chip */
- u8 ROMVer;
};
/* hal_version VersionID; */
--
2.54.0
next prev parent reply other threads:[~2026-05-02 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 21:55 [PATCH 00/10] staging: rtl8723bs: remove struct hal_version Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 01/10] staging: rtl8723bs: rename ChipType of struct hal_version to snake_case Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 02/10] staging: rtl8723bs: replace type and rename the chip_type field Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 03/10] staging: rtl8723bs: remove unused macros from include/HalVerDef.h Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 04/10] staging: rtl8723bs: remove unused ICType from struct hal_version Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 05/10] staging: rtl8723bs: remove unused VendorType " Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 06/10] staging: rtl8723bs: remove unused CUTVersion " Nikolay Kulikov
2026-05-02 21:55 ` Nikolay Kulikov [this message]
2026-05-02 21:55 ` [PATCH 08/10] staging: rtl8723bs: move normal_chip field to struct hal_com_data Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 09/10] staging: rtl8723bs: remove struct hal_version from include/HalVerDef.h Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 10/10] staging: rtl8723bs: remove include/HalVerDef.h file Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260502220056.59815-8-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox