From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 01/10] staging: rtl8723bs: rename ChipType of struct hal_version to snake_case
Date: Sun, 3 May 2026 00:55:40 +0300 [thread overview]
Message-ID: <20260502220056.59815-2-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260502220056.59815-1-nikolayof23@gmail.com>
Rename 'ChipType' field to 'chip_type' to comply with Linux kernel
coding style and fix checkpatch.pl warning.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
drivers/staging/rtl8723bs/include/HalVerDef.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 9a91fd0a96eb..4f25c621b1a0 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -836,7 +836,7 @@ static struct hal_version ReadChipVersion8723B(struct adapter *padapter)
value32 = rtw_read32(padapter, REG_SYS_CFG);
ChipVersion.ICType = CHIP_8723B;
- ChipVersion.ChipType = ((value32 & RTL_ID) ? TEST_CHIP : NORMAL_CHIP);
+ ChipVersion.chip_type = ((value32 & RTL_ID) ? TEST_CHIP : NORMAL_CHIP);
ChipVersion.VendorType = ((value32 & VENDOR_ID) ? CHIP_VENDOR_UMC : CHIP_VENDOR_TSMC);
ChipVersion.CUTVersion = (value32 & CHIP_VER_RTL_MASK)>>CHIP_VER_RTL_SHIFT; /* IC version (CUT) */
diff --git a/drivers/staging/rtl8723bs/include/HalVerDef.h b/drivers/staging/rtl8723bs/include/HalVerDef.h
index d0ce21ccc1cc..bf4716ec18e8 100644
--- a/drivers/staging/rtl8723bs/include/HalVerDef.h
+++ b/drivers/staging/rtl8723bs/include/HalVerDef.h
@@ -43,7 +43,7 @@ enum hal_vendor_e { /* tag_HAL_Manufacturer_Version_Definition */
struct hal_version { /* tag_HAL_VERSION */
enum hal_ic_type_e ICType;
- enum hal_chip_type_e ChipType;
+ enum hal_chip_type_e chip_type;
enum hal_cut_version_e CUTVersion;
enum hal_vendor_e VendorType;
u8 ROMVer;
@@ -53,7 +53,7 @@ struct hal_version { /* tag_HAL_VERSION */
/* Get element */
#define GET_CVID_IC_TYPE(version) ((enum hal_ic_type_e)((version).ICType))
-#define GET_CVID_CHIP_TYPE(version) ((enum hal_chip_type_e)((version).ChipType))
+#define GET_CVID_CHIP_TYPE(version) ((enum hal_chip_type_e)((version).chip_type))
#define GET_CVID_MANUFACTUER(version) ((enum hal_vendor_e)((version).VendorType))
#define GET_CVID_CUT_VERSION(version) ((enum hal_cut_version_e)((version).CUTVersion))
#define GET_CVID_ROM_VERSION(version) (((version).ROMVer) & ROM_VERSION_MASK)
--
2.54.0
next prev parent reply other threads:[~2026-05-02 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 21:55 [PATCH 00/10] staging: rtl8723bs: remove struct hal_version Nikolay Kulikov
2026-05-02 21:55 ` Nikolay Kulikov [this message]
2026-05-02 21:55 ` [PATCH 02/10] staging: rtl8723bs: replace type and rename the chip_type field Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 03/10] staging: rtl8723bs: remove unused macros from include/HalVerDef.h Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 04/10] staging: rtl8723bs: remove unused ICType from struct hal_version Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 05/10] staging: rtl8723bs: remove unused VendorType " Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 06/10] staging: rtl8723bs: remove unused CUTVersion " Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 07/10] staging: rtl8723bs: remove unused ROMVer " Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 08/10] staging: rtl8723bs: move normal_chip field to struct hal_com_data Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 09/10] staging: rtl8723bs: remove struct hal_version from include/HalVerDef.h Nikolay Kulikov
2026-05-02 21:55 ` [PATCH 10/10] staging: rtl8723bs: remove include/HalVerDef.h file Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260502220056.59815-2-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox