From: Pan Chuang <panchuang@vivo.com>
To: "Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux@analog.com (open list:ANALOG DEVICES INC IIO DRIVERS),
linux-iio@vger.kernel.org (open list:STAGING - INDUSTRIAL IO),
linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 4/7] staging: iio: adt7316: Remove redundant dev_err()
Date: Mon, 20 Jul 2026 21:43:10 +0800 [thread overview]
Message-ID: <20260720134324.239391-5-panchuang@vivo.com> (raw)
In-Reply-To: <20260720134324.239391-1-panchuang@vivo.com>
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages
on failure. Remove the now-redundant driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/staging/iio/addac/adt7316.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 59fb3bd26bc1..20f6052cc7fb 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -1814,11 +1814,8 @@ static int adt7316_setup_irq(struct iio_dev *indio_dev)
NULL, adt7316_event_handler,
irq_type | IRQF_ONESHOT,
indio_dev->name, indio_dev);
- if (ret) {
- dev_err(&indio_dev->dev, "failed to request irq %d\n",
- chip->bus.irq);
+ if (ret)
return ret;
- }
if (irq_type & IRQF_TRIGGER_HIGH)
chip->config1 |= ADT7316_INT_POLARITY;
--
2.34.1
next prev parent reply other threads:[~2026-07-20 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 13:43 [PATCH 0/7] staging: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-20 13:43 ` [PATCH 1/7] staging: axis-fifo: Remove redundant dev_err() Pan Chuang
2026-07-20 13:43 ` [PATCH 2/7] staging: fbtft: Remove redundant dev_err_probe() Pan Chuang
2026-07-20 18:18 ` Andy Shevchenko
2026-07-20 13:43 ` [PATCH 3/7] staging: greybus: arche-platform: Remove redundant dev_err() Pan Chuang
2026-07-20 13:43 ` Pan Chuang [this message]
2026-07-20 13:43 ` [PATCH 5/7] media: atomisp: " Pan Chuang
2026-07-20 19:11 ` Andy Shevchenko
2026-07-20 13:43 ` [PATCH 6/7] staging: most: dim2: " Pan Chuang
2026-07-20 13:43 ` [PATCH 7/7] staging: nvec: Remove redundant dev_err_probe() Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720134324.239391-5-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox