From: Pan Chuang <panchuang@vivo.com>
To: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
Christian Gromm <christian.gromm@microchip.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gabriel Rondon <grondon@gmail.com>,
Artem Lytkin <iprintercanon@gmail.com>,
Dan Carpenter <error27@gmail.com>,
Zeeshan Ahmad <zeeshanahmad022019@gmail.com>,
Batu Ada Tutkun <batuadatutkun@gmail.com>,
Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com>,
Ethan Tidmore <ethantidmore06@gmail.com>,
Pan Chuang <panchuang@vivo.com>,
linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 6/7] staging: most: dim2: Remove redundant dev_err()
Date: Mon, 20 Jul 2026 21:43:12 +0800 [thread overview]
Message-ID: <20260720134324.239391-7-panchuang@vivo.com> (raw)
In-Reply-To: <20260720134324.239391-1-panchuang@vivo.com>
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/staging/most/dim2/dim2.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index 0e2512d16632..d57e20d399c7 100644
--- a/drivers/staging/most/dim2/dim2.c
+++ b/drivers/staging/most/dim2/dim2.c
@@ -818,10 +818,8 @@ static int dim2_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(&pdev->dev, irq, dim2_ahb_isr,
dim2_task_irq, 0, "dim2_ahb0_int", dev);
- if (ret) {
- dev_err(&pdev->dev, "failed to request ahb0_int irq %d\n", irq);
+ if (ret)
goto err_shutdown_dim;
- }
irq = platform_get_irq(pdev, MLB_INT_IDX);
if (irq < 0) {
@@ -831,10 +829,8 @@ static int dim2_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq, dim2_mlb_isr, 0,
"dim2_mlb_int", dev);
- if (ret) {
- dev_err(&pdev->dev, "failed to request mlb_int irq %d\n", irq);
+ if (ret)
goto err_shutdown_dim;
- }
init_waitqueue_head(&dev->netinfo_waitq);
dev->deliver_netinfo = 0;
--
2.34.1
next prev parent reply other threads:[~2026-07-20 13:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 13:43 [PATCH 0/7] staging: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-20 13:43 ` [PATCH 1/7] staging: axis-fifo: Remove redundant dev_err() Pan Chuang
2026-07-20 13:43 ` [PATCH 2/7] staging: fbtft: Remove redundant dev_err_probe() Pan Chuang
2026-07-20 18:18 ` Andy Shevchenko
2026-07-20 13:43 ` [PATCH 3/7] staging: greybus: arche-platform: Remove redundant dev_err() Pan Chuang
2026-07-20 13:43 ` [PATCH 4/7] staging: iio: adt7316: " Pan Chuang
2026-07-24 0:14 ` Jonathan Cameron
2026-07-20 13:43 ` [PATCH 5/7] media: atomisp: " Pan Chuang
2026-07-20 19:11 ` Andy Shevchenko
2026-07-20 13:43 ` Pan Chuang [this message]
2026-07-20 13:43 ` [PATCH 7/7] staging: nvec: Remove redundant dev_err_probe() Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720134324.239391-7-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=batuadatutkun@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=error27@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=grondon@gmail.com \
--cc=iprintercanon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
--cc=rajveer.chaudhari.linux@gmail.com \
--cc=zeeshanahmad022019@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox