From: Pan Chuang <panchuang@vivo.com>
To: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chelsy Ratnawat <chelsyratnawat2001@gmail.com>,
Pan Chuang <panchuang@vivo.com>,
linux-media@vger.kernel.org (open list:STAGING - ATOMISP DRIVER),
linux-kernel@vger.kernel.org (open list:INTEL MID (Mobile
Internet Device) PLATFORM),
linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM)
Subject: [PATCH 5/7] media: atomisp: Remove redundant dev_err()
Date: Mon, 20 Jul 2026 21:43:11 +0800 [thread overview]
Message-ID: <20260720134324.239391-6-panchuang@vivo.com> (raw)
In-Reply-To: <20260720134324.239391-1-panchuang@vivo.com>
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages
on failure. Remove the now-redundant driver-specific dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index 812230397409..2bed5e4c7ace 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -1416,10 +1416,8 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
err = devm_request_threaded_irq(&pdev->dev, pdev->irq,
atomisp_isr, atomisp_isr_thread,
IRQF_SHARED, "isp_irq", isp);
- if (err) {
- dev_err(&pdev->dev, "Failed to request irq (%d)\n", err);
+ if (err)
goto error_unregister_entities;
- }
/* Load firmware into ISP memory */
err = atomisp_css_load_firmware(isp);
--
2.34.1
next prev parent reply other threads:[~2026-07-20 13:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 13:43 [PATCH 0/7] staging: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-20 13:43 ` [PATCH 1/7] staging: axis-fifo: Remove redundant dev_err() Pan Chuang
2026-07-20 13:43 ` [PATCH 2/7] staging: fbtft: Remove redundant dev_err_probe() Pan Chuang
2026-07-20 18:18 ` Andy Shevchenko
2026-07-20 13:43 ` [PATCH 3/7] staging: greybus: arche-platform: Remove redundant dev_err() Pan Chuang
2026-07-20 13:43 ` [PATCH 4/7] staging: iio: adt7316: " Pan Chuang
2026-07-24 0:14 ` Jonathan Cameron
2026-07-20 13:43 ` Pan Chuang [this message]
2026-07-20 19:11 ` [PATCH 5/7] media: atomisp: " Andy Shevchenko
2026-07-20 13:43 ` [PATCH 6/7] staging: most: dim2: " Pan Chuang
2026-07-20 13:43 ` [PATCH 7/7] staging: nvec: Remove redundant dev_err_probe() Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720134324.239391-6-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=andy@kernel.org \
--cc=chelsyratnawat2001@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox