* [PATCH] staging: greybus: loopback: remove unused includes
@ 2026-08-12 18:03 Batu Ada Tutkun
2026-08-12 23:50 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Batu Ada Tutkun @ 2026-08-12 18:03 UTC (permalink / raw)
To: Bryan O'Donoghue
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev,
linux-staging, linux-kernel, Batu Ada Tutkun
linux/random.h, linux/sizes.h, linux/cdev.h, linux/fs.h, and
linux/workqueue.h are not used anywhere in this file; none of their
symbols appear in the source, and none are needed transitively either
(debugfs helpers come from linux/debugfs.h, the async worker uses
kthread_run()/kthread_stop() rather than the workqueue API).
Verified by removing the five includes and rebuilding
drivers/staging/greybus out-of-tree with W=1: no new warnings or
errors, and checkpatch.pl reports the same warning/check count before
and after.
Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Batu Ada Tutkun <batuadatutkun@gmail.com>
---
drivers/staging/greybus/loopback.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index ea57b1f5d156..1169cfcd28c6 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -14,15 +14,10 @@
#include <linux/slab.h>
#include <linux/kthread.h>
#include <linux/delay.h>
-#include <linux/random.h>
-#include <linux/sizes.h>
-#include <linux/cdev.h>
-#include <linux/fs.h>
#include <linux/kfifo.h>
#include <linux/debugfs.h>
#include <linux/list_sort.h>
#include <linux/spinlock.h>
-#include <linux/workqueue.h>
#include <linux/atomic.h>
#include <linux/pm_runtime.h>
#include <linux/greybus.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: greybus: loopback: remove unused includes
2026-08-12 18:03 [PATCH] staging: greybus: loopback: remove unused includes Batu Ada Tutkun
@ 2026-08-12 23:50 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-08-12 23:50 UTC (permalink / raw)
To: Batu Ada Tutkun
Cc: Bryan O'Donoghue, Johan Hovold, Alex Elder, greybus-dev,
linux-staging, linux-kernel
On Wed, Aug 12, 2026 at 09:03:54PM +0300, Batu Ada Tutkun wrote:
> linux/random.h, linux/sizes.h, linux/cdev.h, linux/fs.h, and
> linux/workqueue.h are not used anywhere in this file; none of their
> symbols appear in the source, and none are needed transitively either
> (debugfs helpers come from linux/debugfs.h, the async worker uses
> kthread_run()/kthread_stop() rather than the workqueue API).
>
> Verified by removing the five includes and rebuilding
> drivers/staging/greybus out-of-tree with W=1: no new warnings or
> errors, and checkpatch.pl reports the same warning/check count before
> and after.
>
> Assisted-by: Claude:claude-sonnet-4-6
> Signed-off-by: Batu Ada Tutkun <batuadatutkun@gmail.com>
> ---
> drivers/staging/greybus/loopback.c | 5 -----
> 1 file changed, 5 deletions(-)
Please read:
https://lore.kernel.org/all/2026080354-skater-urgent-31b2@gregkh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-12 23:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-12 18:03 [PATCH] staging: greybus: loopback: remove unused includes Batu Ada Tutkun
2026-08-12 23:50 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox