* [PATCH] staging: sm750fb: Remove redundant zero assignments
@ 2026-10-18 14:15 Temitope obabi
2026-10-18 14:23 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Temitope obabi @ 2026-10-18 14:15 UTC (permalink / raw)
To: outreachy
Cc: Temitope obabi, Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman,
linux-fbdev, linux-staging, linux-kernel
The sm750_dev structure is allocated with devm_kzalloc() before
sm750fb_setup() is called, so the init_parm fields are already zero.
Remove the four assignments that set them to zero again.
Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 8b93bfeb217b..21744a5a63fb 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -833,10 +833,6 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
swap = 0;
- sm750_dev->init_parm.chip_clock = 0;
- sm750_dev->init_parm.mem_clock = 0;
- sm750_dev->init_parm.master_clock = 0;
- sm750_dev->init_parm.power_mode = 0;
sm750_dev->init_parm.reset_memory = 1;
/* defaultly turn g_hwcursor on for both view */
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: Remove redundant zero assignments
2026-10-18 14:15 [PATCH] staging: sm750fb: Remove redundant zero assignments Temitope obabi
@ 2026-10-18 14:23 ` Greg Kroah-Hartman
2026-10-19 0:03 ` Temitope obabi
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2026-10-18 14:23 UTC (permalink / raw)
To: Temitope obabi
Cc: outreachy, Sudip Mukherjee, Teddy Wang, linux-fbdev,
linux-staging, linux-kernel
On Sun, Oct 18, 2026 at 05:15:18PM +0300, Temitope obabi wrote:
> The sm750_dev structure is allocated with devm_kzalloc() before
> sm750fb_setup() is called, so the init_parm fields are already zero.
> Remove the four assignments that set them to zero again.
>
> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 8b93bfeb217b..21744a5a63fb 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -833,10 +833,6 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
>
> swap = 0;
>
> - sm750_dev->init_parm.chip_clock = 0;
> - sm750_dev->init_parm.mem_clock = 0;
> - sm750_dev->init_parm.master_clock = 0;
> - sm750_dev->init_parm.power_mode = 0;
This is good to keep as it is explict what is happening, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: Remove redundant zero assignments
2026-10-18 14:23 ` Greg Kroah-Hartman
@ 2026-10-19 0:03 ` Temitope obabi
0 siblings, 0 replies; 3+ messages in thread
From: Temitope obabi @ 2026-10-19 0:03 UTC (permalink / raw)
To: gregkh
Cc: outreachy, Sudip Mukherjee, Teddy Wang, linux-fbdev,
linux-staging, linux-kernel
Hi Greg,
Thank you for the feedback. I understand that keeping the explicit
assignments is preferred, so I will drop this patch.
Thanks,
Temitope
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-19 0:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-18 14:15 [PATCH] staging: sm750fb: Remove redundant zero assignments Temitope obabi
2026-10-18 14:23 ` Greg Kroah-Hartman
2026-10-19 0:03 ` Temitope obabi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox