[GIT PULL] media: atomisp: Changes for 6.8-1

[GIT PULL] media: atomisp: Changes for 6.8-1

[Hans de Goede]

Hi Mauro,

Here are the atomisp changes for 6.8.

My patches in this set been posted on the list, but only a couple of
minutes ago, leaving pretty much zero time for review. Sorry about that,
with the holidays the timing did not work out very well.

If you don't want to take this pull-request because of this it
would be good if you can at least take the patches up to
the "media: atomisp: Fix spelling mistake in ia_css_acc_types.h"
change. There are only 2 unreviewed patches from me in that
set, which fix the atomisp driver not working at all with
the latest media_stage/master code. And the rest of the patches
in that set are from others and have been reviewed by me.

If review finds any significant issues I'll do a set of follow up
patches to fix those.

Highlights:
- The first commit in this pull-request fixes the driver no longer
  working due to v4l2_subdev_state handling in media_stage/master

- Merged a bunch of spelling and other small fixes from various
  contributors

- Gracefully handle missing firmware:
  - Fix the driver crashing the system when the firmware is missing
  - Make the driver bind in power-managent-only mode when the firmware
    is missing so that the ISP is still properly turned off. This
    requires custom handling, not just standard PCI power-management.
    This allows the system to properly enter S0i3 with missing ISP
    firmware, allowing the atomisp driver to be used as a replacement
    for the pm-only drivers/platform/x86/atomisp/pm.c driver.

Regards,

Hans


The following changes since commit 02d4e62ae2452c83e4a3e279b8e4cb4dcbad4b31:

  media: i2c: mt9m114: use fsleep() in place of udelay() (2023-12-14 12:40:13 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git tags/media-atomisp-6.8-1

for you to fetch changes up to 1e529948fa3ae6249f1f15dbd77730ea54d0e649:

  media: atomisp: Update TODO (2023-12-31 11:07:38 +0100)

----------------------------------------------------------------
atomisp staging driver changes for 6.8

Highlights:
- The first commit in this pull-request fixes the driver no longer
  working due to v4l2_subdev_state handling in media_stage/master
- Merged a bunch of spelling and other small fixes from various
  contributors
- Gracefully handle missing firmware:
  - Fix the driver crashing the system when the firmware is missing
  - Make the driver bind in power-managent-only mode when the firmware
    is missing so that the ISP is still properly turned off. This
    requires custom handling, not just standard PCI power-management.
    This allows the system to properly enter S0i3 with missing ISP
    firmware, allowing the atomisp driver to be used as a replacement
    for the pm-only drivers/platform/x86/atomisp/pm.c driver.

----------------------------------------------------------------
Colin Ian King (1):
      media: atomisp: Remove redundant assignments to variables

Dipendra Khadka (13):
      media: atomisp: Fix spelling mistakes in ia_css_irq.h
      media: atomisp: Fix a spelling mistake in sh_css_defs.h
      media: atomisp: Fix repeated "of" in isp2400_input_system_public.h
      media: atomisp: Fix spelling mistake in isp2400_input_system_global.h
      media: atomisp: Fix spelling mistakes in circbuf.c
      media: atomisp: Fix spelling mistake in ia_css_circbuf.h
      media: atomisp: Fix spelling mistakes in sh_css_mipi.c
      media: atomisp: Fix spelling mistakes in queue.c
      media: atomisp: Fix spelling mistakes in rmgr_vbuf.c
      media: atomisp: Fix spelling mistakes in ia_css_macc_table.host.c
      media: atomisp: Fix spelling mistakes in ia_css_hdr_types.h
      media: atomisp: Fix spelling mistake in binary.c
      media: atomisp: Fix spelling mistake in ia_css_acc_types.h

Hans de Goede (15):
      media: atomisp: Adjust for v4l2_subdev_state handling changes in 6.8
      media: atomisp: Refactor sensor crop + fmt setting
      media: atomisp: Remove s_routing subdev call
      media: atomisp: Remove remaining deferred firmware loading code
      media: atomisp: Drop is_valid_device() function
      media: atomisp: Call pcim_enable_device() and pcim_iomap_regions() later
      media: atomisp: Fix probe error-exit path
      media: atomisp: Fix atomisp_pci_remove()
      media: atomisp: Group cpu_latency_qos_add_request() call together with other PM calls
      media: atomisp: Fix probe()/remove() power-management
      media: atomisp: Replace atomisp_drvfs attr with using driver.dev_groups attr
      media: atomisp: Move power-management [un]init into atomisp_pm_[un]init()
      media: atomisp: Bind and do power-management without firmware
      media: atomisp: Remove unnecessary msleep(10) from atomisp_mrfld_power() error path
      media: atomisp: Update TODO

Jonathan Bergh (1):
      media: atomisp: Removed duplicate comment and fixed comment format

 drivers/staging/media/atomisp/TODO                 |  10 -
 drivers/staging/media/atomisp/i2c/gc2235.h         |   5 +-
 drivers/staging/media/atomisp/pci/atomisp_cmd.c    | 133 ++++-----
 .../media/atomisp/pci/atomisp_compat_css20.c       |   2 +-
 drivers/staging/media/atomisp/pci/atomisp_drvfs.c  | 148 ++++------
 drivers/staging/media/atomisp/pci/atomisp_drvfs.h  |   5 +-
 .../staging/media/atomisp/pci/atomisp_internal.h   |   5 +-
 drivers/staging/media/atomisp/pci/atomisp_ioctl.c  |  60 ++--
 drivers/staging/media/atomisp/pci/atomisp_v4l2.c   | 319 +++++++++------------
 .../pci/base/circbuf/interface/ia_css_circbuf.h    |   2 +-
 .../media/atomisp/pci/base/circbuf/src/circbuf.c   |   6 +-
 .../staging/media/atomisp/pci/ia_css_acc_types.h   |   4 +-
 drivers/staging/media/atomisp/pci/ia_css_control.h |  29 +-
 .../staging/media/atomisp/pci/ia_css_firmware.h    |   6 +-
 drivers/staging/media/atomisp/pci/ia_css_irq.h     |   6 +-
 .../atomisp/pci/isp/kernels/hdr/ia_css_hdr_types.h |   4 +-
 .../kernels/macc/macc_1.0/ia_css_macc_table.host.c |   4 +-
 .../atomisp/pci/isp2400_input_system_global.h      |   2 +-
 .../atomisp/pci/isp2400_input_system_public.h      |   2 +-
 .../media/atomisp/pci/runtime/binary/src/binary.c  |   2 +-
 .../atomisp/pci/runtime/pipeline/src/pipeline.c    |   2 +-
 .../media/atomisp/pci/runtime/queue/src/queue.c    |  22 +-
 .../media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c |   6 +-
 drivers/staging/media/atomisp/pci/sh_css.c         |  33 +--
 drivers/staging/media/atomisp/pci/sh_css_defs.h    |   2 +-
 drivers/staging/media/atomisp/pci/sh_css_mipi.c    |   4 +-
 26 files changed, 344 insertions(+), 479 deletions(-)

Re: [GIT PULL] media: atomisp: Changes for 6.8-1

[Mauro Carvalho Chehab]

Em Sun, 31 Dec 2023 11:39:18 +0100
Hans de Goede <hdegoede@redhat.com> escreveu:

> Hi Mauro,
> 
> Here are the atomisp changes for 6.8.
> 
> My patches in this set been posted on the list, but only a couple of
> minutes ago, leaving pretty much zero time for review. Sorry about that,
> with the holidays the timing did not work out very well.
> 
> If you don't want to take this pull-request because of this it
> would be good if you can at least take the patches up to
> the "media: atomisp: Fix spelling mistake in ia_css_acc_types.h"
> change. There are only 2 unreviewed patches from me in that
> set, which fix the atomisp driver not working at all with
> the latest media_stage/master code. And the rest of the patches
> in that set are from others and have been reviewed by me.

We typically close the media merge window at -rc6. As I was also
in vacations during those weeks, this PR was merged today for 6.9.

Indeed the first two patches seem to be needed to fix an issue on 6.8. 
Could you please send them to stable after their arrival at linux-next?

Regards,
Mauro

> 
> If review finds any significant issues I'll do a set of follow up
> patches to fix those.
> 
> Highlights:
> - The first commit in this pull-request fixes the driver no longer
>   working due to v4l2_subdev_state handling in media_stage/master
> 
> - Merged a bunch of spelling and other small fixes from various
>   contributors
> 
> - Gracefully handle missing firmware:
>   - Fix the driver crashing the system when the firmware is missing
>   - Make the driver bind in power-managent-only mode when the firmware
>     is missing so that the ISP is still properly turned off. This
>     requires custom handling, not just standard PCI power-management.
>     This allows the system to properly enter S0i3 with missing ISP
>     firmware, allowing the atomisp driver to be used as a replacement
>     for the pm-only drivers/platform/x86/atomisp/pm.c driver.
> 
> Regards,
> 
> Hans
> 
> 
> The following changes since commit 02d4e62ae2452c83e4a3e279b8e4cb4dcbad4b31:
> 
>   media: i2c: mt9m114: use fsleep() in place of udelay() (2023-12-14 12:40:13 +0100)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git tags/media-atomisp-6.8-1
> 
> for you to fetch changes up to 1e529948fa3ae6249f1f15dbd77730ea54d0e649:
> 
>   media: atomisp: Update TODO (2023-12-31 11:07:38 +0100)
> 
> ----------------------------------------------------------------
> atomisp staging driver changes for 6.8
> 
> Highlights:
> - The first commit in this pull-request fixes the driver no longer
>   working due to v4l2_subdev_state handling in media_stage/master
> - Merged a bunch of spelling and other small fixes from various
>   contributors
> - Gracefully handle missing firmware:
>   - Fix the driver crashing the system when the firmware is missing
>   - Make the driver bind in power-managent-only mode when the firmware
>     is missing so that the ISP is still properly turned off. This
>     requires custom handling, not just standard PCI power-management.
>     This allows the system to properly enter S0i3 with missing ISP
>     firmware, allowing the atomisp driver to be used as a replacement
>     for the pm-only drivers/platform/x86/atomisp/pm.c driver.
> 
> ----------------------------------------------------------------
> Colin Ian King (1):
>       media: atomisp: Remove redundant assignments to variables
> 
> Dipendra Khadka (13):
>       media: atomisp: Fix spelling mistakes in ia_css_irq.h
>       media: atomisp: Fix a spelling mistake in sh_css_defs.h
>       media: atomisp: Fix repeated "of" in isp2400_input_system_public.h
>       media: atomisp: Fix spelling mistake in isp2400_input_system_global.h
>       media: atomisp: Fix spelling mistakes in circbuf.c
>       media: atomisp: Fix spelling mistake in ia_css_circbuf.h
>       media: atomisp: Fix spelling mistakes in sh_css_mipi.c
>       media: atomisp: Fix spelling mistakes in queue.c
>       media: atomisp: Fix spelling mistakes in rmgr_vbuf.c
>       media: atomisp: Fix spelling mistakes in ia_css_macc_table.host.c
>       media: atomisp: Fix spelling mistakes in ia_css_hdr_types.h
>       media: atomisp: Fix spelling mistake in binary.c
>       media: atomisp: Fix spelling mistake in ia_css_acc_types.h
> 
> Hans de Goede (15):
>       media: atomisp: Adjust for v4l2_subdev_state handling changes in 6.8
>       media: atomisp: Refactor sensor crop + fmt setting
>       media: atomisp: Remove s_routing subdev call
>       media: atomisp: Remove remaining deferred firmware loading code
>       media: atomisp: Drop is_valid_device() function
>       media: atomisp: Call pcim_enable_device() and pcim_iomap_regions() later
>       media: atomisp: Fix probe error-exit path
>       media: atomisp: Fix atomisp_pci_remove()
>       media: atomisp: Group cpu_latency_qos_add_request() call together with other PM calls
>       media: atomisp: Fix probe()/remove() power-management
>       media: atomisp: Replace atomisp_drvfs attr with using driver.dev_groups attr
>       media: atomisp: Move power-management [un]init into atomisp_pm_[un]init()
>       media: atomisp: Bind and do power-management without firmware
>       media: atomisp: Remove unnecessary msleep(10) from atomisp_mrfld_power() error path
>       media: atomisp: Update TODO
> 
> Jonathan Bergh (1):
>       media: atomisp: Removed duplicate comment and fixed comment format
> 
>  drivers/staging/media/atomisp/TODO                 |  10 -
>  drivers/staging/media/atomisp/i2c/gc2235.h         |   5 +-
>  drivers/staging/media/atomisp/pci/atomisp_cmd.c    | 133 ++++-----
>  .../media/atomisp/pci/atomisp_compat_css20.c       |   2 +-
>  drivers/staging/media/atomisp/pci/atomisp_drvfs.c  | 148 ++++------
>  drivers/staging/media/atomisp/pci/atomisp_drvfs.h  |   5 +-
>  .../staging/media/atomisp/pci/atomisp_internal.h   |   5 +-
>  drivers/staging/media/atomisp/pci/atomisp_ioctl.c  |  60 ++--
>  drivers/staging/media/atomisp/pci/atomisp_v4l2.c   | 319 +++++++++------------
>  .../pci/base/circbuf/interface/ia_css_circbuf.h    |   2 +-
>  .../media/atomisp/pci/base/circbuf/src/circbuf.c   |   6 +-
>  .../staging/media/atomisp/pci/ia_css_acc_types.h   |   4 +-
>  drivers/staging/media/atomisp/pci/ia_css_control.h |  29 +-
>  .../staging/media/atomisp/pci/ia_css_firmware.h    |   6 +-
>  drivers/staging/media/atomisp/pci/ia_css_irq.h     |   6 +-
>  .../atomisp/pci/isp/kernels/hdr/ia_css_hdr_types.h |   4 +-
>  .../kernels/macc/macc_1.0/ia_css_macc_table.host.c |   4 +-
>  .../atomisp/pci/isp2400_input_system_global.h      |   2 +-
>  .../atomisp/pci/isp2400_input_system_public.h      |   2 +-
>  .../media/atomisp/pci/runtime/binary/src/binary.c  |   2 +-
>  .../atomisp/pci/runtime/pipeline/src/pipeline.c    |   2 +-
>  .../media/atomisp/pci/runtime/queue/src/queue.c    |  22 +-
>  .../media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c |   6 +-
>  drivers/staging/media/atomisp/pci/sh_css.c         |  33 +--
>  drivers/staging/media/atomisp/pci/sh_css_defs.h    |   2 +-
>  drivers/staging/media/atomisp/pci/sh_css_mipi.c    |   4 +-
>  26 files changed, 344 insertions(+), 479 deletions(-)
> 
> 
> 



Thanks,
Mauro

Re: [GIT PULL] media: atomisp: Changes for 6.8-1

[Hans de Goede]

Hi,

On 2/1/24 07:10, Mauro Carvalho Chehab wrote:
> Em Sun, 31 Dec 2023 11:39:18 +0100
> Hans de Goede <hdegoede@redhat.com> escreveu:
> 
>> Hi Mauro,
>>
>> Here are the atomisp changes for 6.8.
>>
>> My patches in this set been posted on the list, but only a couple of
>> minutes ago, leaving pretty much zero time for review. Sorry about that,
>> with the holidays the timing did not work out very well.
>>
>> If you don't want to take this pull-request because of this it
>> would be good if you can at least take the patches up to
>> the "media: atomisp: Fix spelling mistake in ia_css_acc_types.h"
>> change. There are only 2 unreviewed patches from me in that
>> set, which fix the atomisp driver not working at all with
>> the latest media_stage/master code. And the rest of the patches
>> in that set are from others and have been reviewed by me.
> 
> We typically close the media merge window at -rc6. As I was also
> in vacations during those weeks, this PR was merged today for 6.9.

No problem, I know I was late with submitting this PR.

> Indeed the first two patches seem to be needed to fix an issue on 6.8. 
> Could you please send them to stable after their arrival at linux-next?

I'm not sure what you mean with send them to stable ?

6.8 is not released yet, so these need to be send to Linus this
cycle. What is the process for media bugfixes for the current
kernel cycle ?

Regards,

Hans

Re: [GIT PULL] media: atomisp: Changes for 6.8-1

[Mauro Carvalho Chehab]

Em Thu, 1 Feb 2024 12:46:19 +0100
Hans de Goede <hdegoede@redhat.com> escreveu:

> Hi,
> 
> On 2/1/24 07:10, Mauro Carvalho Chehab wrote:
> > Em Sun, 31 Dec 2023 11:39:18 +0100
> > Hans de Goede <hdegoede@redhat.com> escreveu:
> >   
> >> Hi Mauro,
> >>
> >> Here are the atomisp changes for 6.8.
> >>
> >> My patches in this set been posted on the list, but only a couple of
> >> minutes ago, leaving pretty much zero time for review. Sorry about that,
> >> with the holidays the timing did not work out very well.
> >>
> >> If you don't want to take this pull-request because of this it
> >> would be good if you can at least take the patches up to
> >> the "media: atomisp: Fix spelling mistake in ia_css_acc_types.h"
> >> change. There are only 2 unreviewed patches from me in that
> >> set, which fix the atomisp driver not working at all with
> >> the latest media_stage/master code. And the rest of the patches
> >> in that set are from others and have been reviewed by me.  
> > 
> > We typically close the media merge window at -rc6. As I was also
> > in vacations during those weeks, this PR was merged today for 6.9.  
> 
> No problem, I know I was late with submitting this PR.
> 
> > Indeed the first two patches seem to be needed to fix an issue on 6.8. 
> > Could you please send them to stable after their arrival at linux-next?  
> 
> I'm not sure what you mean with send them to stable ?
> 
> 6.8 is not released yet, so these need to be send to Linus this
> cycle. What is the process for media bugfixes for the current
> kernel cycle ?

Heh, sorry, somehow I was thinking on 6.7 :-)

If the bug only happens on 6.8, I can just cherry-pick the two patches
on my fixes branch.

Thanks,
Mauro

Re: [GIT PULL] media: atomisp: Changes for 6.8-1

[Hans de Goede]

Hi,

On 2/1/24 13:18, Mauro Carvalho Chehab wrote:
> Em Thu, 1 Feb 2024 12:46:19 +0100
> Hans de Goede <hdegoede@redhat.com> escreveu:
> 
>> Hi,
>>
>> On 2/1/24 07:10, Mauro Carvalho Chehab wrote:
>>> Em Sun, 31 Dec 2023 11:39:18 +0100
>>> Hans de Goede <hdegoede@redhat.com> escreveu:
>>>   
>>>> Hi Mauro,
>>>>
>>>> Here are the atomisp changes for 6.8.
>>>>
>>>> My patches in this set been posted on the list, but only a couple of
>>>> minutes ago, leaving pretty much zero time for review. Sorry about that,
>>>> with the holidays the timing did not work out very well.
>>>>
>>>> If you don't want to take this pull-request because of this it
>>>> would be good if you can at least take the patches up to
>>>> the "media: atomisp: Fix spelling mistake in ia_css_acc_types.h"
>>>> change. There are only 2 unreviewed patches from me in that
>>>> set, which fix the atomisp driver not working at all with
>>>> the latest media_stage/master code. And the rest of the patches
>>>> in that set are from others and have been reviewed by me.  
>>>
>>> We typically close the media merge window at -rc6. As I was also
>>> in vacations during those weeks, this PR was merged today for 6.9.  
>>
>> No problem, I know I was late with submitting this PR.
>>
>>> Indeed the first two patches seem to be needed to fix an issue on 6.8. 
>>> Could you please send them to stable after their arrival at linux-next?  
>>
>> I'm not sure what you mean with send them to stable ?
>>
>> 6.8 is not released yet, so these need to be send to Linus this
>> cycle. What is the process for media bugfixes for the current
>> kernel cycle ?
> 
> Heh, sorry, somehow I was thinking on 6.7 :-)
> 
> If the bug only happens on 6.8, I can just cherry-pick the two patches
> on my fixes branch.

I believe you only need:

"media: atomisp: Adjust for v4l2_subdev_state handling changes in 6.8"

And as the subject says, that is a fix for 6.8, 6.7 is fine AFAIK.

Thanks & Regards,

Hans

Re: [GIT PULL] media: atomisp: Changes for 6.8-1

[Mauro Carvalho Chehab]

Em Thu, 1 Feb 2024 13:33:08 +0100
Hans de Goede <hdegoede@redhat.com> escreveu:

> Hi,
> 
> On 2/1/24 13:18, Mauro Carvalho Chehab wrote:
> > Em Thu, 1 Feb 2024 12:46:19 +0100
> > Hans de Goede <hdegoede@redhat.com> escreveu:
> >   
> >> Hi,
> >>
> >> On 2/1/24 07:10, Mauro Carvalho Chehab wrote:  
> >>> Em Sun, 31 Dec 2023 11:39:18 +0100
> >>> Hans de Goede <hdegoede@redhat.com> escreveu:
> >>>     
> >>>> Hi Mauro,
> >>>>
> >>>> Here are the atomisp changes for 6.8.
> >>>>
> >>>> My patches in this set been posted on the list, but only a couple of
> >>>> minutes ago, leaving pretty much zero time for review. Sorry about that,
> >>>> with the holidays the timing did not work out very well.
> >>>>
> >>>> If you don't want to take this pull-request because of this it
> >>>> would be good if you can at least take the patches up to
> >>>> the "media: atomisp: Fix spelling mistake in ia_css_acc_types.h"
> >>>> change. There are only 2 unreviewed patches from me in that
> >>>> set, which fix the atomisp driver not working at all with
> >>>> the latest media_stage/master code. And the rest of the patches
> >>>> in that set are from others and have been reviewed by me.    
> >>>
> >>> We typically close the media merge window at -rc6. As I was also
> >>> in vacations during those weeks, this PR was merged today for 6.9.    
> >>
> >> No problem, I know I was late with submitting this PR.
> >>  
> >>> Indeed the first two patches seem to be needed to fix an issue on 6.8. 
> >>> Could you please send them to stable after their arrival at linux-next?    
> >>
> >> I'm not sure what you mean with send them to stable ?
> >>
> >> 6.8 is not released yet, so these need to be send to Linus this
> >> cycle. What is the process for media bugfixes for the current
> >> kernel cycle ?  
> > 
> > Heh, sorry, somehow I was thinking on 6.7 :-)
> > 
> > If the bug only happens on 6.8, I can just cherry-pick the two patches
> > on my fixes branch.  
> 
> I believe you only need:
> 
> "media: atomisp: Adjust for v4l2_subdev_state handling changes in 6.8"
> 
> And as the subject says, that is a fix for 6.8, 6.7 is fine AFAIK.

Ok, patch cherry-picked to the fixes branch. I'll send it together
with the other pending patches after they arrive to linux-next
(so likely next week).

Thanks,
Mauro