* [PATCH v2] staging: atomisp: bnr: fix trailing statement
@ 2024-07-31 10:33 Kartik Kulkarni
2024-09-02 10:11 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Kartik Kulkarni @ 2024-07-31 10:33 UTC (permalink / raw)
To: hdegoede, mchehab, akari.ailus, gregkh, linux-media,
linux-staging, linux-kernel
Cc: ~lkcamp/patches, helen.koike, kartik.koolks
Fix checkpatch error trailing statements should be on next line in
ia_css_bnr.host.c:48
Signed-off-by: Kartik Kulkarni <kartik.koolks@gmail.com>
---
v2: Move Signed-off-by line above the exclusion block
---
.../atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
index 457a004e1..b75cfd309 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
@@ -45,7 +45,8 @@ ia_css_bnr_dump(
const struct sh_css_isp_bnr_params *bnr,
unsigned int level)
{
- if (!bnr) return;
+ if (!bnr)
+ return;
ia_css_debug_dtrace(level, "Bayer Noise Reduction:\n");
ia_css_debug_dtrace(level, "\t%-32s = %d\n",
"bnr_gain_all", bnr->gain_all);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] staging: atomisp: bnr: fix trailing statement
2024-07-31 10:33 [PATCH v2] staging: atomisp: bnr: fix trailing statement Kartik Kulkarni
@ 2024-09-02 10:11 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2024-09-02 10:11 UTC (permalink / raw)
To: Kartik Kulkarni, mchehab, akari.ailus, gregkh, linux-media,
linux-staging, linux-kernel
Cc: ~lkcamp/patches, helen.koike
Hi,
On 7/31/24 12:33 PM, Kartik Kulkarni wrote:
> Fix checkpatch error trailing statements should be on next line in
> ia_css_bnr.host.c:48
>
> Signed-off-by: Kartik Kulkarni <kartik.koolks@gmail.com>
Thank you for your patch(es).
I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)
Regards,
Hans
> ---
> v2: Move Signed-off-by line above the exclusion block
> ---
> .../atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
> index 457a004e1..b75cfd309 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
> @@ -45,7 +45,8 @@ ia_css_bnr_dump(
> const struct sh_css_isp_bnr_params *bnr,
> unsigned int level)
> {
> - if (!bnr) return;
> + if (!bnr)
> + return;
> ia_css_debug_dtrace(level, "Bayer Noise Reduction:\n");
> ia_css_debug_dtrace(level, "\t%-32s = %d\n",
> "bnr_gain_all", bnr->gain_all);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-02 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31 10:33 [PATCH v2] staging: atomisp: bnr: fix trailing statement Kartik Kulkarni
2024-09-02 10:11 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox