From: Luka Gejak <luka.gejak@linux.dev>
To: mpikhotskyi@gmail.com
Cc: arthur.stupa@gmail.com, ebiggers@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, nathan@kernel.org,
sameekshasankpal@gmail.com, straube.linux@gmail.com,
luka.gejak@linux.dev, error27@gmail.com
Subject: Re: [PATCH] staging: r8723bs: reduce nesting
Date: Thu, 16 Apr 2026 13:20:09 +0200 [thread overview]
Message-ID: <E4BF62EF-C6F6-431F-8EDC-77C1E613E66B@linux.dev> (raw)
In-Reply-To: <20260415184727.285753-1-mpikhotskyi@gmail.com>
Hi Maksym,
Your patch doesn't apply cleanly on top of the staging-next branch.
Recently, we merged a patch that replaced is_broadcast_mac_addr() with
the standard kernel function is_broadcast_ether_addr(), which is
causing conflicts. Additionally, someone recently tried to do a
similar refactoring just for rtw_aes_decrypt() but introduced a major
bug. They wrote if (stainfo) instead of if (!stainfo), causing it to
fail on valid pointers and crash on invalid ones. Your patch actually
fixes their mistake. Could you please rebase your work onto the latest
staging-next branch and send a v2 series? It would be best to split it
into two patches(a patch series): first, a bug fix for
rtw_aes_decrypt() to correct the if (!stainfo) logic (please add a
fixes tag), and second, your early-return refactoring for the
remaining functions. Also, don't forget to fix the subsystem prefix in
your subject line to staging: rtl8723bs:
Looking forward to the v2.
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-04-16 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 18:47 [PATCH] staging: r8723bs: reduce nesting Maksym Pikhotskyi
2026-04-16 11:20 ` Luka Gejak [this message]
2026-04-16 19:53 ` [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Maksym Pikhotskyi
2026-04-16 19:53 ` [PATCH v2 2/2] staging: rtl8723bs: reduce nesting Maksym Pikhotskyi
2026-04-16 20:58 ` Luka Gejak
2026-04-16 20:42 ` [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Luka Gejak
2026-04-16 21:19 ` Dan Carpenter
2026-04-16 21:11 ` Dan Carpenter
2026-04-16 21:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E4BF62EF-C6F6-431F-8EDC-77C1E613E66B@linux.dev \
--to=luka.gejak@linux.dev \
--cc=arthur.stupa@gmail.com \
--cc=ebiggers@kernel.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mpikhotskyi@gmail.com \
--cc=nathan@kernel.org \
--cc=sameekshasankpal@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox