From: Luka Gejak <luka.gejak@linux.dev>
To: Maksym Pikhotskyi <mpikhotskyi@gmail.com>,
gregkh@linuxfoundation.org, ethantidmore06@gmail.com,
starpt.official@gmail.com, straube.linux@gmail.com,
sameekshasankpal@gmail.com, arthur.stupa@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
luka.gejak@linux.dev
Subject: Re: [PATCH v2 2/2] staging: rtl8723bs: reduce nesting
Date: Thu, 16 Apr 2026 22:58:45 +0200 [thread overview]
Message-ID: <E7D7D838-852B-46EE-9E74-E7ED7D91030F@linux.dev> (raw)
In-Reply-To: <20260416195338.324428-2-mpikhotskyi@gmail.com>
On April 16, 2026 9:53:38 PM GMT+02:00, Maksym Pikhotskyi <mpikhotskyi@gmail.com> wrote:
>Reduce nesting by early returns.
>
>Signed-off-by: Maksym Pikhotskyi <mpikhotskyi@gmail.com>
>---
...
Hi Maksym,
Your logic is spot on. However, your subject line and commit message
should be more detailed. Please try answering questions like why you
made these changes and where they apply (mentioning the specific
functions or file(if it changes whole file) in the commit body). Also,
it would be preferable if you sent your v3 as a completely separate
thread.
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-04-16 20:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 18:47 [PATCH] staging: r8723bs: reduce nesting Maksym Pikhotskyi
2026-04-16 11:20 ` Luka Gejak
2026-04-16 19:53 ` [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Maksym Pikhotskyi
2026-04-16 19:53 ` [PATCH v2 2/2] staging: rtl8723bs: reduce nesting Maksym Pikhotskyi
2026-04-16 20:58 ` Luka Gejak [this message]
2026-04-16 20:42 ` [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Luka Gejak
2026-04-16 21:19 ` Dan Carpenter
2026-04-16 21:11 ` Dan Carpenter
2026-04-16 21:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E7D7D838-852B-46EE-9E74-E7ED7D91030F@linux.dev \
--to=luka.gejak@linux.dev \
--cc=arthur.stupa@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mpikhotskyi@gmail.com \
--cc=sameekshasankpal@gmail.com \
--cc=starpt.official@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox