From: Dan Carpenter <error27@gmail.com>
To: Maksym Pikhotskyi <mpikhotskyi@gmail.com>
Cc: gregkh@linuxfoundation.org, ethantidmore06@gmail.com,
starpt.official@gmail.com, straube.linux@gmail.com,
sameekshasankpal@gmail.com, arthur.stupa@gmail.com,
luka.gejak@linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt
Date: Fri, 17 Apr 2026 00:13:07 +0300 [thread overview]
Message-ID: <aeFQ4zI3Vb80noQd@stanley.mountain> (raw)
In-Reply-To: <20260416195338.324428-1-mpikhotskyi@gmail.com>
On Thu, Apr 16, 2026 at 11:53:37PM +0400, Maksym Pikhotskyi wrote:
> The null-pointer-guard was incorrect, returning _FAIL on valid pointer.
> Invert the guard, so it returns _FAIL on invalid pointer.
>
> Fixes: e23ad1570028 ("staging: rtl8723bs: use guard clause for stainfo check")
> Signed-off-by: Maksym Pikhotskyi <mpikhotskyi@gmail.com>
> ---
You need to put a little note here under the --- cut off line which says:
v2: rebased on linux-next.
Also added another fix?
Please send v3. You can still add my Reviewed-by tag though.
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-16 21:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 18:47 [PATCH] staging: r8723bs: reduce nesting Maksym Pikhotskyi
2026-04-16 11:20 ` Luka Gejak
2026-04-16 19:53 ` [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Maksym Pikhotskyi
2026-04-16 19:53 ` [PATCH v2 2/2] staging: rtl8723bs: reduce nesting Maksym Pikhotskyi
2026-04-16 20:58 ` Luka Gejak
2026-04-16 20:42 ` [PATCH v2 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Luka Gejak
2026-04-16 21:19 ` Dan Carpenter
2026-04-16 21:11 ` Dan Carpenter
2026-04-16 21:13 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-17 9:51 Maksym Pikhotskyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeFQ4zI3Vb80noQd@stanley.mountain \
--to=error27@gmail.com \
--cc=arthur.stupa@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
--cc=mpikhotskyi@gmail.com \
--cc=sameekshasankpal@gmail.com \
--cc=starpt.official@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox