* [PATCH] staging: wlan-ng: Fix formatting of block comments
@ 2021-10-30 10:08 Gabriel Goller
2021-10-30 10:22 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Goller @ 2021-10-30 10:08 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging
Fixed warnings of checkpatch.pl in prism2mib.c:
Block comments use * on subsequent lines.
Signed-off-by: Gabriel Goller <gabrielgoller123@gmail.com>
---
drivers/staging/wlan-ng/prism2mib.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
index 24ba10d6bd0b..c04fc17b3c64 100644
--- a/drivers/staging/wlan-ng/prism2mib.c
+++ b/drivers/staging/wlan-ng/prism2mib.c
@@ -680,15 +680,15 @@ static int prism2mib_priv(struct mibrec *mib,
(u8 *)&wpa,
sizeof(wpa));
/*
- pstr->len = le16_to_cpu(wpa.datalen);
- memcpy(pstr->data, wpa.data, pstr->len);
- */
+ * pstr->len = le16_to_cpu(wpa.datalen);
+ * memcpy(pstr->data, wpa.data, pstr->len);
+ */
pstr->len = 0;
} else {
/*
- wpa.datalen = cpu_to_le16(pstr->len);
- memcpy(wpa.data, pstr->data, pstr->len);
- */
+ * wpa.datalen = cpu_to_le16(pstr->len);
+ * memcpy(wpa.data, pstr->data, pstr->len);
+ */
wpa.datalen = 0;
hfa384x_drvr_setconfig(hw,
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: wlan-ng: Fix formatting of block comments
2021-10-30 10:08 [PATCH] staging: wlan-ng: Fix formatting of block comments Gabriel Goller
@ 2021-10-30 10:22 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-10-30 10:22 UTC (permalink / raw)
To: Gabriel Goller; +Cc: linux-staging
On Sat, Oct 30, 2021 at 12:08:25PM +0200, Gabriel Goller wrote:
> Fixed warnings of checkpatch.pl in prism2mib.c:
> Block comments use * on subsequent lines.
>
> Signed-off-by: Gabriel Goller <gabrielgoller123@gmail.com>
> ---
> drivers/staging/wlan-ng/prism2mib.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
> index 24ba10d6bd0b..c04fc17b3c64 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -680,15 +680,15 @@ static int prism2mib_priv(struct mibrec *mib,
> (u8 *)&wpa,
> sizeof(wpa));
> /*
> - pstr->len = le16_to_cpu(wpa.datalen);
> - memcpy(pstr->data, wpa.data, pstr->len);
> - */
> + * pstr->len = le16_to_cpu(wpa.datalen);
> + * memcpy(pstr->data, wpa.data, pstr->len);
> + */
Why keep this code at all? Please just delete it as it's obviously not
being used.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-30 10:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-30 10:08 [PATCH] staging: wlan-ng: Fix formatting of block comments Gabriel Goller
2021-10-30 10:22 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox