* [PATCH] staging: rtl8723bs: remove braces around single statements
@ 2025-03-25 16:32 Abraham Samuel Adekunle
2025-03-26 8:26 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Abraham Samuel Adekunle @ 2025-03-25 16:32 UTC (permalink / raw)
To: Greg Kroah-Hartman, outreachy, Julia Lawall; +Cc: linux-staging, linux-kernel
The code contains braces around single statements in the if blocks
which are unnecessary according to the Linux kernel coding style.
Remove the braces to improve readability and maintain consistency.
Reported by checkpatch:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index c60e179bb2e1..b17b295e8d3c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -56,9 +56,9 @@ int _ips_leave(struct adapter *padapter)
pwrpriv->ips_leave_cnts++;
result = rtw_ips_pwr_up(padapter);
- if (result == _SUCCESS) {
+ if (result == _SUCCESS)
pwrpriv->rf_pwrstate = rf_on;
- }
+
pwrpriv->bips_processing = false;
pwrpriv->bkeepfwalive = false;
@@ -549,9 +549,8 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter)
LPS_Leave_check(Adapter);
} else {
- if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off) {
+ if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off)
ips_leave(Adapter);
- }
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: remove braces around single statements
2025-03-25 16:32 [PATCH] staging: rtl8723bs: remove braces around single statements Abraham Samuel Adekunle
@ 2025-03-26 8:26 ` Julia Lawall
2025-03-26 9:00 ` Samuel Abraham
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2025-03-26 8:26 UTC (permalink / raw)
To: Abraham Samuel Adekunle
Cc: Greg Kroah-Hartman, outreachy, linux-staging, linux-kernel
On Tue, 25 Mar 2025, Abraham Samuel Adekunle wrote:
> The code contains braces around single statements in the if blocks
> which are unnecessary according to the Linux kernel coding style.
>
> Remove the braces to improve readability and maintain consistency.
>
> Reported by checkpatch:
>
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index c60e179bb2e1..b17b295e8d3c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -56,9 +56,9 @@ int _ips_leave(struct adapter *padapter)
> pwrpriv->ips_leave_cnts++;
>
> result = rtw_ips_pwr_up(padapter);
> - if (result == _SUCCESS) {
> + if (result == _SUCCESS)
> pwrpriv->rf_pwrstate = rf_on;
> - }
> +
I'm not sure you need to add a blank line here?
julia
> pwrpriv->bips_processing = false;
>
> pwrpriv->bkeepfwalive = false;
> @@ -549,9 +549,8 @@ void LeaveAllPowerSaveMode(struct adapter *Adapter)
>
> LPS_Leave_check(Adapter);
> } else {
> - if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off) {
> + if (adapter_to_pwrctl(Adapter)->rf_pwrstate == rf_off)
> ips_leave(Adapter);
> - }
> }
> }
>
> --
> 2.34.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: remove braces around single statements
2025-03-26 8:26 ` Julia Lawall
@ 2025-03-26 9:00 ` Samuel Abraham
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Abraham @ 2025-03-26 9:00 UTC (permalink / raw)
To: Julia Lawall; +Cc: Greg Kroah-Hartman, outreachy, linux-staging, linux-kernel
On Wed, Mar 26, 2025 at 9:26 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> On Tue, 25 Mar 2025, Abraham Samuel Adekunle wrote:
>
> > The code contains braces around single statements in the if blocks
> > which are unnecessary according to the Linux kernel coding style.
> >
> > Remove the braces to improve readability and maintain consistency.
> >
> > Reported by checkpatch:
> >
> > WARNING: braces {} are not necessary for single statement blocks
> >
> > Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> > index c60e179bb2e1..b17b295e8d3c 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> > @@ -56,9 +56,9 @@ int _ips_leave(struct adapter *padapter)
> > pwrpriv->ips_leave_cnts++;
> >
> > result = rtw_ips_pwr_up(padapter);
> > - if (result == _SUCCESS) {
> > + if (result == _SUCCESS)
> > pwrpriv->rf_pwrstate = rf_on;
> > - }
> > +
>
> I'm not sure you need to add a blank line here?
>
> julia
>
Thank you for your review. I will effect the change
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-26 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-25 16:32 [PATCH] staging: rtl8723bs: remove braces around single statements Abraham Samuel Adekunle
2025-03-26 8:26 ` Julia Lawall
2025-03-26 9:00 ` Samuel Abraham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox