* [PATCH] staging: gpib: format no multiple blank lines
@ 2025-01-31 8:22 Ian To
2025-02-03 15:09 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Ian To @ 2025-01-31 8:22 UTC (permalink / raw)
To: dpenkler, gregkh; +Cc: linux-staging, linux-kernel
Avoid adding multiple blank lines. Reported by checkpatch.
Signed-off-by: Ian To <onlyian4981@gmail.com>
---
drivers/staging/gpib/hp_82341/hp_82341.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gpib/hp_82341/hp_82341.h b/drivers/staging/gpib/hp_82341/hp_82341.h
index 0065ebd9747c..d3cf1f43a1ef 100644
--- a/drivers/staging/gpib/hp_82341/hp_82341.h
+++ b/drivers/staging/gpib/hp_82341/hp_82341.h
@@ -26,7 +26,6 @@ struct hp_82341_priv {
enum hp_82341_hardware_version hw_version;
};
-
// interface functions
int hp_82341_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end,
size_t *bytes_read);
--
2.45.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: gpib: format no multiple blank lines
2025-01-31 8:22 [PATCH] staging: gpib: format no multiple blank lines Ian To
@ 2025-02-03 15:09 ` Greg KH
2025-02-03 15:35 ` Dave Penkler
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2025-02-03 15:09 UTC (permalink / raw)
To: Ian To; +Cc: dpenkler, linux-staging, linux-kernel
On Fri, Jan 31, 2025 at 12:22:33AM -0800, Ian To wrote:
> Avoid adding multiple blank lines. Reported by checkpatch.
>
> Signed-off-by: Ian To <onlyian4981@gmail.com>
> ---
> drivers/staging/gpib/hp_82341/hp_82341.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/gpib/hp_82341/hp_82341.h b/drivers/staging/gpib/hp_82341/hp_82341.h
> index 0065ebd9747c..d3cf1f43a1ef 100644
> --- a/drivers/staging/gpib/hp_82341/hp_82341.h
> +++ b/drivers/staging/gpib/hp_82341/hp_82341.h
> @@ -26,7 +26,6 @@ struct hp_82341_priv {
> enum hp_82341_hardware_version hw_version;
> };
>
> -
> // interface functions
> int hp_82341_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end,
> size_t *bytes_read);
> --
> 2.45.3
>
>
Does not apply cleanly to 6.14-rc1 :(
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: gpib: format no multiple blank lines
2025-02-03 15:09 ` Greg KH
@ 2025-02-03 15:35 ` Dave Penkler
0 siblings, 0 replies; 3+ messages in thread
From: Dave Penkler @ 2025-02-03 15:35 UTC (permalink / raw)
To: Greg KH; +Cc: Ian To, linux-staging, linux-kernel
On Mon, Feb 03, 2025 at 04:09:45PM +0100, Greg KH wrote:
> On Fri, Jan 31, 2025 at 12:22:33AM -0800, Ian To wrote:
> > Avoid adding multiple blank lines. Reported by checkpatch.
> >
> > Signed-off-by: Ian To <onlyian4981@gmail.com>
> > ---
> > drivers/staging/gpib/hp_82341/hp_82341.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/gpib/hp_82341/hp_82341.h b/drivers/staging/gpib/hp_82341/hp_82341.h
> > index 0065ebd9747c..d3cf1f43a1ef 100644
> > --- a/drivers/staging/gpib/hp_82341/hp_82341.h
> > +++ b/drivers/staging/gpib/hp_82341/hp_82341.h
> > @@ -26,7 +26,6 @@ struct hp_82341_priv {
> > enum hp_82341_hardware_version hw_version;
> > };
> >
> > -
> > // interface functions
> > int hp_82341_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end,
> > size_t *bytes_read);
> > --
> > 2.45.3
> >
> >
>
> Does not apply cleanly to 6.14-rc1 :(
An earlier patch, commit 8418753187ba ("staging: gpib: Make static, reduce fwd declarations") changed this file. It is at this point checkpatch clean.
cheers,
-dave
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-03 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-31 8:22 [PATCH] staging: gpib: format no multiple blank lines Ian To
2025-02-03 15:09 ` Greg KH
2025-02-03 15:35 ` Dave Penkler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox