* [PATCH] staging: cfg80211: Remove parentheses prism2_get_station
@ 2024-03-11 13:45 Felix N. Kimbu
2024-03-11 14:09 ` Dan Carpenter
2024-03-11 17:05 ` Julia Lawall
0 siblings, 2 replies; 5+ messages in thread
From: Felix N. Kimbu @ 2024-03-11 13:45 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel; +Cc: outreachy
Remove unnecessary parentheses around 'wlandev->msdstate != WLAN_MSD_RUNNING'
in static int prism2_get_station(...)
This change ensures adherence to coding style guidelines.
Signed-off-by: Felix N. Kimbu <felixkimbu1@gmail.com>
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 471bb310176f..7451fd2bb580 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
memset(sinfo, 0, sizeof(*sinfo));
- if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
+ if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
return -EOPNOTSUPP;
/* build request message */
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: cfg80211: Remove parentheses prism2_get_station
2024-03-11 13:45 [PATCH] staging: cfg80211: Remove parentheses prism2_get_station Felix N. Kimbu
@ 2024-03-11 14:09 ` Dan Carpenter
2024-03-11 17:05 ` Julia Lawall
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2024-03-11 14:09 UTC (permalink / raw)
To: Felix N. Kimbu; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel, outreachy
On Mon, Mar 11, 2024 at 02:45:41PM +0100, Felix N. Kimbu wrote:
> Remove unnecessary parentheses around 'wlandev->msdstate != WLAN_MSD_RUNNING'
> in static int prism2_get_station(...)
>
> This change ensures adherence to coding style guidelines.
>
> Signed-off-by: Felix N. Kimbu <felixkimbu1@gmail.com>
> ---
> drivers/staging/wlan-ng/cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 471bb310176f..7451fd2bb580 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
>
> memset(sinfo, 0, sizeof(*sinfo));
>
> - if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
> + if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
Sorry, we're ignoring this checkpatch warning.
https://lore.kernel.org/all/?q=prism2_get_station
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: cfg80211: Remove parentheses prism2_get_station
2024-03-11 13:45 [PATCH] staging: cfg80211: Remove parentheses prism2_get_station Felix N. Kimbu
2024-03-11 14:09 ` Dan Carpenter
@ 2024-03-11 17:05 ` Julia Lawall
2024-03-11 19:12 ` Philipp Hortmann
1 sibling, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2024-03-11 17:05 UTC (permalink / raw)
To: Felix N. Kimbu; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel, outreachy
On Mon, 11 Mar 2024, Felix N. Kimbu wrote:
> Remove unnecessary parentheses around 'wlandev->msdstate != WLAN_MSD_RUNNING'
> in static int prism2_get_station(...)
You don't need the name of the function in the subject line. That
information doesn't help understand the patch.
julia
>
> This change ensures adherence to coding style guidelines.
>
> Signed-off-by: Felix N. Kimbu <felixkimbu1@gmail.com>
> ---
> drivers/staging/wlan-ng/cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 471bb310176f..7451fd2bb580 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
>
> memset(sinfo, 0, sizeof(*sinfo));
>
> - if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
> + if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
> return -EOPNOTSUPP;
>
> /* build request message */
> --
> 2.34.1
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: cfg80211: Remove parentheses prism2_get_station
2024-03-11 17:05 ` Julia Lawall
@ 2024-03-11 19:12 ` Philipp Hortmann
2024-03-11 20:46 ` Julia Lawall
0 siblings, 1 reply; 5+ messages in thread
From: Philipp Hortmann @ 2024-03-11 19:12 UTC (permalink / raw)
To: Julia Lawall, Felix N. Kimbu
Cc: Greg Kroah-Hartman, linux-staging, linux-kernel, outreachy
On 3/11/24 18:05, Julia Lawall wrote:
>
>
> On Mon, 11 Mar 2024, Felix N. Kimbu wrote:
>
>> Remove unnecessary parentheses around 'wlandev->msdstate != WLAN_MSD_RUNNING'
>> in static int prism2_get_station(...)
>
> You don't need the name of the function in the subject line. That
> information doesn't help understand the patch.
>
> julia
Hi Julia,
I think we do not need the function name in the subject but we need
something to distinguish between the patches. The subject line needs to
be a little unique. Otherwise we will have 100 patches like "[PATCH]
staging: cfg80211: Remove parentheses" when we are unlucky. Any better
proposal for a Subject uniqueness is welcome.
Function name for this purpose is OK for me.
Thanks for your support.
Bye Philipp
>
>>
>> This change ensures adherence to coding style guidelines.
>>
>> Signed-off-by: Felix N. Kimbu <felixkimbu1@gmail.com>
>> ---
>> drivers/staging/wlan-ng/cfg80211.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
>> index 471bb310176f..7451fd2bb580 100644
>> --- a/drivers/staging/wlan-ng/cfg80211.c
>> +++ b/drivers/staging/wlan-ng/cfg80211.c
>> @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
>>
>> memset(sinfo, 0, sizeof(*sinfo));
>>
>> - if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
>> + if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
>> return -EOPNOTSUPP;
>>
>> /* build request message */
>> --
>> 2.34.1
>>
>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: cfg80211: Remove parentheses prism2_get_station
2024-03-11 19:12 ` Philipp Hortmann
@ 2024-03-11 20:46 ` Julia Lawall
0 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2024-03-11 20:46 UTC (permalink / raw)
To: Philipp Hortmann
Cc: Felix N. Kimbu, Greg Kroah-Hartman, linux-staging, linux-kernel,
outreachy
On Mon, 11 Mar 2024, Philipp Hortmann wrote:
> On 3/11/24 18:05, Julia Lawall wrote:
> >
> >
> > On Mon, 11 Mar 2024, Felix N. Kimbu wrote:
> >
> > > Remove unnecessary parentheses around 'wlandev->msdstate !=
> > > WLAN_MSD_RUNNING'
> > > in static int prism2_get_station(...)
> >
> > You don't need the name of the function in the subject line. That
> > information doesn't help understand the patch.
> >
> > julia
>
> Hi Julia,
>
> I think we do not need the function name in the subject but we need something
> to distinguish between the patches. The subject line needs to be a little
> unique. Otherwise we will have 100 patches like "[PATCH] staging: cfg80211:
> Remove parentheses" when we are unlucky. Any better proposal for a Subject
> uniqueness is welcome.
>
> Function name for this purpose is OK for me.
OK, no problem.
thanks,
julia
>
> Thanks for your support.
>
> Bye Philipp
>
>
> >
> > >
> > > This change ensures adherence to coding style guidelines.
> > >
> > > Signed-off-by: Felix N. Kimbu <felixkimbu1@gmail.com>
> > > ---
> > > drivers/staging/wlan-ng/cfg80211.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/wlan-ng/cfg80211.c
> > > b/drivers/staging/wlan-ng/cfg80211.c
> > > index 471bb310176f..7451fd2bb580 100644
> > > --- a/drivers/staging/wlan-ng/cfg80211.c
> > > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > > @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy,
> > > struct net_device *dev,
> > >
> > > memset(sinfo, 0, sizeof(*sinfo));
> > >
> > > - if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
> > > + if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
> > > return -EOPNOTSUPP;
> > >
> > > /* build request message */
> > > --
> > > 2.34.1
> > >
> > >
> > >
> >
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-11 20:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-11 13:45 [PATCH] staging: cfg80211: Remove parentheses prism2_get_station Felix N. Kimbu
2024-03-11 14:09 ` Dan Carpenter
2024-03-11 17:05 ` Julia Lawall
2024-03-11 19:12 ` Philipp Hortmann
2024-03-11 20:46 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox