[PATCH v2 0/3] staging: cleanup of sdio_intf.c

[PATCH v2 0/3] staging: cleanup of sdio_intf.c

[Manuel Ebner]

did i overdo the split up?

[v2]
 split patch into series

Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
---

[PATCH v2 1/3] staging: sdio_intf.c: refactor function

[Manuel Ebner]

remove unused argument of rtw_sdio_if1_init()

Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
---
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index 1d0239eef114..4439ded602b6 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -237,7 +237,7 @@ static void sd_intf_stop(struct adapter *padapter)
 }
 
 
-static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct sdio_device_id  *pdid)
+static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj)
 {
 	int status = _FAIL;
 	struct net_device *pnetdev;
@@ -368,7 +368,7 @@ static int rtw_drv_init(
 	if (!dvobj)
 		goto exit;
 
-	if1 = rtw_sdio_if1_init(dvobj, id);
+	if1 = rtw_sdio_if1_init(dvobj);
 	if (!if1)
 		goto free_dvobj;
 
-- 
2.54.0

[PATCH v2 2/3] staging: cleanup whitespace of sdio_intf.c

[Manuel Ebner]

remove empty lines, add lines where appropriate
reformat function declaration

Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
---
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index 4439ded602b6..a78fb4bc7155 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -47,7 +47,6 @@ static void sd_sync_int_hdl(struct sdio_func *func)
 {
 	struct dvobj_priv *psdpriv;
 
-
 	psdpriv = sdio_get_drvdata(func);
 
 	if (!psdpriv->if1)
@@ -168,6 +167,7 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
 		sdio_release_host(func);
 	}
 }
+
 static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func)
 {
 	int status = _FAIL;
@@ -236,7 +236,6 @@ static void sd_intf_stop(struct adapter *padapter)
 	rtw_hal_disable_interrupt(padapter);
 }
 
-
 static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj)
 {
 	int status = _FAIL;
@@ -270,7 +269,6 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj)
 	/* 4 3.1 set hardware operation functions */
 	rtw_set_hal_ops(padapter);
 
-
 	/* 3 5. initialize Chip version */
 	padapter->intf_start = &sd_intf_start;
 	padapter->intf_stop = &sd_intf_stop;
@@ -356,9 +354,8 @@ static void rtw_sdio_if1_deinit(struct adapter *if1)
  * notes: drv_init() is called when the bus driver has located a card for us to support.
  *        We accept the new device by returning 0.
  */
-static int rtw_drv_init(
-	struct sdio_func *func,
-	const struct sdio_device_id *id)
+static int rtw_drv_init(struct sdio_func *func,
+			const struct sdio_device_id *id)
 {
 	int status = _FAIL;
 	struct adapter *if1 = NULL;
-- 
2.54.0

[PATCH v2 3/3] staging: cleanup braces of sdio_intf.c

[Manuel Ebner]

add braces to else statement

Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
---
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index a78fb4bc7155..fc16cf2e577d 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -100,8 +100,9 @@ static void sdio_free_irq(struct dvobj_priv *dvobj)
 				netdev_err(dvobj->if1->pnetdev,
 					   "%s: sdio_release_irq FAIL(%d)!\n",
 					   __func__, err);
-			} else
+			} else {
 				dvobj->drv_dbg.dbg_sdio_free_irq_cnt++;
+			}
 			sdio_release_host(func);
 		}
 		dvobj->irq_alloc = 0;
-- 
2.54.0

Re: [PATCH v2 0/3] staging: cleanup of sdio_intf.c

[Dan Carpenter]

On Fri, May 22, 2026 at 01:43:20PM +0200, Manuel Ebner wrote:
> did i overdo the split up?
> 

The split is fine.  The subsystem prefix needs to be improved.  The
capitalization and puncuation in the commit message could be improved
as well.

regards,
dan carpenter

Re: [PATCH v2 0/3] staging: cleanup of sdio_intf.c

[Manuel Ebner]

On Fri, 2026-05-22 at 16:02 +0300, Dan Carpenter wrote:
> On Fri, May 22, 2026 at 01:43:20PM +0200, Manuel Ebner wrote:
> > did i overdo the split up?
> > 
> 
> The split is fine.  The subsystem prefix needs to be improved.

Is it wireless? If it isn't how can I find the subsystems for my patches.

> The
> capitalization and puncuation in the commit message could be improved
> as well.

I will do that.

Thanks
 Manuel Ebner
> 
> regards,
> dan carpenter

Re: [PATCH v2 0/3] staging: cleanup of sdio_intf.c

[Dan Carpenter]

On Fri, May 22, 2026 at 05:33:53PM +0200, Manuel Ebner wrote:
> On Fri, 2026-05-22 at 16:02 +0300, Dan Carpenter wrote:
> > On Fri, May 22, 2026 at 01:43:20PM +0200, Manuel Ebner wrote:
> > > did i overdo the split up?
> > > 
> > 
> > The split is fine.  The subsystem prefix needs to be improved.
> 
> Is it wireless? If it isn't how can I find the subsystems for my patches.
> 

git log --oneline drivers/staging/rtl8723bs/os_dep/sdio_intf.c

Use what everyone else uses:
Subject: staging: rtl8723bs: cleanup of sdio_intf.c

regards,
dan carpenter

Re: [PATCH v2 2/3] staging: cleanup whitespace of sdio_intf.c

[Greg KH]

On Fri, May 22, 2026 at 01:57:02PM +0200, Manuel Ebner wrote:
> remove empty lines, add lines where appropriate
> reformat function declaration

That is multiple different things, which of course need multiple
different patches.

thanks,

greg k-h