[PATCH 0/5] staging: rtl8723bs: Fix coding style issues in header files

[PATCH 0/5] staging: rtl8723bs: Fix coding style issues in header files

[Subhrojyoti Bala]

This patch series fixes various coding style issues in the
rtl8723bs staging driver header files, as reported by
checkpatch.pl:

- Fix multi-line comment style in wlan_bssdef.h
- Fix enum indentation in rtw_mlme.h
- Fix block comment style in rtw_mlme.h
- Fix multi-line comment style in rtw_mlme.h
- Fix whitespace in comments in rtw_mlme.h

Subhrojyoti Bala (5):
  staging: rtl8723bs: Fix multi-line comment style in wlan_bssdef.h
  staging: rtl8723bs: Fix indentation in enum in rtw_mlme.h
  staging: rtl8723bs: Fix block comment style in rtw_mlme.h
  staging: rtl8723bs: Fix multi-line comment style in rtw_mlme.h
  staging: rtl8723bs: Fix whitespace in comments in rtw_mlme.h

 drivers/staging/rtl8723bs/include/rtw_mlme.h  | 55 ++++++++++---------
 .../staging/rtl8723bs/include/wlan_bssdef.h   | 14 ++---
 2 files changed, 35 insertions(+), 34 deletions(-)

Signed-off-by: Subhrojyoti Bala <subhrojyoti0609@gmail.com>
-- 
2.54.0

[PATCH 1/5] staging: rtl8723bs: Fix multi-line comment style in wlan_bssdef.h

[Subhrojyoti Bala]

Fix block comments that were not following the kernel's multi-line
comment style. Comments should use the following format:

/*
 * text
 */

No functional change.

Signed-off-by: Subhrojyoti Bala <subhrojyoti0609@gmail.com>
---
 drivers/staging/rtl8723bs/include/wlan_bssdef.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
index 812a68394268..25ac996e73e3 100644
--- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
+++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
@@ -31,10 +31,9 @@ enum ndis_802_11_network_type {
 	Ndis802_11NetworkTypeMax    /*  not a real type, defined as an upper bound */
 };
 
-/*
-	FW will only save the channel number in DSConfig.
-	ODI Handler will convert the channel number to freq. number.
-*/
+/* FW will only save the channel number in DSConfig. */
+/* ODI Handler will convert the channel number to freq. number. */
+
 struct ndis_802_11_conf {
 	u32 length;             /*  Length of structure */
 	u32 beacon_period;       /*  units are Kusec */
@@ -138,7 +137,8 @@ struct wlan_phy_info {
 
 struct wlan_bcn_info {
 	/* these infor get from rtw_get_encrypt_info when
-	 * * translate scan to UI */
+	 * translate scan to UI
+	 */
 	u8 encryp_protocol;/* ENCRYP_PROTOCOL_E: OPEN/WEP/WPA/WPA2/WAPI */
 	int group_cipher; /* WPA/WPA2 group cipher */
 	int pairwise_cipher;/* WPA/WPA2/WEP pairwise cipher */
@@ -150,8 +150,8 @@ struct wlan_bcn_info {
 };
 
 /* temporally add #pragma pack for structure alignment issue of
-*   struct wlan_bssid_ex and get_wlan_bssid_ex_sz()
-*/
+ * struct wlan_bssid_ex and get_wlan_bssid_ex_sz()
+ */
 struct wlan_bssid_ex {
 	u32  length;
 	u8 mac_address[ETH_ALEN];
-- 
2.54.0

[PATCH 2/5] staging: rtl8723bs: Fix indentation in enum in rtw_mlme.h

[Subhrojyoti Bala]

Enum members were missing tab indentation. Add proper tab
indent to align with kernel coding style.

No functional change.

Signed-off-by: Subhrojyoti Bala <subhrojyoti0609@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtw_mlme.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging/rtl8723bs/include/rtw_mlme.h
index ac3ba746b64c..403c097b46ef 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h
@@ -44,12 +44,12 @@
 
 
 enum {
- dot11AuthAlgrthm_Open = 0,
- dot11AuthAlgrthm_Shared,
- dot11AuthAlgrthm_8021X,
- dot11AuthAlgrthm_Auto,
- dot11AuthAlgrthm_WAPI,
- dot11AuthAlgrthm_MaxNum
+	dot11AuthAlgrthm_Open = 0,
+	dot11AuthAlgrthm_Shared,
+	dot11AuthAlgrthm_8021X,
+	dot11AuthAlgrthm_Auto,
+	dot11AuthAlgrthm_WAPI,
+	dot11AuthAlgrthm_MaxNum
 };
 
 /*  Scan type including active and passive scan. */
-- 
2.54.0

[PATCH 3/5] staging: rtl8723bs: Fix block comment style in rtw_mlme.h

[Subhrojyoti Bala]

Block comment was not using a trailing */ on a separate line.
Fix it to comply with kernel coding style.

No functional change.

Signed-off-by: Subhrojyoti Bala <subhrojyoti0609@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtw_mlme.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging/rtl8723bs/include/rtw_mlme.h
index 403c097b46ef..dbb523c8a58b 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h
@@ -183,8 +183,10 @@ struct mlme_priv {
 	u8 *wps_probe_req_ie;
 	u32 wps_probe_req_ie_len;
 
-	/* Number of associated Non-ERP stations (i.e., stations using 802.11b
-	 * in 802.11g BSS) */
+	/*
+	 * Number of associated Non-ERP stations (i.e., stations using 802.11b
+	 * in 802.11g BSS)
+	 */
 	int num_sta_non_erp;
 
 	/* Number of associated stations that do not support Short Slot Time */
-- 
2.54.0

[PATCH 4/5] staging: rtl8723bs: Fix multi-line comment style in rtw_mlme.h

[Subhrojyoti Bala]

Block comment was not using * on subsequent lines and had blank
lines inside the comment body. Fix it to comply with kernel
coding style.

No functional change.

Signed-off-by: Subhrojyoti Bala <subhrojyoti0609@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtw_mlme.h | 33 ++++++++++----------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging/rtl8723bs/include/rtw_mlme.h
index dbb523c8a58b..59b12d9daa71 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h
@@ -67,23 +67,22 @@ enum {
 };
 
 /*
-
-there are several "locks" in mlme_priv,
-since mlme_priv is a shared resource between many threads,
-like ISR/Call-Back functions, the OID handlers, and even timer functions.
-
-Each struct __queue has its own locks, already.
-Other items in mlme_priv are protected by mlme_priv.lock, while items in
-xmit_priv are protected by xmit_priv.lock.
-
-To avoid possible dead lock, any thread trying to modifying mlme_priv
-SHALL not lock up more than one locks at a time!
-
-The only exception is that queue functions which take the __queue.lock
-may be called with the xmit_priv.lock held. In this case the order
-MUST always be first lock xmit_priv.lock and then call any queue functions
-which take __queue.lock.
-*/
+ * There are several "locks" in mlme_priv,
+ * since mlme_priv is a shared resource between many threads,
+ * like ISR/Call-Back functions, the OID handlers, and even timer functions.
+ *
+ * Each struct __queue has its own locks, already.
+ * Other items in mlme_priv are protected by mlme_priv.lock, while items in
+ * xmit_priv are protected by xmit_priv.lock.
+ *
+ * To avoid possible dead lock, any thread trying to modifying mlme_priv
+ * SHALL not lock up more than one locks at a time!
+ *
+ * The only exception is that queue functions which take the __queue.lock
+ * may be called with the xmit_priv.lock held. In this case the order
+ * MUST always be first lock xmit_priv.lock and then call any queue functions
+ * which take __queue.lock.
+ */
 
 struct sitesurvey_ctrl {
 	u64	last_tx_pkts;
-- 
2.54.0

[PATCH 5/5] staging: rtl8723bs: Fix whitespace in comments in rtw_mlme.h

[Subhrojyoti Bala]

Remove extra spaces after /* in single-line comments to comply
with kernel coding style.

No functional change.

Signed-off-by: Subhrojyoti Bala <subhrojyoti0609@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtw_mlme.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging/rtl8723bs/include/rtw_mlme.h
index 59b12d9daa71..1b862ec24d36 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h
@@ -13,8 +13,8 @@
 /* define   MAX_JOIN_TIMEOUT	2500 */
 #define   MAX_JOIN_TIMEOUT	6500
 
-/* 	Commented by Albert 20101105 */
-/* 	Increase the scanning timeout because of increasing the SURVEY_TO value. */
+/* Commented by Albert 20101105 */
+/* Increase the scanning timeout because of increasing the SURVEY_TO value. */
 
 #define		SCANNING_TIMEOUT	8000
 
-- 
2.54.0

Re: [PATCH 0/5] staging: rtl8723bs: Fix coding style issues in header files

[Greg Kroah-Hartman]

On Tue, Jun 16, 2026 at 04:30:43PM +0530, Subhrojyoti Bala wrote:
> This patch series fixes various coding style issues in the
> rtl8723bs staging driver header files, as reported by
> checkpatch.pl:
> 
> - Fix multi-line comment style in wlan_bssdef.h
> - Fix enum indentation in rtw_mlme.h
> - Fix block comment style in rtw_mlme.h
> - Fix multi-line comment style in rtw_mlme.h
> - Fix whitespace in comments in rtw_mlme.h
> 
> Subhrojyoti Bala (5):
>   staging: rtl8723bs: Fix multi-line comment style in wlan_bssdef.h
>   staging: rtl8723bs: Fix indentation in enum in rtw_mlme.h
>   staging: rtl8723bs: Fix block comment style in rtw_mlme.h
>   staging: rtl8723bs: Fix multi-line comment style in rtw_mlme.h
>   staging: rtl8723bs: Fix whitespace in comments in rtw_mlme.h
> 
>  drivers/staging/rtl8723bs/include/rtw_mlme.h  | 55 ++++++++++---------
>  .../staging/rtl8723bs/include/wlan_bssdef.h   | 14 ++---
>  2 files changed, 35 insertions(+), 34 deletions(-)
> 
> Signed-off-by: Subhrojyoti Bala <subhrojyoti0609@gmail.com>
> -- 
> 2.54.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH 0/5] staging: rtl8723bs: Fix coding style issues in header files

[Dan Carpenter]

On Tue, Jun 16, 2026 at 04:30:43PM +0530, Subhrojyoti Bala wrote:
> This patch series fixes various coding style issues in the
> rtl8723bs staging driver header files, as reported by
> checkpatch.pl:
> 
> - Fix multi-line comment style in wlan_bssdef.h
> - Fix enum indentation in rtw_mlme.h
> - Fix block comment style in rtw_mlme.h
> - Fix multi-line comment style in rtw_mlme.h
> - Fix whitespace in comments in rtw_mlme.h
> 

combine patches 1,3-5 since they're all basically the same sort
of patch in the same driver and they're pretty small.

Wait for a day before resending.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter