* [PATCH] staging: rtl8712: fix camel case in function r8712_generate_ie
@ 2022-04-07 12:09 Mahak Gupta
2022-04-07 12:14 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Mahak Gupta @ 2022-04-07 12:09 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-staging,
linux-kernel, outreachy
Cc: Mahak Gupta
Adhere to linux kernel coding style.
Reported by checkpatch:
CHECK: Avoid CamelCase: <beaconPeriod>
Signed-off-by: Mahak Gupta <mahak_g@cs.iitr.ac.in>
---
drivers/staging/rtl8712/ieee80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
index f926809b1021..7d8f1a29d18a 100644
--- a/drivers/staging/rtl8712/ieee80211.c
+++ b/drivers/staging/rtl8712/ieee80211.c
@@ -162,13 +162,13 @@ int r8712_generate_ie(struct registry_priv *registrypriv)
uint sz = 0;
struct wlan_bssid_ex *dev_network = ®istrypriv->dev_network;
u8 *ie = dev_network->IEs;
- u16 beaconPeriod = (u16)dev_network->Configuration.BeaconPeriod;
+ u16 beacon_period = (u16)dev_network->Configuration.BeaconPeriod;
/*timestamp will be inserted by hardware*/
sz += 8;
ie += sz;
/*beacon interval : 2bytes*/
- *(__le16 *)ie = cpu_to_le16(beaconPeriod);
+ *(__le16 *)ie = cpu_to_le16(beacon_period);
sz += 2;
ie += 2;
/*capability info*/
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fix camel case in function r8712_generate_ie
2022-04-07 12:09 [PATCH] staging: rtl8712: fix camel case in function r8712_generate_ie Mahak Gupta
@ 2022-04-07 12:14 ` Julia Lawall
2022-04-07 16:17 ` MAHAK GUPTA
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2022-04-07 12:14 UTC (permalink / raw)
To: Mahak Gupta
Cc: Larry.Finger, florian.c.schilhabel, gregkh, linux-staging,
linux-kernel, outreachy
On Thu, 7 Apr 2022, Mahak Gupta wrote:
> Adhere to linux kernel coding style.
>
> Reported by checkpatch:
>
> CHECK: Avoid CamelCase: <beaconPeriod>
As another patch, you could also adjust the structure field name.
julia
>
> Signed-off-by: Mahak Gupta <mahak_g@cs.iitr.ac.in>
> ---
> drivers/staging/rtl8712/ieee80211.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> index f926809b1021..7d8f1a29d18a 100644
> --- a/drivers/staging/rtl8712/ieee80211.c
> +++ b/drivers/staging/rtl8712/ieee80211.c
> @@ -162,13 +162,13 @@ int r8712_generate_ie(struct registry_priv *registrypriv)
> uint sz = 0;
> struct wlan_bssid_ex *dev_network = ®istrypriv->dev_network;
> u8 *ie = dev_network->IEs;
> - u16 beaconPeriod = (u16)dev_network->Configuration.BeaconPeriod;
> + u16 beacon_period = (u16)dev_network->Configuration.BeaconPeriod;
>
> /*timestamp will be inserted by hardware*/
> sz += 8;
> ie += sz;
> /*beacon interval : 2bytes*/
> - *(__le16 *)ie = cpu_to_le16(beaconPeriod);
> + *(__le16 *)ie = cpu_to_le16(beacon_period);
> sz += 2;
> ie += 2;
> /*capability info*/
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fix camel case in function r8712_generate_ie
2022-04-07 12:14 ` Julia Lawall
@ 2022-04-07 16:17 ` MAHAK GUPTA
2022-04-07 17:58 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: MAHAK GUPTA @ 2022-04-07 16:17 UTC (permalink / raw)
To: Julia Lawall
Cc: Larry.Finger, florian.c.schilhabel, gregkh, linux-staging,
linux-kernel, outreachy
On Thu, Apr 7, 2022 at 5:44 PM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> On Thu, 7 Apr 2022, Mahak Gupta wrote:
>
> > Adhere to linux kernel coding style.
> >
> > Reported by checkpatch:
> >
> > CHECK: Avoid CamelCase: <beaconPeriod>
>
> As another patch, you could also adjust the structure field name.
>
> julia
>
> >
> > Signed-off-by: Mahak Gupta <mahak_g@cs.iitr.ac.in>
> > ---
> > drivers/staging/rtl8712/ieee80211.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> > index f926809b1021..7d8f1a29d18a 100644
> > --- a/drivers/staging/rtl8712/ieee80211.c
> > +++ b/drivers/staging/rtl8712/ieee80211.c
> > @@ -162,13 +162,13 @@ int r8712_generate_ie(struct registry_priv *registrypriv)
> > uint sz = 0;
> > struct wlan_bssid_ex *dev_network = ®istrypriv->dev_network;
> > u8 *ie = dev_network->IEs;
> > - u16 beaconPeriod = (u16)dev_network->Configuration.BeaconPeriod;
> > + u16 beacon_period = (u16)dev_network->Configuration.BeaconPeriod;
> >
> > /*timestamp will be inserted by hardware*/
> > sz += 8;
> > ie += sz;
> > /*beacon interval : 2bytes*/
> > - *(__le16 *)ie = cpu_to_le16(beaconPeriod);
> > + *(__le16 *)ie = cpu_to_le16(beacon_period);
> > sz += 2;
> > ie += 2;
> > /*capability info*/
> > --
> > 2.17.1
> >
> >
> >
Sure, on it. Thanks.
Mahak
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fix camel case in function r8712_generate_ie
2022-04-07 16:17 ` MAHAK GUPTA
@ 2022-04-07 17:58 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2022-04-07 17:58 UTC (permalink / raw)
To: MAHAK GUPTA
Cc: Larry.Finger, florian.c.schilhabel, gregkh, linux-staging,
linux-kernel, outreachy
On Thu, 7 Apr 2022, MAHAK GUPTA wrote:
> On Thu, Apr 7, 2022 at 5:44 PM Julia Lawall <julia.lawall@inria.fr> wrote:
> >
> >
> >
> > On Thu, 7 Apr 2022, Mahak Gupta wrote:
> >
> > > Adhere to linux kernel coding style.
> > >
> > > Reported by checkpatch:
> > >
> > > CHECK: Avoid CamelCase: <beaconPeriod>
> >
> > As another patch, you could also adjust the structure field name.
> >
> > julia
> >
> > >
> > > Signed-off-by: Mahak Gupta <mahak_g@cs.iitr.ac.in>
> > > ---
> > > drivers/staging/rtl8712/ieee80211.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> > > index f926809b1021..7d8f1a29d18a 100644
> > > --- a/drivers/staging/rtl8712/ieee80211.c
> > > +++ b/drivers/staging/rtl8712/ieee80211.c
> > > @@ -162,13 +162,13 @@ int r8712_generate_ie(struct registry_priv *registrypriv)
> > > uint sz = 0;
> > > struct wlan_bssid_ex *dev_network = ®istrypriv->dev_network;
> > > u8 *ie = dev_network->IEs;
> > > - u16 beaconPeriod = (u16)dev_network->Configuration.BeaconPeriod;
> > > + u16 beacon_period = (u16)dev_network->Configuration.BeaconPeriod;
> > >
> > > /*timestamp will be inserted by hardware*/
> > > sz += 8;
> > > ie += sz;
> > > /*beacon interval : 2bytes*/
> > > - *(__le16 *)ie = cpu_to_le16(beaconPeriod);
> > > + *(__le16 *)ie = cpu_to_le16(beacon_period);
> > > sz += 2;
> > > ie += 2;
> > > /*capability info*/
> > > --
> > > 2.17.1
> > >
> > >
> > >
>
> Sure, on it. Thanks.
It's good not to top post, but you can put your response right under the
text you are responding to.
julia
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-07 17:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-07 12:09 [PATCH] staging: rtl8712: fix camel case in function r8712_generate_ie Mahak Gupta
2022-04-07 12:14 ` Julia Lawall
2022-04-07 16:17 ` MAHAK GUPTA
2022-04-07 17:58 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox