* [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h`
@ 2025-05-19 2:04 Eric Florin
2025-05-19 2:04 ` [PATCH 1/9] staging: sm750fb: rename `hw_sm750_initAccel` Eric Florin
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: Eric Florin @ 2025-05-19 2:04 UTC (permalink / raw)
To: teddy.wang
Cc: sudipm.mukherjee, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eric Florin
This set of patches renames function headers declared in
`drivers/staging/sm750fb/sm750.h` to conform with kernel style
guidelines as reported by checkpatch.pl
PATCH #1: Rename `hw_sm750_initAccel` to `hw_sm750_init_accel`
PATCH #2: Rename `hw_sm750_deWait` to `hw_sm750_de_wait`
PATCH #3: Rename `hw_sm750le_deWait` to `hw_sm750le_de_wait`
PATCH #4: Rename `hw_sm750_output_setMode` to `hw_sm750_output_set_mode`
PATCH #5: Rename `hw_sm750_crtc_checkMode` to `hw_sm750_crtc_check_mode`
PATCH #6: Rename `hw_sm750_crtc_setMode` to `hw_sm750_crtc_set_mode`
PATCH #7: Rename `hw_sm750_setColReg` to `hw_sm750_set_col_reg`
PATCH #8: Rename `hw_sm750_setBLANK` to `hw_sm750_set_blank`
PATCH #9: Rename `hw_sm750le_setBLANK` to `hw_sm750le_set_blank`
Eric Florin (9):
staging: sm750fb: rename `hw_sm750_initAccel`
staging: sm750fb: rename `hw_sm750_deWait`
staging: sm750fb: rename `hw_sm750le_deWait`
staging: sm750fb: rename `hw_sm750_output_setMode`
staging: sm750fb: rename `hw_sm750_crtc_checkMode`
staging: sm750fb: rename `hw_sm750_crtc_setMode`
staging: sm750fb: rename `hw_sm750_setColReg`
staging: sm750fb: rename `hw_sm750_setBLANK`
staging: sm750fb: rename `hw_sm750le_setBLANK`
drivers/staging/sm750fb/sm750.c | 12 +++++------
drivers/staging/sm750fb/sm750.h | 30 ++++++++++++++--------------
drivers/staging/sm750fb/sm750_hw.c | 32 +++++++++++++++---------------
3 files changed, 37 insertions(+), 37 deletions(-)
--
2.49.0.1112.g889b7c5bd8-goog
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/9] staging: sm750fb: rename `hw_sm750_initAccel`
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
@ 2025-05-19 2:04 ` Eric Florin
2025-05-19 2:04 ` [PATCH 2/9] staging: sm750fb: rename `hw_sm750_deWait` Eric Florin
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Eric Florin @ 2025-05-19 2:04 UTC (permalink / raw)
To: teddy.wang
Cc: sudipm.mukherjee, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eric Florin
Rename `hw_sm750_initAccel` to `hw_sm750_init_accel` to conform with
kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hw_sm750_initAccel>
Signed-off-by: Eric Florin <ericflorin@google.com>
---
drivers/staging/sm750fb/sm750.h | 2 +-
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index aff69661c8e6..a797985a4df7 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -193,7 +193,7 @@ static inline unsigned long ps_to_hz(unsigned int psvalue)
int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
-void hw_sm750_initAccel(struct sm750_dev *sm750_dev);
+void hw_sm750_init_accel(struct sm750_dev *sm750_dev);
int hw_sm750_deWait(void);
int hw_sm750le_deWait(void);
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index 64b199061d14..a5bb067b30cc 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -173,7 +173,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
/* init 2d engine */
if (!sm750_dev->accel_off)
- hw_sm750_initAccel(sm750_dev);
+ hw_sm750_init_accel(sm750_dev);
return 0;
}
@@ -474,7 +474,7 @@ int hw_sm750_setBLANK(struct lynxfb_output *output, int blank)
return 0;
}
-void hw_sm750_initAccel(struct sm750_dev *sm750_dev)
+void hw_sm750_init_accel(struct sm750_dev *sm750_dev)
{
u32 reg;
--
2.49.0.1112.g889b7c5bd8-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/9] staging: sm750fb: rename `hw_sm750_deWait`
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
2025-05-19 2:04 ` [PATCH 1/9] staging: sm750fb: rename `hw_sm750_initAccel` Eric Florin
@ 2025-05-19 2:04 ` Eric Florin
2025-05-19 2:04 ` [PATCH 3/9] staging: sm750fb: rename `hw_sm750le_deWait` Eric Florin
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Eric Florin @ 2025-05-19 2:04 UTC (permalink / raw)
To: teddy.wang
Cc: sudipm.mukherjee, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eric Florin
Rename `hw_sm750_deWait` to `hw_sm750_de_wait` to conform with kernel
style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hw_sm750_deWait>
Signed-off-by: Eric Florin <ericflorin@google.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
drivers/staging/sm750fb/sm750.h | 2 +-
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index d74836fbdfa3..6a6b48254af8 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -609,7 +609,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
hw_sm750le_setBLANK : hw_sm750_setBLANK;
/* chip specific phase */
sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ?
- hw_sm750le_deWait : hw_sm750_deWait;
+ hw_sm750le_deWait : hw_sm750_de_wait;
switch (sm750_dev->dataflow) {
case sm750_simul_pri:
output->paths = sm750_pnc;
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index a797985a4df7..e24ec6a9799e 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -194,7 +194,7 @@ static inline unsigned long ps_to_hz(unsigned int psvalue)
int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
void hw_sm750_init_accel(struct sm750_dev *sm750_dev);
-int hw_sm750_deWait(void);
+int hw_sm750_de_wait(void);
int hw_sm750le_deWait(void);
int hw_sm750_output_setMode(struct lynxfb_output *output,
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index a5bb067b30cc..5a6ee02bb95f 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -521,7 +521,7 @@ int hw_sm750le_deWait(void)
return -1;
}
-int hw_sm750_deWait(void)
+int hw_sm750_de_wait(void)
{
int i = 0x10000000;
unsigned int mask = SYSTEM_CTRL_DE_STATUS_BUSY |
--
2.49.0.1112.g889b7c5bd8-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/9] staging: sm750fb: rename `hw_sm750le_deWait`
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
2025-05-19 2:04 ` [PATCH 1/9] staging: sm750fb: rename `hw_sm750_initAccel` Eric Florin
2025-05-19 2:04 ` [PATCH 2/9] staging: sm750fb: rename `hw_sm750_deWait` Eric Florin
@ 2025-05-19 2:04 ` Eric Florin
2025-05-19 2:04 ` [PATCH 4/9] staging: sm750fb: rename `hw_sm750_output_setMode` Eric Florin
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Eric Florin @ 2025-05-19 2:04 UTC (permalink / raw)
To: teddy.wang
Cc: sudipm.mukherjee, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eric Florin
Rename `hw_sm750le_deWait` to `hw_sm750le_de_wait` to conform with
kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hw_sm750le_deWait>
Signed-off-by: Eric Florin <ericflorin@google.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
drivers/staging/sm750fb/sm750.h | 2 +-
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 6a6b48254af8..9c62adec9914 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -609,7 +609,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
hw_sm750le_setBLANK : hw_sm750_setBLANK;
/* chip specific phase */
sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ?
- hw_sm750le_deWait : hw_sm750_de_wait;
+ hw_sm750le_de_wait : hw_sm750_de_wait;
switch (sm750_dev->dataflow) {
case sm750_simul_pri:
output->paths = sm750_pnc;
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index e24ec6a9799e..7de3a3d44dce 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -195,7 +195,7 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
void hw_sm750_init_accel(struct sm750_dev *sm750_dev);
int hw_sm750_de_wait(void);
-int hw_sm750le_deWait(void);
+int hw_sm750le_de_wait(void);
int hw_sm750_output_setMode(struct lynxfb_output *output,
struct fb_var_screeninfo *var,
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index 5a6ee02bb95f..49b0d5b91183 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -504,7 +504,7 @@ void hw_sm750_init_accel(struct sm750_dev *sm750_dev)
sm750_dev->accel.de_init(&sm750_dev->accel);
}
-int hw_sm750le_deWait(void)
+int hw_sm750le_de_wait(void)
{
int i = 0x10000000;
unsigned int mask = DE_STATE2_DE_STATUS_BUSY | DE_STATE2_DE_FIFO_EMPTY |
--
2.49.0.1112.g889b7c5bd8-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/9] staging: sm750fb: rename `hw_sm750_output_setMode`
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
` (2 preceding siblings ...)
2025-05-19 2:04 ` [PATCH 3/9] staging: sm750fb: rename `hw_sm750le_deWait` Eric Florin
@ 2025-05-19 2:04 ` Eric Florin
2025-05-19 2:04 ` [PATCH 5/9] staging: sm750fb: rename `hw_sm750_crtc_checkMode` Eric Florin
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Eric Florin @ 2025-05-19 2:04 UTC (permalink / raw)
To: teddy.wang
Cc: sudipm.mukherjee, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eric Florin
Rename `hw_sm750_output_setMode` to `hw_sm750_output_set_mode` to
conform with kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hw_sm750_output_setMode>
Signed-off-by: Eric Florin <ericflorin@google.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
drivers/staging/sm750fb/sm750.h | 6 +++---
drivers/staging/sm750fb/sm750_hw.c | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 9c62adec9914..eb7bae5e2044 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -394,7 +394,7 @@ static int lynxfb_ops_set_par(struct fb_info *info)
}
ret = hw_sm750_crtc_setMode(crtc, var, fix);
if (!ret)
- ret = hw_sm750_output_setMode(output, var, fix);
+ ret = hw_sm750_output_set_mode(output, var, fix);
return ret;
}
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 7de3a3d44dce..7450eb975b1b 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -197,9 +197,9 @@ void hw_sm750_init_accel(struct sm750_dev *sm750_dev);
int hw_sm750_de_wait(void);
int hw_sm750le_de_wait(void);
-int hw_sm750_output_setMode(struct lynxfb_output *output,
- struct fb_var_screeninfo *var,
- struct fb_fix_screeninfo *fix);
+int hw_sm750_output_set_mode(struct lynxfb_output *output,
+ struct fb_var_screeninfo *var,
+ struct fb_fix_screeninfo *fix);
int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc,
struct fb_var_screeninfo *var);
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index 49b0d5b91183..c01abfcea811 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -178,9 +178,9 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
return 0;
}
-int hw_sm750_output_setMode(struct lynxfb_output *output,
- struct fb_var_screeninfo *var,
- struct fb_fix_screeninfo *fix)
+int hw_sm750_output_set_mode(struct lynxfb_output *output,
+ struct fb_var_screeninfo *var,
+ struct fb_fix_screeninfo *fix)
{
int ret;
enum disp_output disp_set;
--
2.49.0.1112.g889b7c5bd8-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/9] staging: sm750fb: rename `hw_sm750_crtc_checkMode`
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
` (3 preceding siblings ...)
2025-05-19 2:04 ` [PATCH 4/9] staging: sm750fb: rename `hw_sm750_output_setMode` Eric Florin
@ 2025-05-19 2:04 ` Eric Florin
2025-05-19 2:04 ` [PATCH 6/9] staging: sm750fb: rename `hw_sm750_crtc_setMode` Eric Florin
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Eric Florin @ 2025-05-19 2:04 UTC (permalink / raw)
To: teddy.wang
Cc: sudipm.mukherjee, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eric Florin
Rename `hw_sm750_crtc_checkMode` to `hw_sm750_crtc_check_mode` to
conform with kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hw_sm750_crtc_checkMode>
Signed-off-by: Eric Florin <ericflorin@google.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
drivers/staging/sm750fb/sm750.h | 4 ++--
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index eb7bae5e2044..d4596590e266 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -512,7 +512,7 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var,
return -ENOMEM;
}
- return hw_sm750_crtc_checkMode(crtc, var);
+ return hw_sm750_crtc_check_mode(crtc, var);
}
static int lynxfb_ops_setcolreg(unsigned int regno,
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 7450eb975b1b..8bf70a3731bf 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -201,8 +201,8 @@ int hw_sm750_output_set_mode(struct lynxfb_output *output,
struct fb_var_screeninfo *var,
struct fb_fix_screeninfo *fix);
-int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc,
- struct fb_var_screeninfo *var);
+int hw_sm750_crtc_check_mode(struct lynxfb_crtc *crtc,
+ struct fb_var_screeninfo *var);
int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
struct fb_var_screeninfo *var,
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index c01abfcea811..3cb69a471c0a 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -219,8 +219,8 @@ int hw_sm750_output_set_mode(struct lynxfb_output *output,
return ret;
}
-int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc,
- struct fb_var_screeninfo *var)
+int hw_sm750_crtc_check_mode(struct lynxfb_crtc *crtc,
+ struct fb_var_screeninfo *var)
{
struct sm750_dev *sm750_dev;
struct lynxfb_par *par = container_of(crtc, struct lynxfb_par, crtc);
--
2.49.0.1112.g889b7c5bd8-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/9] staging: sm750fb: rename `hw_sm750_crtc_setMode`
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
` (4 preceding siblings ...)
2025-05-19 2:04 ` [PATCH 5/9] staging: sm750fb: rename `hw_sm750_crtc_checkMode` Eric Florin
@ 2025-05-19 2:04 ` Eric Florin
2025-05-19 2:04 ` [PATCH 7/9] staging: sm750fb: rename `hw_sm750_setColReg` Eric Florin
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Eric Florin @ 2025-05-19 2:04 UTC (permalink / raw)
To: teddy.wang
Cc: sudipm.mukherjee, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eric Florin
Rename `hw_sm750_crtc_setMode` to `hw_sm750_crtc_set_mode` to conform
with kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hw_sm750_crtc_setMode>
Signed-off-by: Eric Florin <ericflorin@google.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
drivers/staging/sm750fb/sm750.h | 6 +++---
drivers/staging/sm750fb/sm750_hw.c | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index d4596590e266..5f4b0064cf92 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -392,7 +392,7 @@ static int lynxfb_ops_set_par(struct fb_info *info)
pr_err("bpp %d not supported\n", var->bits_per_pixel);
return ret;
}
- ret = hw_sm750_crtc_setMode(crtc, var, fix);
+ ret = hw_sm750_crtc_set_mode(crtc, var, fix);
if (!ret)
ret = hw_sm750_output_set_mode(output, var, fix);
return ret;
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 8bf70a3731bf..db80dd295658 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -204,9 +204,9 @@ int hw_sm750_output_set_mode(struct lynxfb_output *output,
int hw_sm750_crtc_check_mode(struct lynxfb_crtc *crtc,
struct fb_var_screeninfo *var);
-int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
- struct fb_var_screeninfo *var,
- struct fb_fix_screeninfo *fix);
+int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc,
+ struct fb_var_screeninfo *var,
+ struct fb_fix_screeninfo *fix);
int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index,
ushort red, ushort green, ushort blue);
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index 3cb69a471c0a..d3f218cb20f5 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -245,9 +245,9 @@ int hw_sm750_crtc_check_mode(struct lynxfb_crtc *crtc,
}
/* set the controller's mode for @crtc charged with @var and @fix parameters */
-int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
- struct fb_var_screeninfo *var,
- struct fb_fix_screeninfo *fix)
+int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc,
+ struct fb_var_screeninfo *var,
+ struct fb_fix_screeninfo *fix)
{
int ret, fmt;
u32 reg;
--
2.49.0.1112.g889b7c5bd8-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 7/9] staging: sm750fb: rename `hw_sm750_setColReg`
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
` (5 preceding siblings ...)
2025-05-19 2:04 ` [PATCH 6/9] staging: sm750fb: rename `hw_sm750_crtc_setMode` Eric Florin
@ 2025-05-19 2:04 ` Eric Florin
2025-05-19 2:04 ` [PATCH 8/9] staging: sm750fb: rename `hw_sm750_setBLANK` Eric Florin
2025-05-19 2:04 ` [PATCH 9/9] staging: sm750fb: rename `hw_sm750le_setBLANK` Eric Florin
8 siblings, 0 replies; 10+ messages in thread
From: Eric Florin @ 2025-05-19 2:04 UTC (permalink / raw)
To: teddy.wang
Cc: sudipm.mukherjee, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eric Florin
Rename `hw_sm750_setColReg` to `hw_sm750_set_col_reg` to conform with
kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hw_sm750_setColReg>
Signed-off-by: Eric Florin <ericflorin@google.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
drivers/staging/sm750fb/sm750.h | 4 ++--
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 5f4b0064cf92..935c7b1a0fa4 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -545,7 +545,7 @@ static int lynxfb_ops_setcolreg(unsigned int regno,
red >>= 8;
green >>= 8;
blue >>= 8;
- ret = hw_sm750_setColReg(crtc, regno, red, green, blue);
+ ret = hw_sm750_set_col_reg(crtc, regno, red, green, blue);
goto exit;
}
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index db80dd295658..a70f51d08dd2 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -208,8 +208,8 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc,
struct fb_var_screeninfo *var,
struct fb_fix_screeninfo *fix);
-int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index,
- ushort red, ushort green, ushort blue);
+int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index,
+ ushort red, ushort green, ushort blue);
int hw_sm750_setBLANK(struct lynxfb_output *output, int blank);
int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank);
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index d3f218cb20f5..04a0f9218eb8 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -370,8 +370,8 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc,
return ret;
}
-int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index, ushort red,
- ushort green, ushort blue)
+int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index, ushort red,
+ ushort green, ushort blue)
{
static unsigned int add[] = { PANEL_PALETTE_RAM, CRT_PALETTE_RAM };
--
2.49.0.1112.g889b7c5bd8-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 8/9] staging: sm750fb: rename `hw_sm750_setBLANK`
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
` (6 preceding siblings ...)
2025-05-19 2:04 ` [PATCH 7/9] staging: sm750fb: rename `hw_sm750_setColReg` Eric Florin
@ 2025-05-19 2:04 ` Eric Florin
2025-05-19 2:04 ` [PATCH 9/9] staging: sm750fb: rename `hw_sm750le_setBLANK` Eric Florin
8 siblings, 0 replies; 10+ messages in thread
From: Eric Florin @ 2025-05-19 2:04 UTC (permalink / raw)
To: teddy.wang
Cc: sudipm.mukherjee, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eric Florin
Rename `hw_sm750_setBLANK` to `hw_sm750_set_blank` to conform with
kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hw_sm750_setBLANK>
Signed-off-by: Eric Florin <ericflorin@google.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
drivers/staging/sm750fb/sm750.h | 2 +-
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 935c7b1a0fa4..eb7e107bae68 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -606,7 +606,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
crtc->ywrapstep = 0;
output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ?
- hw_sm750le_setBLANK : hw_sm750_setBLANK;
+ hw_sm750le_setBLANK : hw_sm750_set_blank;
/* chip specific phase */
sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ?
hw_sm750le_de_wait : hw_sm750_de_wait;
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index a70f51d08dd2..97682cb8c58f 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -211,7 +211,7 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc,
int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index,
ushort red, ushort green, ushort blue);
-int hw_sm750_setBLANK(struct lynxfb_output *output, int blank);
+int hw_sm750_set_blank(struct lynxfb_output *output, int blank);
int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank);
int hw_sm750_pan_display(struct lynxfb_crtc *crtc,
const struct fb_var_screeninfo *var,
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index 04a0f9218eb8..c64807cd06b3 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -421,7 +421,7 @@ int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank)
return 0;
}
-int hw_sm750_setBLANK(struct lynxfb_output *output, int blank)
+int hw_sm750_set_blank(struct lynxfb_output *output, int blank)
{
unsigned int dpms, pps, crtdb;
--
2.49.0.1112.g889b7c5bd8-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 9/9] staging: sm750fb: rename `hw_sm750le_setBLANK`
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
` (7 preceding siblings ...)
2025-05-19 2:04 ` [PATCH 8/9] staging: sm750fb: rename `hw_sm750_setBLANK` Eric Florin
@ 2025-05-19 2:04 ` Eric Florin
8 siblings, 0 replies; 10+ messages in thread
From: Eric Florin @ 2025-05-19 2:04 UTC (permalink / raw)
To: teddy.wang
Cc: sudipm.mukherjee, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eric Florin
Rename `hw_sm750le_setBLANK` to `hw_sm750le_set_blank` to conform with
kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hw_sm750le_setBLANK>
Signed-off-by: Eric Florin <ericflorin@google.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
drivers/staging/sm750fb/sm750.h | 2 +-
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index eb7e107bae68..1d929aca399c 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -606,7 +606,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
crtc->ywrapstep = 0;
output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ?
- hw_sm750le_setBLANK : hw_sm750_set_blank;
+ hw_sm750le_set_blank : hw_sm750_set_blank;
/* chip specific phase */
sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ?
hw_sm750le_de_wait : hw_sm750_de_wait;
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 97682cb8c58f..9cf8b3d30aac 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -212,7 +212,7 @@ int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index,
ushort red, ushort green, ushort blue);
int hw_sm750_set_blank(struct lynxfb_output *output, int blank);
-int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank);
+int hw_sm750le_set_blank(struct lynxfb_output *output, int blank);
int hw_sm750_pan_display(struct lynxfb_crtc *crtc,
const struct fb_var_screeninfo *var,
const struct fb_info *info);
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index c64807cd06b3..7119b67efe11 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -380,7 +380,7 @@ int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index, ushort red,
return 0;
}
-int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank)
+int hw_sm750le_set_blank(struct lynxfb_output *output, int blank)
{
int dpms, crtdb;
--
2.49.0.1112.g889b7c5bd8-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-05-19 2:05 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
2025-05-19 2:04 ` [PATCH 1/9] staging: sm750fb: rename `hw_sm750_initAccel` Eric Florin
2025-05-19 2:04 ` [PATCH 2/9] staging: sm750fb: rename `hw_sm750_deWait` Eric Florin
2025-05-19 2:04 ` [PATCH 3/9] staging: sm750fb: rename `hw_sm750le_deWait` Eric Florin
2025-05-19 2:04 ` [PATCH 4/9] staging: sm750fb: rename `hw_sm750_output_setMode` Eric Florin
2025-05-19 2:04 ` [PATCH 5/9] staging: sm750fb: rename `hw_sm750_crtc_checkMode` Eric Florin
2025-05-19 2:04 ` [PATCH 6/9] staging: sm750fb: rename `hw_sm750_crtc_setMode` Eric Florin
2025-05-19 2:04 ` [PATCH 7/9] staging: sm750fb: rename `hw_sm750_setColReg` Eric Florin
2025-05-19 2:04 ` [PATCH 8/9] staging: sm750fb: rename `hw_sm750_setBLANK` Eric Florin
2025-05-19 2:04 ` [PATCH 9/9] staging: sm750fb: rename `hw_sm750le_setBLANK` Eric Florin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox